[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

2011-06-27 Thread tobyr 

LGTM

http://gwt-code-reviews.appspot.com/1467808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

2011-06-25 Thread zundel 

LGTM

http://gwt-code-reviews.appspot.com/1467808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

2011-06-25 Thread zundel 


http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java
File
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java
(right):

http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java#newcode48
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java:48:
public boolean setFlag() {
On 2011/06/25 15:59:59, jbrosenberg wrote:

Well, I looked into that.  Since there's no logger passed into this

class, it's

kinda difficult for it to generate warning output.

maybe too much work, but  You could have it change the value of the an
option from false to true, then check the option in the main body
flag... if its true, then print the warning, if its false, go on about
your business silently.

http://gwt-code-reviews.appspot.com/1467808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

2011-06-25 Thread jbrosenberg 


http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java
File
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java
(right):

http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java#newcode48
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java:48:
public boolean setFlag() {
Well, I looked into that.  Since there's no logger passed into this
class, it's kinda difficult for it to generate warning output.

http://gwt-code-reviews.appspot.com/1467808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

2011-06-25 Thread zundel 


http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java
File
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java
(right):

http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java#newcode48
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java:48:
public boolean setFlag() {
Is there some way we can log an ugly advisory warning that this flag has
no effect so people will actually remove it?

http://gwt-code-reviews.appspot.com/1467808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

2011-06-24 Thread jbrosenberg 

This will enable generator result caching by default for both dev mode
and dev-mode tests.


http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):

http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java#newcode481
dev/core/src/com/google/gwt/dev/DevModeBase.java:481: @Override
apologies for the @Override diff cheese

http://gwt-code-reviews.appspot.com/1467808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors