[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
LGTM http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
Why protected? Also, shouldn't the unit tests be updated? http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java
File user/src/com/google/gwt/animation/client/Animation.java (right):
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode203
user/src/com/google/gwt/animation/client/Animation.java:203: * Is the
animation running, even if it hasn't started yet.
Returns true if the animation is running, even if it hasn't started
yet.
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode205
user/src/com/google/gwt/animation/client/Animation.java:205: protected
boolean isRunning() {
Why protected? Since the running() and cancel() methods are public, I'd
imagine there are callers who would be interested in this method being
public.
http://gwt-code-reviews.appspot.com/1891804/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
On 2013/02/28 01:45:15, jtam wrote: Switched to Public. Not sure what you would like me to do in terms of unit tests. This is just exposing an internal which should be already tested. I think just adding appropriate asserts for isRunning()'s return value to AnimationTest would be sufficient. So that in the future if we refactor Animation, that we don't suddenly change the behavior inadvertently. http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)
http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java File user/src/com/google/gwt/animation/client/Animation.java (right): http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java#newcode203 user/src/com/google/gwt/animation/client/Animation.java:203: * Returns true if the animation is running, even if it hasn't started yet. I think javadoc is confusing as it is for a public api as differentiation of started vs running is not made in any place. What about following: Returns true if the animation is running. Note that animation may be 'running' but no callbacks is executed yet. http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
