[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread Amit Manjhi 
LGTM.  Why use a TreeMap in RemoteObjectTable?

On Thu, Sep 24, 2009 at 4:26 PM, j...@google.com wrote:

 Reviewers: amitmanjhi,

 Description:
 This corrects an issue that was there before and implements it on the
 client side of BrowserChannel, as needed by HtmlUnit in hosted mode.

 Please review this at http://gwt-code-reviews.appspot.com/71805

 Affected files:
  dev/oophm/src/com/google/gwt/dev/shell/BrowserChannel.java
  dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelClient.java
  dev/oophm/src/com/google/gwt/dev/shell/BrowserChannelServer.java
  dev/oophm/src/com/google/gwt/dev/shell/JsValueOOPHM.java
  dev/oophm/src/com/google/gwt/dev/shell/ObjectsTable.java
  dev/oophm/src/com/google/gwt/dev/shell/OophmSessionHandler.java
  dev/oophm/src/com/google/gwt/dev/shell/RemoteObjectTable.java
  dev/oophm/src/com/google/gwt/dev/shell/ServerObjectsTable.java
  dev/oophm/test/com/google/gwt/dev/shell/BrowserChannelTest.java
  dev/oophm/test/com/google/gwt/dev/shell/RemoteObjectTableTest.java
  user/src/com/google/gwt/junit/RunStyle.java




--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread John Tamplin 
On Fri, Sep 25, 2009 at 1:22 PM, Amit Manjhi amitman...@google.com wrote:

 LGTM.  Why use a TreeMap in RemoteObjectTable?


I basically kept the same thing that Bob had there before, just moved it
from ThreadLocals to an isolated synchronized class.  I don't see any reason
it needs to be ordered, so I will change it to a HashMap.

Ok to commit with that change?

-- 
John A. Tamplin
Software Engineer (GWT), Google

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread Amit Manjhi 
Yes.

On Fri, Sep 25, 2009 at 10:35 AM, John Tamplin j...@google.com wrote:

 On Fri, Sep 25, 2009 at 1:22 PM, Amit Manjhi amitman...@google.comwrote:

 LGTM.  Why use a TreeMap in RemoteObjectTable?


 I basically kept the same thing that Bob had there before, just moved it
 from ThreadLocals to an isolated synchronized class.  I don't see any reason
 it needs to be ordered, so I will change it to a HashMap.

 Ok to commit with that change?

 --
 John A. Tamplin
 Software Engineer (GWT), Google


--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---