[gwt-contrib] Re: Fix ImageBundleBuilder de-duplication

2009-03-27 Thread Ray Ryan
Misused rietveld and dropped my comments:
http://gwt-code-reviews.appspot.com/15802/diff/1/6
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/15802/diff/1/6#newcode434
Line 434: gwt.imageResource.maxBundleSize, 256);
Please mention this new property in your commit description. Is there
any place to document it?

http://gwt-code-reviews.appspot.com/15802/diff/1/3
File
user/test/com/google/gwt/resources/client/ImageResourceNoInliningTest.java
(right):

http://gwt-code-reviews.appspot.com/15802/diff/1/3#newcode19
Line 19: * Runs the ImageResource tests with inling disabled.
How? By having an overridden module name?

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Fix ImageBundleBuilder de-duplication

2009-03-27 Thread rjrjr

http://gwt-code-reviews.appspot.com/15802

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Fix ImageBundleBuilder de-duplication

2009-03-27 Thread rjrjr

With my stupid question about the test answered offline, LGTM

http://gwt-code-reviews.appspot.com/15802

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---