[gwt-contrib] Re: Fix for typo in JsJsonString (issue1802804)

2013-01-30 Thread mdempsky

On 2013/01/29 22:54:41, goktug wrote:

Can you add a test case? It looks like that line is not covered in any

test

cases.


I think it should be covered by JsonUtilTest.java already, but it looks
like we don't actually test that in production mode.  Also, I think we
don't run the elemental test suite internally at the moment. :/

http://gwt-code-reviews.appspot.com/1802804/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Fix for typo in JsJsonString (issue1802804)

2013-01-29 Thread goktug

On 2013/01/29 22:52:16, mdempsky wrote:

LGTM


Can you add a test case? It looks like that line is not covered in any
test cases.

http://gwt-code-reviews.appspot.com/1802804/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.