[gwt-contrib] Re: Fix initialization of non-final fields (issue1618807)

2012-05-22 Thread rdayal 

Ping (ray).

http://gwt-code-reviews.appspot.com/1618807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix initialization of non-final fields (issue1618807)

2012-04-08 Thread rdayal 

@cromwellian: Can you take another look so we can get this in?

http://gwt-code-reviews.appspot.com/1618807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix initialization of non-final fields (issue1618807)

2011-12-23 Thread cromwellian 


http://gwt-code-reviews.appspot.com/1618807/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):

http://gwt-code-reviews.appspot.com/1618807/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode873
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:873:
// setup the default value, see Issue 380
LGTM. One TODO for future reference: I wonder if we could actually
tighten this up a bit, that is, if every possible constructor writes to
this field, then the default value isn't needed, since it will always be
written. This may be moot if the Closure Compiler handles it.

http://gwt-code-reviews.appspot.com/1618807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors