LGTM

On Tue, Oct 11, 2011 at 11:53 AM, <scheg...@google.com> wrote:

> Reviewers: rjrjr,
>
> Description:
> Generate unique class names in AbstractClientBundleGenerator at design
> time.
>
>
> Please review this at 
> http://gwt-code-reviews.**appspot.com/1565805/<http://gwt-code-reviews.appspot.com/1565805/>
>
> Affected files:
>  M user/src/com/google/gwt/**resources/rebind/context/**
> AbstractClientBundleGenerator.**java
>
>
> Index: user/src/com/google/gwt/**resources/rebind/context/**
> AbstractClientBundleGenerator.**java
> ==============================**==============================**=======
> --- user/src/com/google/gwt/**resources/rebind/context/**
> AbstractClientBundleGenerator.**java (revision 10696)
> +++ user/src/com/google/gwt/**resources/rebind/context/**
> AbstractClientBundleGenerator.**java (working copy)
> @@ -50,6 +50,7 @@
>  import com.google.gwt.user.rebind.**ClassSourceFileComposerFactory**;
>  import com.google.gwt.user.rebind.**SourceWriter;
>
> +import java.beans.Beans;
>  import java.io.PrintWriter;
>  import java.io.Serializable;
>  import java.net.URL;
> @@ -968,6 +969,11 @@
>
>     toReturn.append("_" + getClass().getSimpleName());
>
> +    // If design time, generate new class each time to allow reloading.
> +    if (Beans.isDesignTime()) {
> +      toReturn.append("_designTime" + System.currentTimeMillis());
> +    }
> +
>     return toReturn.toString();
>   }
>
>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to