[gwt-contrib] Re: Generator Result Caching implementation for RPC (issue1235801)

2010-12-21 Thread jbrosenberg 


http://gwt-code-reviews.appspot.com/1235801/diff/1/4
File
user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1235801/diff/1/4#newcode61
user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java:61:
return new RebindResult(RebindStatus.USE_PARTIAL_CACHED,
returnTypeName);
On 2010/12/20 21:22:58, zundel wrote:

I think it would be helpful to document why you chose this

RebindStatus value.

Done.

http://gwt-code-reviews.appspot.com/1235801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for RPC (issue1235801)

2010-12-21 Thread jbrosenberg 

http://gwt-code-reviews.appspot.com/1235801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Generator Result Caching implementation for RPC (issue1235801)

2010-12-20 Thread zundel 

LGTM


http://gwt-code-reviews.appspot.com/1235801/diff/1/4
File
user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1235801/diff/1/4#newcode61
user/src/com/google/gwt/user/rebind/rpc/ServiceInterfaceProxyGenerator.java:61:
return new RebindResult(RebindStatus.USE_PARTIAL_CACHED,
returnTypeName);
I think it would be helpful to document why you chose this RebindStatus
value.

http://gwt-code-reviews.appspot.com/1235801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors