Re: [gwt-contrib] Re: Gerrit presubmit changes

[Matthew Dempsky]

On Wed, Oct 23, 2013 at 1:25 AM, Thomas Broyer  wrote:

> You might want to add those instructions to the README file, for anyone
> willing to hack on them.
>

https://gwt-review.googlesource.com/#/c/5080/

(one issue with the current code, unless you fixed it recently, is that
> it'll post Verified+1 / Verified-1 for old patchsets, in the event that you
> posted a new patchset when the new one was being built – or queued; also, I
> haven't checked, but it'd be great to cancel builds for patchsets that are
> now obsolete, either cancelling them if they're queued or just making them
> no-ops when they'll run)
>

Yep, that's certainly an issue.  The current jenkins interface is pretty
minimal, just enough to fire off additional presubmit jobs
(jenkins.go).
 I imagine it wouldn't be hard to add some additional methods for checking
what presubmit jobs are pending and cancelling a pending job.

Filed https://code.google.com/p/google-web-toolkit/issues/detail?id=8406 to
keep track of it.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: Gerrit presubmit changes

[Thomas Broyer]

You might want to add those instructions to the README file, for anyone 
willing to hack on them.

(one issue with the current code, unless you fixed it recently, is that 
it'll post Verified+1 / Verified-1 for old patchsets, in the event that you 
posted a new patchset when the new one was being built – or queued; also, I 
haven't checked, but it'd be great to cancel builds for patchsets that are 
now obsolete, either cancelling them if they're queued or just making them 
no-ops when they'll run)

On Tuesday, October 22, 2013 8:36:03 PM UTC+2, Matthew Dempsky wrote:
>
> One more update: The presubmitter tools are now open source.
>
> They're written in Go and the source code is available at 
> https://gwt.googlesource.com/buildglue/.  You can easily download and 
> build it using the go command:
>
>   mkdir buildglue
>   export GOPATH=$PWD/buildglue
>   go get gwt.googlesource.com/buildglue.git/cmd/...
>   # Git checkout is now at $GOPATH/src/gwt.googlesource.com/buildglue.git
>   # Compiled tools are now in $GOPATH/bin
>
>
> On Sun, Oct 20, 2013 at 6:57 PM, Matthew Dempsky 
> 
> > wrote:
>
>> I've made a few changes to the presubmit process this weekend that I 
>> wanted to share:
>>
>>   1. There's now an initial "fast style check" step that should give 
>> style feedback much faster (on average within about a minute).  If this 
>> fails, then the usual build/full-style check is skipped.
>>
>>   2. Style warnings are now presented inline as normal Gerrit review 
>> comments so you don't need to dig through the build log to figure out what 
>> went wrong.  E.g., see https://gwt-review.googlesource.com/#/c/5035/ for 
>> an example review.
>>
>>   3. In addition to the usual style 'errors' that the full style check 
>> warns about, the fast style check will include 'info' and 'warning' 
>> messages, but only if they came from a source line modified by the change 
>> (as identified by "git blame").
>>
>>   4. The fast style check now also includes some basic warnings for 
>> commit messages that don't follow Git commit message best 
>> practices.
>>  
>>  Currently it checks that the subject line is <=50 chars, the second line 
>> is blank, and all other lines are <=72 chars.
>>
>>   5. I've configured an issue tracker template for reporting issues with 
>> the presubmitter: 
>> https://code.google.com/p/google-web-toolkit/issues/entry?template=Presubmit%20issue
>>   
>> If you notice anything wrong or that could be improved, please feel free to 
>> submit an issue.
>>
>> Thanks
>>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: Gerrit presubmit changes

[Matthew Dempsky]

One more update: The presubmitter tools are now open source.

They're written in Go and the source code is available at
https://gwt.googlesource.com/buildglue/.  You can easily download and build
it using the go command:

  mkdir buildglue
  export GOPATH=$PWD/buildglue
  go get gwt.googlesource.com/buildglue.git/cmd/...
  # Git checkout is now at $GOPATH/src/gwt.googlesource.com/buildglue.git
  # Compiled tools are now in $GOPATH/bin


On Sun, Oct 20, 2013 at 6:57 PM, Matthew Dempsky wrote:

> I've made a few changes to the presubmit process this weekend that I
> wanted to share:
>
>   1. There's now an initial "fast style check" step that should give style
> feedback much faster (on average within about a minute).  If this fails,
> then the usual build/full-style check is skipped.
>
>   2. Style warnings are now presented inline as normal Gerrit review
> comments so you don't need to dig through the build log to figure out what
> went wrong.  E.g., see https://gwt-review.googlesource.com/#/c/5035/ for
> an example review.
>
>   3. In addition to the usual style 'errors' that the full style check
> warns about, the fast style check will include 'info' and 'warning'
> messages, but only if they came from a source line modified by the change
> (as identified by "git blame").
>
>   4. The fast style check now also includes some basic warnings for commit
> messages that don't follow Git commit message best 
> practices.
>  Currently it checks that the subject line is <=50 chars, the second line
> is blank, and all other lines are <=72 chars.
>
>   5. I've configured an issue tracker template for reporting issues with
> the presubmitter:
> https://code.google.com/p/google-web-toolkit/issues/entry?template=Presubmit%20issue
> If you notice anything wrong or that could be improved, please feel free to
> submit an issue.
>
> Thanks
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.