[gwt-contrib] Re: Issue 7112 (issue1649803)
On 2013/01/28 21:06:02, mdempsky wrote: On 2013/01/12 15:35:19, tbroyer wrote: > We're in dev-time code so we can use Guava (the re-packaged one) and it's > Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode D'oh, you're right indeed! Still, adding a 'private boolean equals(Object x, Object y)' method would make the code easier to read. http://gwt-code-reviews.appspot.com/1649803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Issue 7112 (issue1649803)
On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode, and I don't believe our thirdparty.guava package is available for translation. Maybe in the future we can utilize JDK7's Objects.equals(), but at the moment we have to resort to reimplementing it ourselves here I think. http://gwt-code-reviews.appspot.com/1649803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Issue 7112 (issue1649803)
http://gwt-code-reviews.appspot.com/1649803/diff/1/src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java File src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java (right): http://gwt-code-reviews.appspot.com/1649803/diff/1/src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java#newcode152 src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java:152: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. http://gwt-code-reviews.appspot.com/1649803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
