[gwt-contrib] Re: Make i18n generator use ResourceOracle

2009-06-24 Thread Bruce Johnson 
On Wed, Jun 24, 2009 at 1:59 PM, Scott Blum  wrote:

> Lots.  Like, a whole lot.  I had a measurement at one time but lost them.
> :(  Would take a while to remeasure.


Sold.

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Make i18n generator use ResourceOracle

2009-06-24 Thread Scott Blum 
Lots.  Like, a whole lot.  I had a measurement at one time but lost them. :(
 Would take a while to remeasure.

On Wed, Jun 24, 2009 at 1:47 PM, Bruce Johnson  wrote:

> How much?
>
>
> On Wed, Jun 24, 2009 at 1:45 PM,  wrote:
>
>>
>> Reviewers: ,
>>
>> Description:
>> Makes it go much faster
>>
>> Please review this at http://gwt-code-reviews.appspot.com/48803
>>
>> Affected files:
>>   user/src/com/google/gwt/i18n/rebind/AbstractLocalizableImplCreator.java
>>   user/src/com/google/gwt/i18n/rebind/ResourceFactory.java
>>
>>
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Make i18n generator use ResourceOracle

2009-06-24 Thread jat 

LGTM after the change below.


http://gwt-code-reviews.appspot.com/48803/diff/1/3
File user/src/com/google/gwt/i18n/rebind/ResourceFactory.java (right):

http://gwt-code-reviews.appspot.com/48803/diff/1/3#newcode183
Line 183: Resource resource = resourceMap.get(path);
I think this is going to have the same problem as what Bob found before,
where some resources are on the classpath but not in any module prefix.

So, I think it needs to fallback to looking in the classloader if lookup
in resourceMap fails.

http://gwt-code-reviews.appspot.com/48803

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Make i18n generator use ResourceOracle

2009-06-24 Thread Bruce Johnson 
How much?

On Wed, Jun 24, 2009 at 1:45 PM,  wrote:

>
> Reviewers: ,
>
> Description:
> Makes it go much faster
>
> Please review this at http://gwt-code-reviews.appspot.com/48803
>
> Affected files:
>   user/src/com/google/gwt/i18n/rebind/AbstractLocalizableImplCreator.java
>   user/src/com/google/gwt/i18n/rebind/ResourceFactory.java
>
>
>
> >
>

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---