[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa 

Committed in r10347

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread jlabanca 

LGTM

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread pdr 

On 2011/06/17 15:36:34, fredsa wrote:

http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java

File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):



http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode474

user/src/com/google/gwt/user/tools/WebAppCreator.java:474: +

"\n
PUBLIC \"-//Google Inc.//DTD Google Web Toolkit "
I prefer to keep the version number on the same line as as "Google Web

Toolkit",

i.e.



How's this look?




2.3.0//EN"


"http://google-web-toolkit.googlecode.com/svn/trunk/distro-source/core/src/gwt-module.dtd";>

LGTM

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa 


http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java
File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode474
user/src/com/google/gwt/user/tools/WebAppCreator.java:474: +
"\nhttp://google-web-toolkit.googlecode.com/svn/trunk/distro-source/core/src/gwt-module.dtd";>

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa 

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread pdr 

LGTM


http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java
File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode474
user/src/com/google/gwt/user/tools/WebAppCreator.java:474: +
"\n "...DTD Google Web Toolkit \n"

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa 


http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java
File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode461
user/src/com/google/gwt/user/tools/WebAppCreator.java:461: // Public
builds generate a DTD reference.
On 2011/06/17 13:41:13, pdr wrote:

// Public builds... -> // Generate a DTD reference.


Done.

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode462
user/src/com/google/gwt/user/tools/WebAppCreator.java:462: String
gwtModuleDtd = "\n"
On 2011/06/17 13:41:13, pdr wrote:

Nit: Can you make this less than than 100 chars?


Done.

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode469
user/src/com/google/gwt/user/tools/WebAppCreator.java:469: gwtModuleDtd
= "\n"
I clarified the comment. Strictly speaking, you can use the old DTD.
Your IDE just won't know about any new GWT module features. This comment
ensures developers have a chance to discover this.

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode470
user/src/com/google/gwt/user/tools/WebAppCreator.java:470: +
"\n
Nit: Can we shorten this by adding a newline here?

How's this?

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread fredsa 

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-17 Thread pdr 


http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java
File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode461
user/src/com/google/gwt/user/tools/WebAppCreator.java:461: // Public
builds generate a DTD reference.
// Public builds... -> // Generate a DTD reference.

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode462
user/src/com/google/gwt/user/tools/WebAppCreator.java:462: String
gwtModuleDtd = "\n"
Nit: Can you make this less than than 100 chars?

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode469
user/src/com/google/gwt/user/tools/WebAppCreator.java:469: gwtModuleDtd
= "\n"
Is this requirement practical?

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode470
user/src/com/google/gwt/user/tools/WebAppCreator.java:470: +
"\nhttp://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-16 Thread Fred Sauer 
John,

Mind having a look at this one?

On Thu, Jun 16, 2011 at 2:22 PM,  wrote:

> http://gwt-code-reviews.**appspot.com/1407803/
>



-- 
Fred Sauer
Developer Advocate
Google Inc.
1600 Amphitheatre Parkway
Mountain View, CA 94043
fre...@google.com

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

2011-06-16 Thread fredsa 

http://gwt-code-reviews.appspot.com/1407803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors