[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

Oops, forgot the renderer tests. Added.

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

Bob has offered to take the review.

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

Per our offline conversation, I'll

• move TakesValue back into user.client
• move RequestFactoryEditorDriver back into requestfactory.client
• segerate the user.client.ui dependent bits of editor into
editor.ui.client

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

Ready for re-review.

Also, I forgot to call out another significant change: the separation
between ValueBoxBase and TextBoxBase was pretty dirty before, with VBB
depending upon the nasty pre-enum type TextBoxBase.TextAlignConstant.
Added
an enum and setAlignment method to VBB, and deprecated the old one.

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr 

Submitted so that I'd get out of Phil's way.

On 2010/10/06 01:55:20, rjrjr wrote:




http://gwt-code-reviews.appspot.com/957801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors