LGTM with nits.
http://gwt-code-reviews.appspot.com/34836/diff/1001/2002
File dev/core/src/com/google/gwt/dev/shell/rewrite/HasAnnotation.java
(right):
http://gwt-code-reviews.appspot.com/34836/diff/1001/2002#newcode29
Line 29: * a type.
Should mention the annotation has to be directly on the type without
considering inheritance (perhaps on the hasAnnotation method instead of
here).
http://gwt-code-reviews.appspot.com/34836/diff/1001/2002#newcode50
Line 50: boolean found;
private?
http://gwt-code-reviews.appspot.com/34836/diff/1001/2003
File dev/core/super/com/google/gwt/core/client/BridgeClass.java (right):
http://gwt-code-reviews.appspot.com/34836/diff/1001/2003#newcode26
Line 26: * super-source.
Still not sold on the name, but can't think of anything better. If this
is intended to be something that external code might use, there should
probably be more documentation and an example. If not, it should
probably be documented as such.
http://gwt-code-reviews.appspot.com/34836/diff/1001/2005
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/bridge/UserBridgeClass.java
(right):
http://gwt-code-reviews.appspot.com/34836/diff/1001/2005#newcode32
Line 32: * Test cross-bounday method invocation.
typo
http://gwt-code-reviews.appspot.com/34836/diff/1001/2009
File user/test/com/google/gwt/dev/jjs/bridge/UserBridgeClass.java
(right):
http://gwt-code-reviews.appspot.com/34836/diff/1001/2009#newcode33
Line 33: * Test cross-bounday method invocation.
typo: bounday
http://gwt-code-reviews.appspot.com/34836
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
