[gwt-contrib] Re: RR : Make StyleInjector use Scheduler.scheduleFinally() API
On 2009/10/14 04:58:42, bruce wrote: LGTM with a typo fix. An idea for an incredibly trivial improvement if you just want to change something more for the heck of it. http://gwt-code-reviews.appspot.com/78816/diff/1/2 File user/src/com/google/gwt/dom/client/StyleInjector.java (right): http://gwt-code-reviews.appspot.com/78816/diff/1/2#newcode341 Line 341: * The codewith/code parameter is used to support the deprecated API. with = which http://gwt-code-reviews.appspot.com/78816/diff/1/4 File user/test/com/google/gwt/dom/client/StyleInjectorTest.java (right): http://gwt-code-reviews.appspot.com/78816/diff/1/4#newcode136 Line 136: delayTestFinish(500); (Ignore if you please) The '500' here seems like it wants to be a symbolic constants, along with the other bare '500's elsewhere in the file. LGTM2. http://gwt-code-reviews.appspot.com/78816 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: RR : Make StyleInjector use Scheduler.scheduleFinally() API
LGTM with a typo fix. An idea for an incredibly trivial improvement if you just want to change something more for the heck of it. http://gwt-code-reviews.appspot.com/78816/diff/1/2 File user/src/com/google/gwt/dom/client/StyleInjector.java (right): http://gwt-code-reviews.appspot.com/78816/diff/1/2#newcode341 Line 341: * The codewith/code parameter is used to support the deprecated API. with = which http://gwt-code-reviews.appspot.com/78816/diff/1/4 File user/test/com/google/gwt/dom/client/StyleInjectorTest.java (right): http://gwt-code-reviews.appspot.com/78816/diff/1/4#newcode136 Line 136: delayTestFinish(500); (Ignore if you please) The '500' here seems like it wants to be a symbolic constants, along with the other bare '500's elsewhere in the file. http://gwt-code-reviews.appspot.com/78816 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---