[gwt-contrib] Re: RR : Rework ImageResourceGenerator to address several issues (issue335802)

[bobv]

Ping.

http://gwt-code-reviews.appspot.com/335802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Rework ImageResourceGenerator to address several issues (issue335802)

[Joel Webber]

Crap, sorry. I/O ate my brain. Reviewing now.

Le 2 juin 2010 10:04, b...@google.com a écrit :

 Ping.

 http://gwt-code-reviews.appspot.com/335802/show


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Rework ImageResourceGenerator to address several issues (issue335802)

[jgw]

LGTM.


http://gwt-code-reviews.appspot.com/335802/diff/1/4
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(left):

http://gwt-code-reviews.appspot.com/335802/diff/1/4#oldcode221
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:221:
interface HasRect {
On 2010/04/16 18:24:03, bobv wrote:

Removed this interface because it is silly.


Always a good reason :)

http://gwt-code-reviews.appspot.com/335802/diff/1/6
File user/test/com/google/gwt/resources/client/ImageResourceTest.java
(right):

http://gwt-code-reviews.appspot.com/335802/diff/1/6#newcode167
user/test/com/google/gwt/resources/client/ImageResourceTest.java:167:
assertEquals(128, r.scaledUp().getHeight());
I assume the point of testing both width and height here (even though
only width is set above) is to assert that the image scaled
proportionally, right?

http://gwt-code-reviews.appspot.com/335802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Rework ImageResourceGenerator to address several issues (issue335802)

[BobV]

Thanks for the review.

 http://gwt-code-reviews.appspot.com/335802/diff/1/6#newcode167
 user/test/com/google/gwt/resources/client/ImageResourceTest.java:167:
 assertEquals(128, r.scaledUp().getHeight());
 I assume the point of testing both width and height here (even though
 only width is set above) is to assert that the image scaled
 proportionally, right?

Yes, I'll add a comment to that effect.

-- 
Bob Vawter
Google Web Toolkit Team

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors