[gwt-contrib] Re: Record line numbers for JsExpressions derived from JSNI methods

2009-07-24 Thread scottb 

Mostly LGTM.


http://gwt-code-reviews.appspot.com/51816/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsParser.java (right):

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode159
Line 159: SourceInfo toReturn = program.createSourceInfo(lineno,
parent.getFileName());
Why can't we use the same SourceInfo instance if we borrow the parent's
info?

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode355
Line 355: @SuppressWarnings(unchecked)
All this stuff is really separate, right?

http://gwt-code-reviews.appspot.com/51816

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Record line numbers for JsExpressions derived from JSNI methods

2009-07-24 Thread bobv 


http://gwt-code-reviews.appspot.com/51816/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsParser.java (right):

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode159
Line 159: SourceInfo toReturn = program.createSourceInfo(lineno,
parent.getFileName());
Will change.

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode355
Line 355: @SuppressWarnings(unchecked)
On 2009/07/24 18:07:37, scottb wrote:
 All this stuff is really separate, right?

It's separate, but I thought I would get rid of the warnings while I was
in this file.  If you want, I'll commit it as a separate change.

http://gwt-code-reviews.appspot.com/51816

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Record line numbers for JsExpressions derived from JSNI methods

2009-07-24 Thread scottb 


http://gwt-code-reviews.appspot.com/51816/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsParser.java (right):

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode159
Line 159: SourceInfo toReturn = program.createSourceInfo(lineno,
parent.getFileName());
BTW: I didn't necessarily mean you should change it, but I wanted to ask
the question.  Is it ok to share SourceInfo objects in light of SOYC?

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode355
Line 355: @SuppressWarnings(unchecked)
Separate's always better when there's feelings
invooOOOoooOOooOlved.

http://gwt-code-reviews.appspot.com/51816

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---