[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

[pdr]

http://gwt-code-reviews.appspot.com/738801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

[pdr]

http://gwt-code-reviews.appspot.com/738801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

[rjrjr]

LGTM

Nice! Thanks for the test.

http://gwt-code-reviews.appspot.com/738801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

[Kelly Norton]

We just helped Philip pick one of the bugs on the list for Q3 to help him
get started with the codebase.

/kelly

On Wed, Aug 4, 2010 at 12:53 PM, rj...@google.com wrote:

 Where did this change come from? What's motivating it?


 http://gwt-code-reviews.appspot.com/738801/diff/1/2
 File user/src/com/google/gwt/user/client/ui/ValueBoxBase.java (left):

 http://gwt-code-reviews.appspot.com/738801/diff/1/2#oldcode201
 user/src/com/google/gwt/user/client/ui/ValueBoxBase.java:201: if
 (.equals(text)) {
 This check will have to move after the parsing, or else be declared a
 parser responsibility.


 http://gwt-code-reviews.appspot.com/738801/show




-- 
If you received this communication by mistake, you are entitled to one free
ice cream cone on me. Simply print out this email including all relevant
SMTP headers and present them at my desk to claim your creamy treat. We'll
have a laugh at my emailing incompetence, and play a game of ping pong.
(offer may not be valid in all States).

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removed trim in ValueBoxBase, forcing parsers to handle trim()ing. (issue738801)

[rjrjr]

http://gwt-code-reviews.appspot.com/738801/diff/6001/7002
File user/test/com/google/gwt/user/client/ui/TextBoxTest.java (right):

http://gwt-code-reviews.appspot.com/738801/diff/6001/7002#newcode67
user/test/com/google/gwt/user/client/ui/TextBoxTest.java:67:
assertEquals(  two space padding  ,a.getValueOrThrow());
space after the comma

http://gwt-code-reviews.appspot.com/738801/diff/6001/7002#newcode68
user/test/com/google/gwt/user/client/ui/TextBoxTest.java:68: } catch
(ParseException e) {
setText cannot throw a ParseException. Be sure that you've executed all
lines of a test when you write it.

To test this properly you'll need to put a mock parser in your TextBox
instance and then check that it was actually called.

http://gwt-code-reviews.appspot.com/738801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors