[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
LGTM (In future, it's comforting to see an update to the patch file in rietveld. upload.py makes that pretty trivial) On Thu, Sep 17, 2009 at 11:49 AM, wrote: > user/src/com/google/gwt/rpc/client/RpcService.java will not be included > per the email thread. > > > http://gwt-code-reviews.appspot.com/67802 > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
user/src/com/google/gwt/rpc/client/RpcService.java will not be included per the email thread. http://gwt-code-reviews.appspot.com/67802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
So, lets do the review sans le RpcService change. Thanks, John LaBanca jlaba...@google.com 2009/9/17 Miguel Méndez > On Thu, Sep 17, 2009 at 2:24 PM, Scott Blum wrote: > >> I think the ones in user/test are fine, but may I offer a note of caution >> to the one in user/src? Depending on the settings, some compilers will emit >> a warning if you try to suppress a warning that they don't understand, >> strangely enough. Non-GEP users might therefore get a warning about that on >> RpcService. Maybe the plugin should ignore that one, or many in general >> ones that don't have methods? >> >> > Lets special case RpcService for now. I'll need to convince myself that it > is okay in general to ignore empty interfaces, specially if the super > interfaces do declare methods. > > >> On Thu, Sep 17, 2009 at 2:09 PM, wrote: >> >>> >>> Reviewers: Ray Ryan, >>> >>> Description: >>> Description: >>> >>> The Google Eclipse Plugin generates some error messages in gwt-user >>> because we have some unmatched RemoveServices, which are used in tests. >>> >>> Fix: >>> >>> Add @SuppressWarnings to each instance of this. Also add the gwtNature >>> to the user project file. I'll add the gwtNature to the samples in a >>> separate patch. >>> >>> Testing: >>> >>> All errors are gone in Eclipse. >>> >>> Please review this at http://gwt-code-reviews.appspot.com/67802 >>> >>> Affected files: >>> eclipse/user/.project >>> user/src/com/google/gwt/rpc/client/RpcService.java >>> >>> >>> user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java >>> >>> >>> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java >>> >>> >>> user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java >>> >>> >>> user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java >>> >>> >>> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java >>> >>> >>> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java >>> user/test/com/google/gwt/user/server/rpc/RPCTest.java >>> >>> >>> >>> >>> >> > > > -- > Miguel > > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
On Thu, Sep 17, 2009 at 2:24 PM, Scott Blum wrote: > I think the ones in user/test are fine, but may I offer a note of caution > to the one in user/src? Depending on the settings, some compilers will emit > a warning if you try to suppress a warning that they don't understand, > strangely enough. Non-GEP users might therefore get a warning about that on > RpcService. Maybe the plugin should ignore that one, or many in general > ones that don't have methods? > > Lets special case RpcService for now. I'll need to convince myself that it is okay in general to ignore empty interfaces, specially if the super interfaces do declare methods. > On Thu, Sep 17, 2009 at 2:09 PM, wrote: > >> >> Reviewers: Ray Ryan, >> >> Description: >> Description: >> >> The Google Eclipse Plugin generates some error messages in gwt-user >> because we have some unmatched RemoveServices, which are used in tests. >> >> Fix: >> >> Add @SuppressWarnings to each instance of this. Also add the gwtNature >> to the user project file. I'll add the gwtNature to the samples in a >> separate patch. >> >> Testing: >> >> All errors are gone in Eclipse. >> >> Please review this at http://gwt-code-reviews.appspot.com/67802 >> >> Affected files: >> eclipse/user/.project >> user/src/com/google/gwt/rpc/client/RpcService.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java >> user/test/com/google/gwt/user/server/rpc/RPCTest.java >> >> >> >> >> >> > -- Miguel --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
I actually did ignore it specifically, but I took your suggestion to not do that and simply rely on the annotation. We can treat RpcService specially. On Thu, Sep 17, 2009 at 2:23 PM, Ray Ryan wrote: > Miguel, are you and John in touch on this? I thought you were going to > special case RpcService itself so that we wouldn't need a suppress there. > > > On Thu, Sep 17, 2009 at 11:09 AM, wrote: > >> Reviewers: Ray Ryan, >> >> Description: >> Description: >> >> The Google Eclipse Plugin generates some error messages in gwt-user >> because we have some unmatched RemoveServices, which are used in tests. >> >> Fix: >> >> Add @SuppressWarnings to each instance of this. Also add the gwtNature >> to the user project file. I'll add the gwtNature to the samples in a >> separate patch. >> >> Testing: >> >> All errors are gone in Eclipse. >> >> Please review this at http://gwt-code-reviews.appspot.com/67802 >> >> Affected files: >> eclipse/user/.project >> user/src/com/google/gwt/rpc/client/RpcService.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java >> user/test/com/google/gwt/user/server/rpc/RPCTest.java >> >> >> > -- Miguel --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
I think the ones in user/test are fine, but may I offer a note of caution to the one in user/src? Depending on the settings, some compilers will emit a warning if you try to suppress a warning that they don't understand, strangely enough. Non-GEP users might therefore get a warning about that on RpcService. Maybe the plugin should ignore that one, or many in general ones that don't have methods? On Thu, Sep 17, 2009 at 2:09 PM, wrote: > > Reviewers: Ray Ryan, > > Description: > Description: > > The Google Eclipse Plugin generates some error messages in gwt-user > because we have some unmatched RemoveServices, which are used in tests. > > Fix: > > Add @SuppressWarnings to each instance of this. Also add the gwtNature > to the user project file. I'll add the gwtNature to the samples in a > separate patch. > > Testing: > > All errors are gone in Eclipse. > > Please review this at http://gwt-code-reviews.appspot.com/67802 > > Affected files: > eclipse/user/.project > user/src/com/google/gwt/rpc/client/RpcService.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java > user/test/com/google/gwt/user/server/rpc/RPCTest.java > > > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Supress Google Eclipse Plugin errors in gwt trunk
Miguel, are you and John in touch on this? I thought you were going to special case RpcService itself so that we wouldn't need a suppress there. On Thu, Sep 17, 2009 at 11:09 AM, wrote: > Reviewers: Ray Ryan, > > Description: > Description: > > The Google Eclipse Plugin generates some error messages in gwt-user > because we have some unmatched RemoveServices, which are used in tests. > > Fix: > > Add @SuppressWarnings to each instance of this. Also add the gwtNature > to the user project file. I'll add the gwtNature to the samples in a > separate patch. > > Testing: > > All errors are gone in Eclipse. > > Please review this at http://gwt-code-reviews.appspot.com/67802 > > Affected files: > eclipse/user/.project > user/src/com/google/gwt/rpc/client/RpcService.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java > user/test/com/google/gwt/user/server/rpc/RPCTest.java > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
