[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-27 Thread rchandia

Submitted as r10726

http://gwt-code-reviews.appspot.com/1578806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-26 Thread rchandia


http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java#newcode216
user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java:216:
Boolean rtn = extractConfigProperty(logger, propertyOracle,
LAZY_WIDGET_BUILDERS_PROPERTY, false);
On 2011/10/26 20:28:37, rdayal wrote:

Do you want to set the default value to true?


Done.

http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/1578806/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1009
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1009: return
tokenForStringExpression(source, expression);
On 2011/10/26 20:28:37, rdayal wrote:

Why was this change necessary?


Quoting rjrjr in the original issue:

Fixes unreported bad code gen for things like
a href={uh.oh} when safehtml is off. Fix is a bit squirrelly, but
the intent is to delete the code
in question almost immediately if nothing blows up with new default.

http://gwt-code-reviews.appspot.com/1578806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors