[gwt-contrib] Re: support for internationalized svninfo
XML is a great idea. Unfortunately, I don't think "git svn info" supports XML, but it's also less likely to be localized. On Wed, Jul 8, 2009 at 11:54 AM, Freeland Abbott wrote: > Thanks for comments, all... Ben's seems most directly focused: yes, that > probably is better! > > Amit, I'm embarrassed to admit I hadn't remembered that Scott added a test > case, so it's un-patched. Patch rejected for that reason, as well as Ben's > correction. > > > > On Wed, Jul 8, 2009 at 10:49 AM, Amit Manjhi wrote: > >> I also tried this patch. Build works great. But, 'ant test >> -dgwt.svnrev=...@yyy' fails because >> com.google.gwt.ant.taskdefs.SvnInfoTest fails. If the ant property is >> defined, should the SvnInfoTest be disabled as well? >> >> Regards, >> Amit >> >> >> On Wed, Jul 8, 2009 at 3:22 AM, wrote: >> >>> >>> hi, >>> >>> Today I updated my gwt with the trunk (rev 5687). I removed my changes >>> (uncomment lines). I applied the patch on the file : >>> ./build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java >>> Now it works. I didn't need to create a local.ant.properties file. >>> >>> Thanks ! >>> >>> Best regards, >>> Seb >>> >>> http://gwt-code-reviews.appspot.com/48807 >>> >>> >>> >>> >> > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
Thanks for comments, all... Ben's seems most directly focused: yes, that probably is better! Amit, I'm embarrassed to admit I hadn't remembered that Scott added a test case, so it's un-patched. Patch rejected for that reason, as well as Ben's correction. On Wed, Jul 8, 2009 at 10:49 AM, Amit Manjhi wrote: > I also tried this patch. Build works great. But, 'ant test > -dgwt.svnrev=...@yyy' fails because > com.google.gwt.ant.taskdefs.SvnInfoTest fails. If the ant property is > defined, should the SvnInfoTest be disabled as well? > > Regards, > Amit > > > On Wed, Jul 8, 2009 at 3:22 AM, wrote: > >> >> hi, >> >> Today I updated my gwt with the trunk (rev 5687). I removed my changes >> (uncomment lines). I applied the patch on the file : >> ./build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java >> Now it works. I didn't need to create a local.ant.properties file. >> >> Thanks ! >> >> Best regards, >> Seb >> >> http://gwt-code-reviews.appspot.com/48807 >> >> >> >> > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
I also tried this patch. Build works great. But, 'ant test -dgwt.svnrev=...@yyy' fails because com.google.gwt.ant.taskdefs.SvnInfoTest fails. If the ant property is defined, should the SvnInfoTest be disabled as well? Regards, Amit On Wed, Jul 8, 2009 at 3:22 AM, wrote: > > hi, > > Today I updated my gwt with the trunk (rev 5687). I removed my changes > (uncomment lines). I applied the patch on the file : > ./build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java > Now it works. I didn't need to create a local.ant.properties file. > > Thanks ! > > Best regards, > Seb > > http://gwt-code-reviews.appspot.com/48807 > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
hi, Today I updated my gwt with the trunk (rev 5687). I removed my changes (uncomment lines). I applied the patch on the file : ./build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/SvnInfo.java Now it works. I didn't need to create a local.ant.properties file. Thanks ! Best regards, Seb http://gwt-code-reviews.appspot.com/48807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
> Description: > This is in response to Sebastien's complaint of 1jul09, that trunk > didn't compile because his French svn info gave output that didn't match > our English regexps. > > There are two parts to this: >1. If the output propety is already defined, don't > run svn, don't match the output, don't risk failing. > That would have given Sebastien a workaround, by > defining gwt.svnrev in local.ant.properties. >2. Change the regexps to be word-neutral, so that they > don't care about the language of the tags, just the > shape of the values. This trades a language > sensitivity for a positional one. Wouldn't using svn info --xml solve those problems? -- Benjamin Lerman --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
Actually, if we watch for lines with only one group of digits, and four or more of them, and if we don't care between "Revision" and "Last Changed Rev," then we can have both without being sensitive to the tag, But we'd still balk on non-Roman digits, and thus still need the override assignment. For that matter, RTL languages would probably mess with the URL matches for those, too. :-/ Is it worth trying to catch those cases? On Tue, Jul 7, 2009 at 9:58 PM, Freeland Abbott wrote: > Yes, and this sort of thing makes me nervous. If we assume line separation > and no-space URL presentation, we can get the URL root and branch bits by > looking for URLs without watching for any tags, and assigning the one ending > in "/svn" to root. I don't see a way to do the revision, though. > Which is the reason for the first part, wanting a way for users to assert a > value manually. > > > > On Tue, Jul 7, 2009 at 8:08 PM, John Tamplin wrote: > >> On Tue, Jul 7, 2009 at 6:14 PM, wrote: >> >>> 2. Change the regexps to be word-neutral, so that they >>> don't care about the language of the tags, just the >>> shape of the values. This trades a language >>> sensitivity for a positional one. >>> >> >> Note that some locales may reorder where the variable content goes (I have >> no idea if that is the case for svn), and that some people may be using >> different svn implementations. >> >> -- >> John A. Tamplin >> Software Engineer (GWT), Google >> >> >> >> > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
Yes, and this sort of thing makes me nervous. If we assume line separation and no-space URL presentation, we can get the URL root and branch bits by looking for URLs without watching for any tags, and assigning the one ending in "/svn" to root. I don't see a way to do the revision, though. Which is the reason for the first part, wanting a way for users to assert a value manually. On Tue, Jul 7, 2009 at 8:08 PM, John Tamplin wrote: > On Tue, Jul 7, 2009 at 6:14 PM, wrote: > >> 2. Change the regexps to be word-neutral, so that they >> don't care about the language of the tags, just the >> shape of the values. This trades a language >> sensitivity for a positional one. >> > > Note that some locales may reorder where the variable content goes (I have > no idea if that is the case for svn), and that some people may be using > different svn implementations. > > -- > John A. Tamplin > Software Engineer (GWT), Google > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
On Tue, Jul 7, 2009 at 6:14 PM, wrote: > 2. Change the regexps to be word-neutral, so that they > don't care about the language of the tags, just the > shape of the values. This trades a language > sensitivity for a positional one. > Note that some locales may reorder where the variable content goes (I have no idea if that is the case for svn), and that some people may be using different svn implementations. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: support for internationalized svninfo
I keep getting 500's, but basically LGTM. Though the nested if stuff is a bit torturous to follow. :) On Tue, Jul 7, 2009 at 6:14 PM, wrote: > Reviewers: scottb, chassande_gmail.com, > > Description: > This is in response to Sebastien's complaint of 1jul09, that trunk > didn't compile because his French svn info gave output that didn't match > our English regexps. > > There are two parts to this: > 1. If the output propety is already defined, don't > run svn, don't match the output, don't risk failing. > That would have given Sebastien a workaround, by > defining gwt.svnrev in local.ant.properties. > 2. Change the regexps to be word-neutral, so that they > don't care about the language of the tags, just the > shape of the values. This trades a language > sensitivity for a positional one. > > Please review this at http://gwt-code-reviews.appspot.com/48807 > > Affected files: > SvnInfo.java > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
