[gwt-contrib] Re: test fixes for issue 47802, assertions in all (esp. web mode) tests

2009-07-20 Thread fabbott 

On 2009/07/15 17:16:37, jat wrote:
> LGTM.

> I only reviewed the two requested files -- let me know if I should
review
> anything else.

> http://gwt-code-reviews.appspot.com/47817/diff/1/9
> File user/test/com/google/gwt/dev/jjs/test/CoverageTest.java (right):

> http://gwt-code-reviews.appspot.com/47817/diff/1/9#newcode199
> Line 199: assertTrue(0.01 > Math.abs(1.2f - val));
> I find ordering it this way to be less clear -- I would prefer
Math.abs() <
> EPSILON (and defining EPSILON appropriately) as it seems to clearly
indicate
> what is being done.

Done.

http://gwt-code-reviews.appspot.com/47817

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: test fixes for issue 47802, assertions in all (esp. web mode) tests

2009-07-15 Thread jat 

LGTM.

I only reviewed the two requested files -- let me know if I should
review anything else.


http://gwt-code-reviews.appspot.com/47817/diff/1/9
File user/test/com/google/gwt/dev/jjs/test/CoverageTest.java (right):

http://gwt-code-reviews.appspot.com/47817/diff/1/9#newcode199
Line 199: assertTrue(0.01 > Math.abs(1.2f - val));
I find ordering it this way to be less clear -- I would prefer
Math.abs() < EPSILON (and defining EPSILON appropriately) as it seems to
clearly indicate what is being done.

http://gwt-code-reviews.appspot.com/47817

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---