[gwt-contrib] TextBoxBase to implement HasDirection instead of its children

2010-02-02 Thread Tomer Greenberg 
Hello gwters,

I'm going to add some BiDi functionality to TextBox and TextArea. Given that
their parent, TextBoxBase, doesn't implement HasDirection, this has to be
done (in an identical manner) for TextBox and TextArea separately. But then,
why won't TextBoxBase implement HasDirection instead of its children? This
way we could save a lot of code duplication, and it's also reasonable - if
it has text, it also has direction.

Any objections?

Thanks

Tomer

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] TextBoxBase to implement HasDirection instead of its children

2010-02-02 Thread Ray Ryan 
Extending TextBoxBase sounds perfectly reasonable, but what exactly are you
proposing to implement there?

On Tue, Feb 2, 2010 at 10:58 AM, Tomer Greenberg tomer...@google.comwrote:

 Hello gwters,

 I'm going to add some BiDi functionality to TextBox and TextArea. Given
 that their parent, TextBoxBase, doesn't implement HasDirection, this has to
 be done (in an identical manner) for TextBox and TextArea separately. But
 then, why won't TextBoxBase implement HasDirection instead of its children?
 This way we could save a lot of code duplication, and it's also reasonable -
 if it has text, it also has direction.

 Any objections?

 Thanks

 Tomer


  --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors




-- 
I wish this were a Wave

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors