Reviewers: mdempsky,
Description:
Update the DevMode Chrome plugin's Makefile to build a zip file to
upload to the Chrome web store.
Instead of building a crx file, we build a zip file containing the files
to upload. Also, the Chrome web store doesn't allow the key or update
URL to be set in the manifest.
Please review this at http://gwt-code-reviews.appspot.com/1858803/
Affected files:
M plugins/npapi/Makefile
M plugins/npapi/manifest-template.json
M plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
Index: plugins/npapi/Makefile
===================================================================
--- plugins/npapi/Makefile (revision 11340)
+++ plugins/npapi/Makefile (working copy)
@@ -54,30 +54,30 @@
OBJ_OUTDIR = build/$(TARGET_PLATFORM)
EXTENSION_OUTDIR = prebuilt/gwt-dev-plugin
+EXTENSION_FILES = *.html *.js *.png *.txt \
+ DevModeOptions/*.gif DevModeOptions/*.js DevModeOptions/*.txt \
+ Linux*/*.so WIN*/*.dll Darwin*/*/*/*.plist Darwin*/*/*/*/*.dylib
PLATFORM_DIR = $(EXTENSION_OUTDIR)/$(TARGET_PLATFORM)
PLATFORM_DIR_SUFFIX ?= ""
-INSTALLER_CRX = prebuilt/gwt-dev-plugin.crx
DLL = $(OBJ_OUTDIR)/libGwtDevPlugin$(DLL_SUFFIX)
-GWTDEV_CRX_PEM ?= $(CURDIR)/gwt-dev-plugin.pem
-CHROME_COMMAND = $(CHROME_PATH)
--pack-extension=$(CURDIR)/$(EXTENSION_OUTDIR) --no-message-box
--user-data-dir=$(CURDIR)/$(OBJ_OUTDIR)/user-data
--pack-extension-key=$(GWTDEV_CRX_PEM)
-
-#DLLFLAGS +=
+#DLLFLAGS +=
VERSION ?= 1.0.$(shell ./getversion)
ifeq ($(VERSION), 1.0.)
$(error You must specify the version if you are not in an svn checkout)
endif
-.PHONY: default all crx lib common clean depend install install-platform \
+.PHONY: default all zip lib common clean depend install install-platform \
versioned-files devmodeoptions
default:: lib versioned-files devmodeoptions
-all:: common lib install-platform crx
+all:: common lib install-platform zip
lib:: $(OBJ_OUTDIR) $(EXTENSION_OUTDIR) $(DLL)
-crx:: $(EXTENSION_OUTDIR) $(INSTALLER_CRX)
+zip:: $(EXTENSION_OUTDIR)
+ (cd $(EXTENSION_OUTDIR); zip ../upload.zip $(EXTENSION_FILES))
linuxplatforms:
$(MAKE) lib ARCH=x86
@@ -108,9 +108,6 @@
$(OBJ_OUTDIR)::
@mkdir -p $@
-
-$(INSTALLER_CRX): $(GWTDEV_CRX_PEM) $(EXTENSION_OUTDIR) versioned-files
- $(shell $(CHROME_COMMAND))
versioned-files::
sed -e s/GWT_DEV_PLUGIN_VERSION/$(VERSION)/ manifest-template.json
prebuilt/gwt-dev-plugin/manifest.json
Index: plugins/npapi/manifest-template.json
===================================================================
--- plugins/npapi/manifest-template.json (revision 11340)
+++ plugins/npapi/manifest-template.json (working copy)
@@ -4,7 +4,6 @@
"manifest_version": 2,
"description": "A plugin to enable debugging with GWT's Development
Mode",
- "update_url": "https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml";,
"icons": {
"16": "gwt16.png",
"32": "gwt32.png",
@@ -13,7 +12,6 @@
"128": "gwt128.png"
},
- "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDi6RrEy9YllRLM8bGBcIEk5ECAG2z+8ngTz7wwzRAQJpOzDp1Alq8fQFjH0+dzxok4RFLrWKHjxGqvXzWyWyTEo2nY3ScHLN/RoANMs8pl9X6TygRyO+3naqZOtLCrYHfV49JKXnYoFVbY5eBVYxHYY3BHAOKJj9onyAM4UPmMzQIDAQAB",
"background": {
"page": "background.html"
},
Index: plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
===================================================================
--- plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (revision 11340)
+++ plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (working copy)
@@ -4,7 +4,6 @@
"manifest_version": 2,
"description": "A plugin to enable debugging with GWT's Development
Mode",
- "update_url": "https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml";,
"icons": {
"16": "gwt16.png",
"32": "gwt32.png",
@@ -13,7 +12,6 @@
"128": "gwt128.png"
},
- "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDi6RrEy9YllRLM8bGBcIEk5ECAG2z+8ngTz7wwzRAQJpOzDp1Alq8fQFjH0+dzxok4RFLrWKHjxGqvXzWyWyTEo2nY3ScHLN/RoANMs8pl9X6TygRyO+3naqZOtLCrYHfV49JKXnYoFVbY5eBVYxHYY3BHAOKJj9onyAM4UPmMzQIDAQAB",
"background": {
"page": "background.html"
},
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
