[gwt-contrib] Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls (issue1426802)

Tue, 19 Apr 2011 09:06:47 -0700 

Reviewers: jat,

Description:
Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls
Use constants from TreeLogger rather than accessing TreeLogger.Type
directly
where possible


Please review this at http://gwt-code-reviews.appspot.com/1426802/

Affected files:
M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java 
  M dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
  M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
  M dev/core/src/com/google/gwt/dev/AnalyzeModule.java
  M dev/core/src/com/google/gwt/dev/CompileModule.java
  M dev/core/src/com/google/gwt/dev/CompilePermsServer.java
  M dev/core/src/com/google/gwt/dev/Compiler.java
  M dev/core/src/com/google/gwt/dev/DevMode.java
  M dev/core/src/com/google/gwt/dev/ExternalPermutationWorkerFactory.java
  M dev/core/src/com/google/gwt/dev/GWTCompiler.java
  M dev/core/src/com/google/gwt/dev/Link.java
  M dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
  M dev/core/src/com/google/gwt/dev/Precompile.java
  M dev/core/src/com/google/gwt/dev/PrecompileOnePerm.java
  M dev/core/src/com/google/gwt/dev/ServletValidator.java
  M dev/core/src/com/google/gwt/dev/SwingUI.java
  M dev/core/src/com/google/gwt/dev/cfg/ConditionWhenPropertyIs.java
  M dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java
  M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
  M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
  M dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
  M dev/core/src/com/google/gwt/dev/javac/Dependencies.java
  M dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
  M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
  M dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java
  M dev/core/src/com/google/gwt/dev/jdt/BasicWebModeCompiler.java
  M dev/core/src/com/google/gwt/dev/jjs/EnumNameObfuscator.java
  M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java
  M dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
  M dev/core/src/com/google/gwt/dev/shell/BrowserChannelClient.java
  M dev/core/src/com/google/gwt/dev/shell/BrowserListener.java
  M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
  M dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.java
  M dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java
  M dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
  M dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
  M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
  M dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
  M dev/core/src/com/google/gwt/dev/shell/log/SwingTreeLogger.java
  M dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
  M dev/core/src/com/google/gwt/dev/shell/tomcat/EmbeddedTomcatServer.java
  M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerLogLevel.java
  M user/src/com/google/gwt/i18n/rebind/AbstractLocalizableImplCreator.java
  M user/src/com/google/gwt/i18n/rebind/ResourceFactory.java
  M user/src/com/google/gwt/resources/css/ClassRenamer.java
  M user/src/com/google/gwt/resources/css/GenerateCssAst.java
  M user/src/com/google/gwt/resources/css/InterfaceGenerator.java
  M user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java
M user/src/com/google/gwt/resources/rebind/context/StaticResourceContext.java 
  M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
  M user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
  M user/src/com/google/gwt/uibinder/rebind/FieldManager.java
  M user/src/com/google/gwt/uibinder/rebind/W3cDocumentBuilder.java
  M user/src/com/google/gwt/user/rebind/AbstractGeneratorClassCreator.java
  M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
M user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java 
  M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
  M user/src/com/google/gwt/util/regexfilter/RegexFilter.java
  M user/src/com/google/gwt/validation/rebind/BeanHelper.java
M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java M user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/ConstraintCompositionCompileTest.java M user/test/org/hibernate/jsr303/tck/tests/constraints/customconstraint/CustomConstraintValidatorCompileTest.java M user/test/org/hibernate/jsr303/tck/tests/constraints/validatorresolution/ValidatorResolutionCompileTest.java M user/test/org/hibernate/jsr303/tck/tests/validation/ValidateCompileTest.java 


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to