Re: [gwt-contrib] Re: 2.6.0-rc2

2013-12-03 Thread Goktug Gokdogan 
I sent it for cherry-picking earlier today. There was a few other missing
patches as well. Matthew is going to release RC3 soon.


On Tue, Dec 3, 2013 at 11:01 AM, Colin Alworth niloc...@gmail.com wrote:

 What's the current thinking on removing ImageResource.isStandalone from
 2.6.0 final, as in the https://gwt-review.googlesource.com/#/c/5504/review?

 It isn't in GWT 2.5.x, and isn't in master, but is present in both
 2.6.0-rc1 and 2. If it was an oversight to add this the first time around,
 shouldn't it be dropped from 2.6 before it goes final?

 Aside from that, seems to be passing all our smoke tests so far, will have
 more comprehensive results tomorrow.

 -Colin


 On Monday, December 2, 2013 4:49:29 PM UTC-6, Matthew Dempsky wrote:

 I cut a new 2.6.0 release candidate this morning:

   1. There's a 2.6.0-rc2 tag in git.
   2. The gwt-2.6.0-rc2.zip is available on Google Code:
 https://code.google.com/p/google-web-toolkit/downloads/list
   3. I've pushed a 2.6.0-rc2 release to Maven Central (as usual, I think
 it takes an hour or so to be available).

 We originally planned to make the final release today, but I had
 forgotten to take Thanksgiving into account, so I think we'll push the
 release back until next week.  I'd appreciate if people could help test and
 wring out any remaining bugs.

 There's still the outstanding version warning from GPE, but a fix for
 that has already been submitted, and a new GPE release will hopefully be
 available in the next few days.

 Changes since 2.6.0-rc1: https://gwt.googlesource.com/gwt/+log/2.6.
 0-rc1..2.6.0-rc2

  --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors
 ---
 You received this message because you are subscribed to the Google Groups
 GWT Contributors group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT 
Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: 2.6.0-rc2

2013-12-03 Thread Matthew Dempsky 
On Tue, Dec 3, 2013 at 11:01 AM, Colin Alworth niloc...@gmail.com wrote:

 What's the current thinking on removing ImageResource.isStandalone from
 2.6.0 final, as in the https://gwt-review.googlesource.com/#/c/5504/review?


Thomas added ImageResource.isStandalone several months ago (between 2.5.1
and 2.6.0), and it's been the longest outstanding patch for us [Google] to
merge for internal customers.  We have a surprisingly large amount of
internal code that implements ImageResource, and adding a new method to the
interface broke all of those users.

As an interim solution, Goktug proposed we restructure things so the same
change Thomas wanted is possible, but without making it into a breaking
change for 2.6.0.

It isn't in GWT 2.5.x, and isn't in master, but is present in both
 2.6.0-rc1 and 2. If it was an oversight to add this the first time around,
 shouldn't it be dropped from 2.6 before it goes final?


Yep, I plan to cut a new rc3 today.

Aside from that, seems to be passing all our smoke tests so far, will have
 more comprehensive results tomorrow.


Cool, thanks for testing!

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT 
Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.