Re: [gwt-contrib] Remove unused code of external JavaScript file?

2015-12-31 Thread Colin Alworth
The short answer is yes, it can all go into one method, or several methods,
etc. The important part is "what does that JS expect to do", and how might
we accidentally break it by letting a compiler at it.

With that big of a file, I'm afraid I don't have time right now to take it
apart piece by piece and see what might break. Also, this is really the
wrong venue for a question not about contributing to GWT - I suggest
continuing on the regular GWT mailing list, a stackoverflow post, or in
gitter.im/project/gwt or in the ##gwt channel in freenode.

On Thu, Dec 31, 2015 at 4:38 AM confile 
wrote:

> Okay, When I put the code of the external JS file in a JSNI method. Do I
> have to put all the code I one method? To have a concrete example here is
> the code I use:
>
>
> https://github.com/Atmosphere/atmosphere-javascript/blob/master/modules/javascript/src/main/webapp/javascript/atmosphere.js
>
> Could you please give an example of how you would do it in this case?
>
>
> Am Donnerstag, 31. Dezember 2015 01:17:44 UTC+1 schrieb Colin Alworth:
>
>> It depends on how you are including the JavaScript source.
>>
>> If it is a 

Re: [gwt-contrib] Remove unused code of external JavaScript file?

2015-12-31 Thread confile
Okay, When I put the code of the external JS file in a JSNI method. Do I 
have to put all the code I one method? To have a concrete example here is 
the code I use: 

https://github.com/Atmosphere/atmosphere-javascript/blob/master/modules/javascript/src/main/webapp/javascript/atmosphere.js

Could you please give an example of how you would do it in this case?


Am Donnerstag, 31. Dezember 2015 01:17:44 UTC+1 schrieb Colin Alworth:
>
> It depends on how you are including the JavaScript source. 
>
> If it is a 

Re: [gwt-contrib] Remove unused code of external JavaScript file?

2015-12-30 Thread Colin Alworth
It depends on how you are including the JavaScript source.

If it is a