[GRASS-dev] [GRASS GIS] #1527: vector projection over wrapping boundary is split
#1527: vector projection over wrapping boundary is split
--+-
Reporter: pertusus | Owner: grass-dev@…
Type: defect| Status: new
Priority: normal| Milestone: 7.0.0
Component: Vector| Version: svn-trunk
Keywords:|Platform: Linux
Cpu: x86-64|
--+-
When I project a vector from a location thet overlaps with a wrapping
boundary of a map, the vector is split in two. For example, I have a
longitude latitude location covering the whole world, that wraps somewhere
in the Pacific (that is points on the eastern boundary are also on the
western boundary). When I project a vector constructed by doing a grid on
a Lambert equal area location centered somewhere in the Pacific, the grid
cells (that are, in that case, no more rectangular) that fall on the
boundary are cut in two, with warnings like:
{{{
WARNING: Number of centroids exceeds number of areas: 900 847
WARNING: Number of incorrect boundaries: 507
WARNING: Number of centroids outside area: 53
}}}
I attach a tarball to reproduce the issue (there is a png showing the
issue in the tarball too). The script to do everything (setup the lambert
location, and then the world map and do the png) is ./bug_wrap.sh.
--
Ticket URL: http://trac.osgeo.org/grass/ticket/1527
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] projection of vectors accros wrapping map boundaries
On Thu, Dec 29, 2011 at 05:52:16PM +0100, Markus Neteler wrote: Yes, for both 6.4 and 7 cases would be ideal. That increases tremendously the motivation to try and fix it :) For 7, I have filled http://trac.osgeo.org/grass/ticket/1527 For 6.4, I don't remember exactly the issue, and I don't have a simple reproducer, nor a test platform, so I am not able to report it for now. -- Pat ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1527: vector projection over wrapping boundary is split
#1527: vector projection over wrapping boundary is split --+- Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: new Priority: normal| Milestone: 7.0.0 Component: Vector| Version: svn-trunk Keywords:|Platform: Linux Cpu: x86-64| --+- Comment(by mmetz): Please try attached patch for v.proj. The bug is in the proj4 library which automatically wraps to -180 - 180 if the output location is latlon. This does not work with topological vectors and causes the observed error messages. The attached patch tries to automatically figure out if wrapping coordinates to the range 0-360 is needed and wraps if needed (should be made a user option I guess). BTW, this bug appears also in GRASS 6.4, only that 6.4 does less thorough topological error checking. Markus M -- Ticket URL: http://trac.osgeo.org/grass/ticket/1527#comment:1 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1525: r.mask cannot use float maps
#1525: r.mask cannot use float maps --+- Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: new Priority: normal| Milestone: 7.0.0 Component: Raster| Version: svn-trunk Keywords:|Platform: Linux Cpu: x86-64| --+- Comment(by pertusus): In fact, the patch I propose leads to other issues down the line. I have found that r.mapcalc with a mask done with a FCELL raster type fails strangely later (I have a reproducer for that, in case it is not normal). So forget about my patch. -- Ticket URL: http://trac.osgeo.org/grass/ticket/1525#comment:1 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1525: r.mask cannot use float maps
#1525: r.mask cannot use float maps --+- Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: new Priority: minor | Milestone: 7.0.0 Component: Raster| Version: svn-trunk Keywords:|Platform: Linux Cpu: x86-64| --+- Changes (by pertusus): * priority: normal = minor -- Ticket URL: http://trac.osgeo.org/grass/ticket/1525#comment:2 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1525: r.mask cannot use float maps
#1525: r.mask cannot use float maps --+- Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: new Priority: minor | Milestone: 7.0.0 Component: Raster| Version: svn-trunk Keywords:|Platform: Linux Cpu: x86-64| --+- Comment(by pertusus): Well, seems that the issue with r.mapcalc also happens with CELL raster maps, and is very hard to reproduce... So my patch may still be relevant... -- Ticket URL: http://trac.osgeo.org/grass/ticket/1525#comment:3 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] r.series and r.series.interpol
Dear all, just for your information. I have added a new option to r.series to specify a weighting factor to each map in a series. Weighting is needed to aggregate overlapping/containing interval time series correctly in case of average and sum operations. The new temporal modules tr.aggregate and tr.aggregate.ds need this option. Furthermore i have added a new module (r.series.interpol) to interpolate raster map series located temporal or spatial in between existing raster maps. This module is still under development and implements currently only simple linear interpolation in a normalized interval. I plan to implement step-wise linear interpolation[1] and natural cubic spline interpolation[2]. Because of the large amount of files related to the unit and regression tests located in the modules directory, we should use a dedicated one. Hence, i will move successively all files related to testing into new directories named test located in the module directories. Best regards and happy new year 2012 Soeren [1] http://en.wikipedia.org/wiki/Interpolation#Linear_interpolation [2] http://en.wikipedia.org/wiki/Spline_interpolation ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1525: r.mask cannot use float maps
#1525: r.mask cannot use float maps --+- Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: new Priority: minor | Milestone: 7.0.0 Component: Raster| Version: svn-trunk Keywords:|Platform: Linux Cpu: x86-64| --+- Comment(by pertusus): Replying to [comment:3 pertusus]: Well, seems that the issue with r.mapcalc also happens with CELL raster maps, and is very hard to reproduce... So my patch may still be relevant... Sorry, this is wrong, the issue only happens with FCELL raster maps as r.mask... -- Ticket URL: http://trac.osgeo.org/grass/ticket/1525#comment:4 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] r.series and r.series.interpol
Hi, 2011/12/30 Sören Gebbert soerengebb...@googlemail.com: Furthermore i have added a new module (r.series.interpol) to great! Just a small note, maybe we should follow same naming convention, see `r.resamp.interp`. Martin -- Martin Landa landa.martin gmail.com * http://geo.fsv.cvut.cz/~landa ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1527: vector projection over wrapping boundary is split
#1527: vector projection over wrapping boundary is split
---+
Reporter: pertusus | Owner: grass-dev@…
Type: defect| Status: closed
Priority: normal| Milestone: 7.0.0
Component: Vector| Version: svn-trunk
Resolution: fixed |Keywords:
Platform: Linux | Cpu: x86-64
---+
Changes (by pertusus):
* status: new = closed
* resolution: = fixed
Comment:
There are those compilation warnings with -Wall.
{{{
main.c:54: attention : ‘src_box.N’ may be used uninitialized in this
function
main.c:54: attention : ‘src_box.S’ may be used uninitialized in this
function
main.c:54: attention : ‘src_box.E’ may be used uninitialized in this
function
main.c:54: attention : ‘src_box.W’ may be used uninitialized in this
function
main.c:54: attention : ‘tgt_box.W’ may be used uninitialized in this
function
}}}
The bug seems to be fixed for my reproducer case. I will reopen if it
doesn't fix my 'real world' case.
--
Ticket URL: http://trac.osgeo.org/grass/ticket/1527#comment:2
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] r.series and r.series.interpol
Sören, This is very interesting -- I think I may have an immediate application for these modules... Best to you in 2012 and thank you for your development activities! Regards, Tom 2011/12/30 Sören Gebbert soerengebb...@googlemail.com Dear all, just for your information. I have added a new option to r.series to specify a weighting factor to each map in a series. Weighting is needed to aggregate overlapping/containing interval time series correctly in case of average and sum operations. The new temporal modules tr.aggregate and tr.aggregate.ds need this option. Furthermore i have added a new module (r.series.interpol) to interpolate raster map series located temporal or spatial in between existing raster maps. This module is still under development and implements currently only simple linear interpolation in a normalized interval. I plan to implement step-wise linear interpolation[1] and natural cubic spline interpolation[2]. Because of the large amount of files related to the unit and regression tests located in the modules directory, we should use a dedicated one. Hence, i will move successively all files related to testing into new directories named test located in the module directories. Best regards and happy new year 2012 Soeren [1] http://en.wikipedia.org/wiki/Interpolation#Linear_interpolation [2] http://en.wikipedia.org/wiki/Spline_interpolation ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev -- Thomas E Adams National Weather Service Ohio River Forecast Center 1901 South State Route 134 Wilmington, OH 45177 EMAIL: thomas.ad...@noaa.gov VOICE: 937-383-0528 FAX:937-383-0033 ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1527: vector projection over wrapping boundary is split
#1527: vector projection over wrapping boundary is split ---+ Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: closed Priority: normal| Milestone: 7.0.0 Component: Vector| Version: svn-trunk Resolution: fixed |Keywords: Platform: Linux | Cpu: x86-64 ---+ Comment(by neteler): Perhaps these reports should remain open until the backporting is done? -- Ticket URL: http://trac.osgeo.org/grass/ticket/1527#comment:3 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Re: [GRASS GIS] #1525: r.mask cannot use float maps
#1525: r.mask cannot use float maps --+- Reporter: pertusus | Owner: grass-dev@… Type: defect| Status: new Priority: minor | Milestone: 7.0.0 Component: Raster| Version: svn-trunk Keywords:|Platform: Linux Cpu: x86-64| --+- Comment(by glynn): Replying to [ticket:1525 pertusus]: I had a look at r.mask and r.mask for 6.4.1, besides being a python script, the difference seems to be that in the svn version there is a test that the map is indeed a CELL map, which fails and give the error message, while there was no such test in the shell script. The code is along The test was added (incorrectly) in r46379. The CELL requirement should only apply if the maskcats= option was given. Fixed in r49997. Maybe r.reclass does the magic float to integer quantification stuff? The conversion is performed when the mask is used, not when it is set. It isn't necessary to use r.mask to create a mask; if a map named MASK exists in the current mapset, it is automatically used as a mask. The code which reads raster maps always reads the mask as CELL. The conversion from the stored type to the requested type (using quantisation rules in the case of FP-integer conversions) is built into libraster (libgis in versions before 7.0). -- Ticket URL: http://trac.osgeo.org/grass/ticket/1525#comment:5 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
