Re: [GRASS-dev] planning grass 7.0.0beta4
Hi devs, after having spent many hours on http://trac.osgeo.org/grass/ticket/2409 I'll tag beta4 later today. Then we can release RC1 by end of the year. Best Markus ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] planning grass 7.0.0beta4
On Mon, Dec 22, 2014 at 9:25 AM, Markus Neteler nete...@osgeo.org wrote: Hi devs, after having spent many hours on http://trac.osgeo.org/grass/ticket/2409 I'll tag beta4 later today. Here the improvement: from 48% of success back to 88% of success: http://fatra.cnr.ncsu.edu/grassgistests/summary_report/nc/files_percent_plot.png (see right end of graph) The remaining issues are, as outlined in my email from Saturday - related to missing maps on the test server - some Python/PyGRASS definition bugs. Tagging beta4 now... Markus ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation --+- Reporter: martinl | Owner: grass-dev@… Type: task | Status: new Priority: blocker | Milestone: 7.0.0 Component: Default | Version: unspecified Keywords: standardized options |Platform: Unspecified Cpu: Unspecified | --+- Comment(by martinl): For those who would like to help with our effort, please check attachment:module_params_overview-2014-12-12.ods and inform us about remaining parameter inconsistencies. Any renaming should be done before we release RC1 (planned for 29/12)/ -- Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:152 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation
--+-
Reporter: martinl | Owner: grass-dev@…
Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: Default | Version: unspecified
Keywords: standardized options |Platform: Unspecified
Cpu: Unspecified |
--+-
Comment(by martinl):
Any objections to rename
{{{
bgcolor
}}}
to
{{{
bg_color
}}}
?
--
Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:153
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation --+- Reporter: martinl | Owner: grass-dev@… Type: task | Status: new Priority: blocker | Milestone: 7.0.0 Component: Default | Version: unspecified Keywords: standardized options |Platform: Unspecified Cpu: Unspecified | --+- Comment(by martinl): Replying to [comment:152 martinl]: For those who would like to help with our effort, please check attachment:module_params_overview-2014-12-12.ods and inform us about remaining parameter sorry the correct file is attachment:module_params_overview-2014-12-22.ods !!! -- Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:154 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2512: r.out.gdal wrongly messes with SetColorInterpretation
#2512: r.out.gdal wrongly messes with SetColorInterpretation
+---
Reporter: rouault | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 6.4.5
Component: Raster | Version: svn-trunk
Keywords: r.out.gdal |Platform: All
Cpu: All |
+---
Comment(by mmetz):
Replying to [ticket:2512 rouault]:
r.out.gdal export_band.c currently contains
{{{
CPLPushErrorHandler(CPLQuietErrorHandler);
GDALSetRasterColorInterpretation(hBand, GPI_RGB);
CPLPopErrorHandler();
}}}
This is a wrong usage of the GDAL API.
GDALSetRasterColorInterpretation() expects an enumerated value from the
GDALColorInterp enumeration, whereas GPI_RGB is a value from the
GDALPaletteInterp enumeration. Consequently, due to the fact that GPI_RGB
= 1 and GCI_GrayIndex=1, the above snippet will effectively force the
color interpreation to be Gray level.
On GeoTIFF this was without effect before GDAL 1.11, since in those
versions, SetColorInterpration() in the GeoTIFF driver has no effect. But
in GDAL 1.11, the SetColorInterpration() in the GeoTIFF driver can modify
the default PHOTOMETRIC TIFF tag. For example, for a 3 band GeoTIFF file,
at creation time, the GeoTIFF driver defaults to PHOTOMETRIC=RGB, but if
later, SetRasterColorInterpretation(GCI_GrayIndex) is called, it will undo
that setting to fallback to PHOTOMETRIC=MINISBLACK.
All in all, I suggest just to remove those 3 lines. The
CPLPushErrorHandler(CPLQuietErrorHandler) / CPLPopErrorHandler()
surrounding is a hint that this call is wrong.
Done in r63682,3 (trunk, relbr70).
--
Ticket URL: http://trac.osgeo.org/grass/ticket/2512#comment:2
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation --+- Reporter: martinl | Owner: grass-dev@… Type: task | Status: new Priority: blocker | Milestone: 7.0.0 Component: Default | Version: unspecified Keywords: standardized options |Platform: Unspecified Cpu: Unspecified | --+- Comment(by martinl): Replying to [comment:147 martinl]: since `G_ELEMENT_3DVIEW` and `G_ELEMENT_REGION3D` are not used in the code I took liberty to remove them in r63639. If no objection I will do backport to relbr70. done in r63684. -- Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:155 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2512: r.out.gdal wrongly messes with SetColorInterpretation
#2512: r.out.gdal wrongly messes with SetColorInterpretation +--- Reporter: rouault | Owner: grass-dev@… Type: defect | Status: new Priority: normal | Milestone: 6.4.5 Component: Raster | Version: svn-trunk Keywords: r.out.gdal |Platform: All Cpu: All | +--- Comment(by neteler): Done in 6.4.svn (relbranch64) in r63688. -- Ticket URL: http://trac.osgeo.org/grass/ticket/2512#comment:3 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation
--+-
Reporter: martinl | Owner: grass-dev@…
Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: Default | Version: unspecified
Keywords: standardized options |Platform: Unspecified
Cpu: Unspecified |
--+-
Comment(by neteler):
Replying to [comment:153 martinl]:
Any objections to rename
{{{
bgcolor
}}}
to
{{{
bg_color
}}}
?
I don't see an advantage in this case. Wouldn't we have to change many
similar cases then, too?
And it would really become back_ground_color (could then be abbreviate as
bg_color) which is way too long.
--
Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:156
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation --+- Reporter: martinl | Owner: grass-dev@… Type: task | Status: new Priority: blocker | Milestone: 7.0.0 Component: Default | Version: unspecified Keywords: standardized options |Platform: Unspecified Cpu: Unspecified | --+- Comment(by hellik): Replying to [comment:154 martinl]: Replying to [comment:152 martinl]: For those who would like to help with our effort, please check attachment:module_params_overview-2014-12-12.ods and inform us about remaining parameter sorry the correct file is attachment:module_params_overview-2014-12-22.ods !!! for a better overview I've added a pivot analysis with options/flags, their description and the count to the sheet. -- Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:157 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation
--+-
Reporter: martinl | Owner: grass-dev@…
Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: Default | Version: unspecified
Keywords: standardized options |Platform: Unspecified
Cpu: Unspecified |
--+-
Comment(by hellik):
Replying to [comment:154 martinl]:
Replying to [comment:152 martinl]:
For those who would like to help with our effort, please check
attachment:module_params_overview-2014-12-12.ods and inform us about
remaining parameter
sorry the correct file is
attachment:module_params_overview-2014-12-22.ods !!!
maybe some candidates?
{{{
stream_rast Name for output raster map with unique stream ids
stream_vect Name for output vector map with unique stream ids
transmissivity_singlewayName of single-way transmissivity raster
map [0.0-1.0]
transmissivitysingleway Name of the single-way atmospheric
transmissivitymap [-]
walk_coeff Coefficients for walking energy formula parameters a,b,c,d
transport_coeff Name of transport capacity coefficient raster map [s]
topidxclass Topographic index class
topidxstats Name of topographic index statistics file
tiledimension The dimensions of the tiles used in the output raster3d
map (XxYxZ or default: 16x16x8)
tilesizeThe maximum tile size in kilo bytes. Default is 32KB.
swatershed Name for output sink-watershed raster map
start_rast Name of starting raster points map
stabSet the flow stabilizing scheme (full or exponential upwinding).
staend The user defined values that indicate start, intermediate and end
status in the indicator output space time raster dataset
sourceproj Source projection
sourcescale Conversion factor from units to meters in source
projection
soilheatfluxName of instantaneous soil heat flux raster map [W/m2]
Name of soil heat flux raster map [W/m2]
soilmoistureName for output root zone soil moisture raster map
slope_tol Slope tolerance that defines a 'flat' surface (degrees)
segmax Maximum length of segment on network
Maximum number of points in a segment
savehistory Text file in which to save history
savesettingsName for output file where to save current settings
rgbmaps Three (R,G,B) 3D raster maps to create RGB values
[redmap,greenmap,bluemap]
Three (r,g,b) raster maps to create RGB values
[redmap,greenmap,bluemap]
productname Name of MODIS product type
pclay Name of soil clay fraction raster map [0.0-1.0]
pcurvature Name for output profile curvature map (or fxx)
Name for output profile curvature raster map
outtopidxstats Name for output topographic index statistics file
nwalkersNumber of walkers
Number of walkers, default is twice the number of
cells
num_partitions Read the input files in this number of chunks
npartitions Number of partitions
ncolumn Node cost column
Node cost column (number)
min_areaMinimum size of area to be imported (square units)
min_sizeMinimum number of pixels in a class
min_slope Minimum slope value (in percent) for which aspect is
computed
mcurvature Name for output mean curvature 3D raster map
Name for output mean curvature map (or fxy)
Name for output mean curvature raster map
loadhistory Text file from which to load history
loadsettingsName of input file to read settings from
localutctimeName of time of satellite overpass raster map [local time
in UTC]
insol_time Output insolation time raster map [h] (mode 2 only)
infil Name of runoff infiltration rate raster map [mm/hr]
infil_value Runoff infiltration rate unique value [mm/hr]
infile Input file with one input raster map name and data point position
per line, field separator between name and sample point is |
init_time Initial time for current simulation (0) (min)
gcurvature Name for output Gaussian curvature 3D raster map
beam_radOutput beam irradiance [W.m-2] (mode 1) or irradiation
raster map [Wh.m-2.day-1] (mode 2)
afcolumnArc forward/both direction(s) cost column (number)
acolumn Arcs' cost column (for both directions)
abcolumnArc backward direction cost column (number)
EXPERIMENTAL: Arc backward direction cost column
(number)
}}}
--
Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:158
GRASS GIS http://grass.osgeo.org
Re: [GRASS-dev] [GRASS GIS] #2409: last call for options keys consolidation
#2409: last call for options keys consolidation
--+-
Reporter: martinl | Owner: grass-dev@…
Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: Default | Version: unspecified
Keywords: standardized options |Platform: Unspecified
Cpu: Unspecified |
--+-
Comment(by wenzeslaus):
It seems to me in case of `d.shade` (and perhaps few other modules) the
options have unnecessary map in the name. It might be enough just to
leave out the map unless it is there to distinguish from other option.
`d.shade` can change from
{{{
d.shade drapemap=elevation reliefmap=slope
}}}
to
{{{
d.shade drape=elevation relief=slope
}}}
It seems to me that the map in the name does not add much information
(that it is clear that input is some map or raster).
However, in case of `d.shade`, I'm actually suggesting:
{{{
d.shade color=elevation shade=slope
}}}
which more describes the meaning of the input rasters for me.
--
Ticket URL: http://trac.osgeo.org/grass/ticket/2409#comment:159
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] [GRASS GIS] #2513: v.colors freezes using the pg driver and attr
#2513: v.colors freezes using the pg driver and attr -+-- Reporter: jamesp670| Owner: grass-dev@… Type: defect | Status: new Priority: normal | Milestone: 7.0.0 Component: Database | Version: svn-trunk Keywords: freeze in G_fatal_error |Platform: Linux Cpu: x86-64 | -+-- Hi Grass Devs, You've got a big fan in me. I acknowledged GRASS on my AGU (see agu.org) poster this year and I'll make sure it's a cite next year. I have a bug report. This is getting complex and perhaps you can help? The setup: My uname output: : GRASS 7.0.0svn (rlis-master-for-seven):~ uname -a : Linux login.cluster 2.6.32-431.17.1.el6.x86_64 #1 SMP Wed May 7 23:32:49 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux I built grass from source, using primarily deps supplied by : yum install http://yum.postgresql.org/9.3/redhat/rhel-6-x86_64/\ : pgdg-redhat93-9.3-1.noarch.rpm The build is painless. GRASS works great, except for this bug. I run GRASS v.colors to obtain a color map for TIGER census, as in: : GRASS 7.0.0svn (rlis-master-for-seven):~ v.colors --verbose map=tract2010censusdp1_clipped_02 column=popden10 layer=1 rgb_column=GRASSRGB color=grey What I expect: GRASSRGB column is created and populated with greyscale values. What happens instead, is that v.colors freezes. Specifically, I see this sequence: : GRASS 7.0.0svn (rlis-master-for-seven):~ v.colors --verbose map=tract2010censusdp1_clipped_02 column=popden10 layer=1 rgb_column=GRASSRGB color=grey : Option column given, assuming use=attr... : Converting color rules into categories... : Writing color rules... : DBMI-PostgreSQL driver error: : Unable to execute: : ALTER TABLE tract2010censusdp1_clipped_02 ADD COLUMN GRASSRGB VARCHAR(11) : ERROR: column grassrgb of relation tract2010censusdp1_clipped_02 already exists : : : DBMI-PostgreSQL driver error: : Unable to execute: : ALTER TABLE tract2010censusdp1_clipped_02 ADD COLUMN GRASSRGB VARCHAR(11) : ERROR: column grassrgb of relation tract2010censusdp1_clipped_02 already exists : : : ERROR: Unable to add column GRASSRGB to table :tract2010censusdp1_clipped_02 : no database is open : no database is open : C-c C-c : GRASS 7.0.0svn (rlis-master-for-seven):~ Where the C-c C-c is, I am tapping C-c to break the task, which is blatently frozen. I've debugged it. The sequence of events is: : print no database is open : db_shutdown_driver(driver=00661C40) : doing waitpid(pid=1583) : [freeze] During the freeze, proc 1583 is still running, and it's a db/pg process. If I kill 1583, the v.colors job ends immediately with no additional output, as in : no database is open : no database is open : [I kill the db/pg process by hand] : GRASS 7.0.0svn (rlis-master-for-seven):~ I've tried v.colors in the trunk and release SVN branches. The layer is fine, I can query it, view attributes just fine. db.test output looks fine. It's 100% reproducable. I build from source, debug with gdb, insert print statements. That's what got me this far, but now this IPC with the grass-7.0.0svn/driver/db/pg process is getting pretty complex. If I had to hazard a guess, I'd say that closing the communication FILEs in shutdown.c should cause the db/pg process to end. It is not for some reason. That then also begs the question of why the shutdown is called before the colors are written at all. The stack is: : (gdb) where : ,#0 0x003ab72ac8ce in waitpid () from /lib64/libc.so.6 : ,#1 0x2b17f3ad in G_wait (i_pid=28458) at spawn.c:981 : ,#2 0x2ad37348 in db_shutdown_driver (driver=0x661ec0) at shutdown.c:59 : ,#3 0x2ad35e60 in error_handler_driver (p=0x661ec0) at handler.c:24 : ,#4 0x2b1630ad in G__call_error_handlers () at handler.c:108 : ,#5 0x2b15ee93 in G_fatal_error ( : msg=0x405368 Unable to add column %s to table %s) at error.c:176 : ,#6 0x004042b1 in write_rgb_values (Map=0x7fffcfb0, layer=1, : column_name=0x654830 GRASSRGB, colors=0x7fffce90) at write_rgb.c:37 : ,#7 0x00402f83 in main (argc=7, argv=0x7fffd988) at main.c:350 If I delete grassrgb by hand, v.colors does return neatly and works great, as in: : psql (9.3.5) : = : = alter table tract2010censusdp1_clipped_02 drop column grassrgb; : ALTER TABLE : = then : GRASS 7.0.0svn (rlis-master-for-seven):~ v.colors --verbose map=tract2010censusdp1_clipped_02 column=popden10 layer=1 rgb_column=GRASSRGB color=grey h: Option column given, assuming use=attr... : Converting color rules into categories... : Writing
