Re: [GRASS-dev] Regarding testing

2018-05-07 Thread Sanjeet
On Fri, May 4, 2018 at 10:23 PM, Anna Petrášová  wrote:
> On Fri, May 4, 2018 at 1:19 PM, Sanjeet  wrote:
>> Also, I was wondering if there is any priority for working with testsuites?
>
> Look at the tests in Python scripting library
> (lib/python/script/testsuite). Test it under Python 3 to see how they
> work, specifically test_utils.py will definitely fail for Python 3,
> there will be changes needed in utils.py and its test to make it work
> (we can discuss those). I am not sure if the other tests work with
> Python 3, so let us know. You should try to add some where you feel
> there is not enough testing coverage. Please keep asking if
> something's unclear.

Hi Anna,

I made some minor changes in 'utils.py' in lib/python/script and
'test_utils.py' in its testsuite.
https://github.com/sanjeetbhatti/FullSupportPython3/blob/master/patch.diff

The Python 3's bytes cannot contain ASCII literal characters,
therefore I can't seem to test it as such, I encoded it first before
checking for an assertion, which I am not sure is a correct way to do
so as we are ensuring that we do not pass any bytes with ASCII literal
characters.
Same thing is in test_start_command_functions.py.
Moreover, I generalized the encode and decode functions by using
string conversion for int and float values.

Please let me know if this is the correct way to go about it.

Thanks
-- 
Sanjeet Bhatti
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-07 Thread Martin Landa
Hi,

2018-05-05 22:35 GMT+02:00 Martin Landa :
>> Please test!

experimental package for Ubuntu Xenial also available in UbuntuGIS
Expr [1]. Will prepare package also for Bionic (18.04LTS). I am
planning drop support for Trusty (OldOld LTS) - build packages only on
request.

Ma

[1] 
https://launchpad.net/~ubuntugis/+archive/ubuntu/ubuntugis-experimental/+packages?field.name_filter=grass_filter=published_filter=

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-07 Thread Michael Barton
Here is the relevant Trac report

https://trac.osgeo.org/grass/ticket/3487  

Michael

_
 
C. Michael Barton
Director, Center for Social Dynamics & Complexity 
Professor of Anthropology, School of Human Evolution & Social Change
Head, Graduate Faculty in Complex Adaptive Systems Science
Arizona State University
 
voice:  480-965-6262 (SHESC), 480-965-8130/727-9746 (CSDC)
fax: 480-965-7671 (SHESC),  480-727-0709 (CSDC)
www: http://www.public.asu.edu/~cmbarton, http://csdc.asu.edu
On 5/4/18, 12:58 PM, "Michael Barton"  wrote:

No. This is the more fixable but less critical pull custom down list 
control. When I get back to my computer I’ll look for the trac report

Michael Barton
School of Human Evolution  Change
Center for Social Dynamics & Complexity
Arizona State University

...Sent from my iPad

> On May 4, 2018, at 11:30 AM, Markus Neteler  wrote:
> 
>> On Mon, Apr 30, 2018 at 9:19 PM, Michael Barton  
wrote:
>> The crash is in both wxPython 3 and 4. There is a bug report with output 
text and a link to a possible lead on what is wrong. You can reproduce this on 
any of the new Mac binaries.
> 
> Is it this report?
> 
https://urldefense.proofpoint.com/v2/url?u=https-3A__trac.osgeo.org_grass_ticket_3471=DwIBaQ=l45AxH-kUV29SRQusp9vYR0n1GycN4_2jInuKy6zbqQ=lk-7X7CEOMDN8GaGVhiDsuO6gEp1wbG6nfT1XEEEtR0=fDYqX08AaRAB7_yOgmL3Y-Nc0tBP-bpjESSjqcD3tgU=x5lF28M1OLNSnYxoq-IJbSxtXAwOSGVKUsZ6P4zvuBw=
> 
> Markus


___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

2018-05-07 Thread Roberta Fagandini
Hi Moritz and Roberto!
Here [0] you can find the schema of the algorithm!

I committed [1] the first results of the procedure. In this case, I used
the image S2A_MSIL1C_20171025T095101_N0206_R079_T33SVB_20171025T134153
(Sicily). I have already tested the procedure using other two or three
images but I want to keep on testing!
If you have any suggestions about the testing phase please let me know! As
I wrote in another mail, I have the intention of trying out the procedure
using several images sensed in different seasons, latitude, etc.

Best wishes
Roberta

[0]
https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW80Z-7br81/view?usp=sharing
[1] https://github.com/RobiFag/GRASS_clouds_and_shadows


2018-05-03 22:06 GMT+02:00 Roberto Marzocchi :

> Nice! The last step of the script you have written in python works as you
> expected.
>
> Now it is important to draw a diagram (or schema ) as a summary for you (you
> have worked a lot in the last few months) and to share it with Moritz and
> Markus.
>
> After that, test, test and test ;-) for validation/calibration of the
> automatic procedure.
>
> R
>
> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini :
>
>>
>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert :
>>
>>> Hi Roberta,
>>>
>>
>> Hi Moritz and Roberto!
>>
>>
>>>
>>> On 25/04/18 18:03, Roberta Fagandini wrote:
>>>


 2018-04-25 16:03 GMT+02:00 Moritz Lennert >:
 Looking at your bash scripts, I think the first thing to do during
 this bonding period is, as you planned yourself, to get familiar
 with the writing of GRASS modules in Python. You can have a look at
 existing scripts [1, 2] to get feeling for this works and how to
 structure addon code in order to make it directly installable with
 g.extension.

 You can find the actual function definitions and documentation of
 the GRASS Python scripting library at [3]. The functions in that
 library should be more than enough to translate your scripts into a
 (or several) modules.

 Be aware that GRASS modules create their own GUI. So, unless you
 need some interactive features in your modules, you will not have to
 program your own GUI.


 Thank you for your precious suggestions! I'll start studying how to
 write a GRASS module in Python in the next days and at the same time I will
 keep on testing the procedures so as to show you some results and fix some
 open points.


 Something else you should probably do during this bonding time is to
 elaborate a schema of your algorithm, so that it is easier to
 understand what it does at each step.


 Yes, this could be very useful also for me in order to better organize
 and put in order everything!


>>> Have you advanced on any of this ? Do you have any questions ? Please
>>> don't hesitate to ask on the mailing list.
>>>
>>
>> Yes, I started working with GRASS Python scripting library. I'm following
>> the link [0] you suggested, I'm also looking at other existing GRASS
>> scripts [1,2] and moreover, Roberto gave me one of his scripts as an
>> example. I have just committed the first version of the python script I'm
>> working on, it works and I'm quite satisfied ;-)
>> Tomorrow I want to elaborate the schema of the algorithm and at the same
>> time, I have to keep testing the procedure. As I wrote in the bash file,
>> shadows detection seems to be strongly land cover dependent therefore I
>> think it is necessary to test the procedure using several images sensed in
>> different seasons, latitude, etc.
>>
>> Anyway, I'll commit some results tomorrow so as to show you something
>> more concrete!
>>
>>>
>>> Best wishes,
>>> Moritz
>>>
>>
>> Best regards,
>> Roberta
>>
>> [0] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
>> [1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
>> [2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
>>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-07 Thread Markus Metz
On Fri, May 4, 2018 at 11:14 PM, Markus Neteler  wrote:
>
> On Fri, May 4, 2018 at 10:02 PM, Martin Landa 
wrote:
> > Hi,
> >
> > 2018-04-25 20:26 GMT+02:00 Markus Neteler :
> >> If there are no objections, I'll prepare RC1 in the next few days.
> >
> > since there is no blocker [1] I suggest to go ahead and prepare RC1
ASAP. Martin
> >
> > [1]
https://trac.osgeo.org/grass/query?status=new=assigned=reopened=blocker=critical=7.4.1=7.4.0=type=priority
>
> Delayed with respect to our roadmap I have now tagged GRASS GIS 7.4.1 RC1:
>
> * Source code:
https://grass.osgeo.org/grass74/source/grass-7.4.1RC1.tar.gz
> * SVN Source Code Checkout 7.4.1RC1:
> svn checkout
> https://svn.osgeo.org/grass/grass/tags/release_20180504_grass_7_4_1RC1
> * Draft release notes (please update!):
> https://trac.osgeo.org/grass/wiki/Release/7.4.1-News
>
> Please test!

FYI, I just backported a bugfix for v.out.ogr in r72694, avoiding duplicate
fid's which resulted in an incomplete export in some cases for some output
formats, e.g. GPKG.

Markus M
>
> Markus
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

2018-05-07 Thread Roberta Fagandini
2018-05-06 21:52 GMT+02:00 Veronica Andreo :

> Hey Robi,
>

Hi Vero!!


>
> I just found this review [0]. It is for Landsat, but maybe some insights
> could be also useful for you (?)
>

Thank you so much! I know this paper and it could be very useful especially
for the second part of the procedure.
I'll read it carefully!


>
> Cheers :),
> Vero
>

Thanks!
Robi


>
> [0] https://www.researchgate.net/publication/324975294_Cloud_
> and_Cloud_Shadow_Detection_for_Landsat_Images_The_Fundamental_Basis_for_
> Analyzing_Landsat_Time_Series
>
> El jue., 3 may. 2018 a las 22:06, Roberto Marzocchi (<
> roberto.marzoc...@gmail.com>) escribió:
>
>> Nice! The last step of the script you have written in python works as you
>> expected.
>>
>> Now it is important to draw a diagram (or schema ) as a summary for you (you
>> have worked a lot in the last few months) and to share it with Moritz
>> and Markus.
>>
>> After that, test, test and test ;-) for validation/calibration of the
>> automatic procedure.
>>
>> R
>>
>> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini :
>>
>>>
>>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert 
>>> :
>>>
 Hi Roberta,

>>>
>>> Hi Moritz and Roberto!
>>>
>>>

 On 25/04/18 18:03, Roberta Fagandini wrote:

>
>
> 2018-04-25 16:03 GMT+02:00 Moritz Lennert <
> mlenn...@club.worldonline.be >:
> Looking at your bash scripts, I think the first thing to do during
> this bonding period is, as you planned yourself, to get familiar
> with the writing of GRASS modules in Python. You can have a look at
> existing scripts [1, 2] to get feeling for this works and how to
> structure addon code in order to make it directly installable with
> g.extension.
>
> You can find the actual function definitions and documentation of
> the GRASS Python scripting library at [3]. The functions in that
> library should be more than enough to translate your scripts into a
> (or several) modules.
>
> Be aware that GRASS modules create their own GUI. So, unless you
> need some interactive features in your modules, you will not have
> to
> program your own GUI.
>
>
> Thank you for your precious suggestions! I'll start studying how to
> write a GRASS module in Python in the next days and at the same time I 
> will
> keep on testing the procedures so as to show you some results and fix some
> open points.
>
>
> Something else you should probably do during this bonding time is
> to
> elaborate a schema of your algorithm, so that it is easier to
> understand what it does at each step.
>
>
> Yes, this could be very useful also for me in order to better organize
> and put in order everything!
>
>
 Have you advanced on any of this ? Do you have any questions ? Please
 don't hesitate to ask on the mailing list.

>>>
>>> Yes, I started working with GRASS Python scripting library. I'm
>>> following the link [0] you suggested, I'm also looking at other existing
>>> GRASS scripts [1,2] and moreover, Roberto gave me one of his scripts as an
>>> example. I have just committed the first version of the python script I'm
>>> working on, it works and I'm quite satisfied ;-)
>>> Tomorrow I want to elaborate the schema of the algorithm and at the same
>>> time, I have to keep testing the procedure. As I wrote in the bash file,
>>> shadows detection seems to be strongly land cover dependent therefore I
>>> think it is necessary to test the procedure using several images sensed in
>>> different seasons, latitude, etc.
>>>
>>> Anyway, I'll commit some results tomorrow so as to show you something
>>> more concrete!
>>>

 Best wishes,
 Moritz

>>>
>>> Best regards,
>>> Roberta
>>>
>>> [0] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
>>> [1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
>>> [2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
>>>
>>
>> ___
>> grass-dev mailing list
>> grass-dev@lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3558: wx.metadata: several issues in syntax

2018-05-07 Thread GRASS GIS
#3558: wx.metadata: several issues in syntax
-+
  Reporter:  sbl |  Owner:  grass-dev@…
  Type:  defect  | Status:  new
  Priority:  normal  |  Milestone:
 Component:  Addons  |Version:  7.4.0
Resolution:  |   Keywords:  wx.metadata, g.gui.metadata,r.iso.info
   CPU:  All |   Platform:  All
-+
Changes (by sbl):

 * Attachment "g_gui_metadata_py.diff" added.

 Adjust parts of the syntax to wxpython 3 requirements

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3558: wx.metadata: several issues in syntax

2018-05-07 Thread GRASS GIS
#3558: wx.metadata: several issues in syntax
-+
  Reporter:  sbl |  Owner:  grass-dev@…
  Type:  defect  | Status:  new
  Priority:  normal  |  Milestone:
 Component:  Addons  |Version:  7.4.0
Resolution:  |   Keywords:  wx.metadata, g.gui.metadata,r.iso.info
   CPU:  All |   Platform:  All
-+
Changes (by sbl):

 * Attachment "mdgrass_py.diff" added.

 g7.4 findfile syntax, correct mdutils module call

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] [GRASS GIS] #3558: wx.metadata: several issues in syntax

2018-05-07 Thread GRASS GIS
#3558: wx.metadata: several issues in syntax
-+-
 Reporter:  sbl  |  Owner:  grass-dev@…
 Type:  defect   | Status:  new
 Priority:  normal   |  Milestone:
Component:  Addons   |Version:  7.4.0
 Keywords:  wx.metadata, |CPU:  All
  g.gui.metadata,r.iso.info  |
 Platform:  All  |
-+-
 wx.metadata has a couple of issues mostly due to changes in underlying
 libraries, I guess. The attached diffs fix some of them, but remaining
 issues amongst others require wxGUI programming skills, which I do not
 have unfortunately.

 After changes applied editing metadata still throws:


 {{{
 Traceback (most recent call last):
   File "/home/stefan/.grass7/addons/scri
 pts/g.gui.metadata", line 506, in onEdit
 ok = self.editMapMetadata()
   File "/home/NINA.NO/stefan.blumentrath/.grass7/addons/scri
 pts/g.gui.metadata", line 822, in editMapMetadata
 if self.chckProfileSelection('spatial'):
   File "/home/NINA.NO/stefan.blumentrath/.grass7/addons/scri
 pts/g.gui.metadata", line 790, in chckProfileSelection
 text = self.MdDataCatalogPanelLeft.GetItemText(parent)
   File "/usr/lib/python2.7/dist-
 packages/wx-3.0-gtk2/wx/_controls.py", line 5255, in
 GetItemText
 return _controls_.TreeCtrl_GetItemText(*args, **kwargs)
 TypeError: in method 'TreeCtrl_GetItemText', expected
 argument 2 of type 'wxTreeItemId const &'
 }}}


 r.info.iso gives the following warning message:

 {{{
 /usr/lib/python2.7/dist-packages/owslib/iso.py:111:
 FutureWarning: the .identification and
 .serviceidentification properties will merge into
 .identification being a list of properties.  This is
 currently implemented in .identificationinfo.  Please see
 https://github.com/geopython/OWSLib/issues/38 for more
 information
   FutureWarning)
 /usr/lib/python2.7/dist-packages/owslib/iso.py:451:
 FutureWarning: The .keywords and .keywords2 properties will
 merge into the .keywords property in the future, with
 .keywords becoming a list of MD_Keywords instances. This is
 currently implemented in .keywords2. Please see
 https://github.com/geopython/OWSLib/issues/301 for more
 information
   FutureWarning)
 {'status': 'succeded', 'errors': [], 'num_of_errors': '0'}

 }}}

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev