Re: [GRASS-dev] [GRASS GIS] #3861: winGRASS master (git) - g.proj not found at startup

[GRASS GIS]

#3861: winGRASS master (git) - g.proj not found at startup
--+
  Reporter:  hellik   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.8.0
 Component:  Startup  |Version:  svn-trunk
Resolution:   |   Keywords:  python3, py3, wingrass
   CPU:  x86-64   |   Platform:  MSWindows
--+

Comment (by hcho):

 https://github.com/OSGeo/grass/pull/48 This PR should fix it.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] Merging PRs

[Helmut Kudrnovsky]

>Any opinions on merging PRs related to MS Windows builds to .>master without
testing by another person?

more description why the changes and more testing before merging is welcome. 

it seems there is some windows dll hell issue at the moment which should be
solved before the PRs can be tested. further some of the related winGRASS
tickets are labelled als fixes, thus more description  why again changes are
welcome. 






-
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] PROJ.6 (+ spatialite)

[Helmut Kudrnovsky]

Hi,

under

https://www.gaia-gis.it/fossil/libspatialite/wiki?name=PROJ.6

there is a nice overview of the new proj library functionality. maybe useful
for further adopting in GRASS GIS. 



-
best regards
Helmut
--
Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] Merging PRs

[Markus Metz]

On Fri, Jul 12, 2019 at 4:23 PM Huidae Cho  wrote:
>
> Greetings Developers,
>
> In https://trac.osgeo.org/grass/wiki/HowToGit, it is not clear who is
responsible for merging PRs when. Are individual core developers encouraged
(allowed?) or discouraged to merge them? I'm talking about core, not
addons. How does it work?
>
> The main reason why I ask this question is because merging PRs into the
upstream master takes time and I cannot wait until that happens (who,
when?) to compile all my PRs into one build.
>
> If you create multiple branches off of master and create PRs, it wouldn't
be easy to keep track of all those individual branches in one place and
compile the personal "latest" version until the PRs get merged. For example,
>
> 1. master => feature1
> 2. master => feature2
>
> Compiling feature1 and feature2 branches would only give me feature1 and
feature2, respectively, but not both. Should I do something like this?
>
> 1. master => feature1
> 2. feature1 => feature2
>
> Then, how can we make sure that there won't be any conflicts between my
feature2 (<= feature1) branch and the OSGeo master?
>
> Not sure if what I'm doing is "right," but I'm doing this:
>
> 1. create a personal master branch "hcho" (yes, my name)
> 2. master => feature1
> 3. master => feature2
> 4. merge feature1 and feature2 into "hcho"
> 5. compile "hcho"
>
> To be honest, it's a lot of work :-(. Any suggestions or hints would be
very welcome.

Yes, I agree, this is a lot of work. git is convenient for contributors,
but a lot of work (much more than with svn) for maintainers.

If your PRs are incremental, i.e PR for feature 2 requires PR for feature
1, it would be easier to have only one PR with several commits.

I tend to merge your PRs related to MS Windows builds, but I can not test.
OTOH, testing by others occurs more likely if the changes are in master,
not in a PR.

Any opinions on merging PRs related to MS Windows builds to master without
testing by another person?

Markus M
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GitHub: how to fwd pull requests to this list?

[Maris Nartiss]

The biggest question is – do we need PR notifications here. I would
vote for no. Better let's keep discussions in one place.

And no, PRs don't get lost. They all are on GitHub. If a PR was lost,
that is a bug in GitHub and needs to be addressed ASAP.

When we moved to the new workflow, those with rights to merge PRs
(implicitly) agreed to go over PR list on a (semi)regular basis and
merge them if they are good.

Have a nice day,
Māris.

piektd., 2019. g. 12. jūl., plkst. 17:10 — lietotājs Huidae Cho
() rakstīja:
>
> Markus,
>
> I don't think that list has PR notifications. That's only for actual merges, 
> not everything, if I'm not wrong.
>
> Best,
> Huidae
>
>
> On Fri, Jul 12, 2019 at 9:58 AM Markus Neteler  wrote:
>>
>> Hi,
>>
>> On Fri, Jul 12, 2019 at 6:12 AM Huidae Cho  wrote:
>> >
>> > Markus,
>> >
>> > I think I have a workaround. In the worst case scenario, if GitHub doesn't 
>> > support notification forwarding, we could create a dummy GitHub account 
>> > just for notifications and set its email address to 
>> > grass-dev@lists.osgeo.org.
>>
>> Well, we do have this list:
>>
>> https://lists.osgeo.org/pipermail/grass-commit/
>>
>> which contains everything from GitHub (I had set it up like this).
>>
>> But I would like to see _only_ the PRs also here and not clutter this
>> list with the other GH emails.
>> Not sure how to do that...
>>
>> Best
>> Markus
>
>
>
> --
> Huidae Cho, Ph.D., GISP, PE (MD), CFM, M.ASCE
> Open Source GIS Developer, GRASS GIS Development Team
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] Merging PRs

[Huidae Cho]

Greetings Developers,

In https://trac.osgeo.org/grass/wiki/HowToGit, it is not clear who is
responsible for merging PRs when. Are individual core developers encouraged
(allowed?) or discouraged to merge them? I'm talking about core, not
addons. How does it work?

The main reason why I ask this question is because merging PRs into the
upstream master takes time and I cannot wait until that happens (who,
when?) to compile all my PRs into one build.

If you create multiple branches off of master and create PRs, it wouldn't
be easy to keep track of all those individual branches in one place and
compile the personal "latest" version until the PRs get merged. For example,

1. master => feature1
2. master => feature2

Compiling feature1 and feature2 branches would only give me feature1 and
feature2, respectively, but not both. Should I do something like this?

1. master => feature1
2. feature1 => feature2

Then, how can we make sure that there won't be any conflicts between my
feature2 (<= feature1) branch and the OSGeo master?

Not sure if what I'm doing is "right," but I'm doing this:

1. create a personal master branch "hcho" (yes, my name)
2. master => feature1
3. master => feature2
4. merge feature1 and feature2 into "hcho"
5. compile "hcho"

To be honest, it's a lot of work :-(. Any suggestions or hints would be
very welcome.

Best Regards,
Huidae
-- 
Huidae Cho, Ph.D., GISP, PE (MD), CFM, M.ASCE
Open Source GIS Developer, GRASS GIS Development Team
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GitHub: how to fwd pull requests to this list?

[Huidae Cho]

Markus,

I don't think that list has PR notifications. That's only for actual
merges, not everything, if I'm not wrong.

Best,
Huidae


On Fri, Jul 12, 2019 at 9:58 AM Markus Neteler  wrote:

> Hi,
>
> On Fri, Jul 12, 2019 at 6:12 AM Huidae Cho  wrote:
> >
> > Markus,
> >
> > I think I have a workaround. In the worst case scenario, if GitHub
> doesn't support notification forwarding, we could create a dummy GitHub
> account just for notifications and set its email address to
> grass-dev@lists.osgeo.org.
>
> Well, we do have this list:
>
> https://lists.osgeo.org/pipermail/grass-commit/
>
> which contains everything from GitHub (I had set it up like this).
>
> But I would like to see _only_ the PRs also here and not clutter this
> list with the other GH emails.
> Not sure how to do that...
>
> Best
> Markus
>


-- 
Huidae Cho, Ph.D., GISP, PE (MD), CFM, M.ASCE
Open Source GIS Developer, GRASS GIS Development Team
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GitHub: how to fwd pull requests to this list?

[Markus Neteler]

Hi,

On Fri, Jul 12, 2019 at 6:12 AM Huidae Cho  wrote:
>
> Markus,
>
> I think I have a workaround. In the worst case scenario, if GitHub doesn't 
> support notification forwarding, we could create a dummy GitHub account just 
> for notifications and set its email address to grass-dev@lists.osgeo.org.

Well, we do have this list:

https://lists.osgeo.org/pipermail/grass-commit/

which contains everything from GitHub (I had set it up like this).

But I would like to see _only_ the PRs also here and not clutter this
list with the other GH emails.
Not sure how to do that...

Best
Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] Fwd: [OSGeo/grass-addons] r.in.pdal: docker support added (#16)

[Markus Neteler]

Since PRs don't arrive yet here, a manual fwd.

FYI

-- Forwarded message -
From: AnikaBettge 
Date: Wed, Jul 10, 2019 at 4:27 PM
Subject: [OSGeo/grass-addons] r.in.pdal: docker support added (#16)
To: OSGeo/grass-addons 
Cc: Subscribed 


--
You can view, comment on, or merge this pull request online at:

  https://github.com/OSGeo/grass-addons/pull/16
Commit Summary

   - r.in.pdal: docker support added

File Changes

   - *M* grass7/raster/r.in.pdal/r.in.pdal.html
    (35)
   - *M* grass7/raster/r.in.pdal/r.in.pdal.py
    (98)

Patch Links:

   - https://github.com/OSGeo/grass-addons/pull/16.patch
   - https://github.com/OSGeo/grass-addons/pull/16.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
,
or mute the thread

.
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev