Re: [GRASS-dev] i.sentinel improvements

[Roberta Fagandini]

Il giorno mar 12 feb 2019 alle ore 11:35 Luca Delucchi 
ha scritto:

> On Mon, 17 Dec 2018 at 10:38, Luca Delucchi  wrote:
> >
> > Hi all,
> >
>
> Hi devs,
>

Hi Luca,


>
> > - i.sentinel.preproc add capability to compute topographic correction
> > using the following prcedure
> >
>
> done in r74080, please test it
>

Unfortunately I have no time to test it in the next days but I will as soon
as possible.
I took a look at the interface and I saw a new text form for the output
suffix name..if the -c flag is checked, does the module create two
different output (13 atmospherically corrected bands and 13 topographically
corrected bands)?
maybe only one output (i.e. 13 bands to which both corrections are applied)
would be better.


>
> --
> ciao
> Luca
>

ciao
Roberta


>
> www.lucadelu.org
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] i.sentinel improvements

[Roberta Fagandini]

Hi Luca,

Il giorno lun 17 dic 2018 alle ore 10:39 Luca Delucchi 
ha scritto:

> Hi all,
>
> I would like to do some improvements in i.sentinel
> Since I'm not the main author I would like to get approval before to
> start to work on it.
> - i.sentinel.download add capability to filter out scenes with small
> percent (user could decide the percentage to keep) of area matching
> the area of interest
> - i.sentinel.import add capability to cut the scene on the footprint
> to simplify scenes patch
> - i.sentinel.preproc add capability to compute topographic correction
> using the following prcedure
>

Of course, it's ok for me!


>
> ###
> eval `r.sunmask -sg ele=DTM year=${dat:0:4} month=$(echo $dat:4:2 |
> sed 's/^0*//') day=${dat:6:2} hour=${dat:9:2} minute=${dat:11:2}
> second=${dat:13:2} timezone=0`
> z=`echo "90 - $sunangleabovehorizon" | bc -l`
> echo "${inpmap} $z $sunazimuth"
> i.topo.corr -i basemap=DTM zenit=$z azimuth=$sunazimuth output=dtm_illu
>
> for m in `g.list type=raster pattern=${inpmap}*_cor`; do g.region
> raster=$m; r.mapcalc expr="${m}_d=double(${m})"; done
>
> i.topo.corr basemap=dtm_illu input=`g.list type=raster sep=comma
> pattern=${inpmap}*_cor_d` output=tcor zenith=$z method=c-factor
>
> g.remove -f type=raster pattern=${inpmap}*_cor_d
> ###
>

I don't have much experience with topographic correction but I'm not sure
that c-factor is the best. When I tested it, I got anomalous results.

However, I would add the topographic correction as an option (e.g -flag
"also perform  topo cor")


>
> Yeah, that would be an option... What about keeping i.sentinel.import for
> the import part and make i.sentinel.preproc only about pre-processing,
> i.e., atcorr and topcorr?
>

+1.

Robi
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] i.sentinal addons

[Roberta Fagandini]

Hi,

Il giorno sab 25 ago 2018 alle ore 10:53 Luca Delucchi 
ha scritto:

> On Tue, 21 Aug 2018 at 14:36, Roberta Fagandini 
> wrote:
> >
> > Hi all,
>
> Hi,
>
> > obviously, it's ok for me but is it possible to wait for the
> announcement of GSoc results?
>
> announcement is done, right?
>
> > I added the links to the SVN repository to my final report and I'd like
> them to work for a few more days.
> >
>
> could we move them?
>

Yes, thanks!

Roberta


>
> > Thanks!
> >
> > Roberta
> >
>
> --
> ciao
> Luca
>
> www.lucadelu.org
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 final report week 13 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Helmut,

2018-08-21 19:52 GMT+02:00 Roberta Fagandini :

> Hi Helmut,
>
> 2018-08-21 18:46 GMT+02:00 Helmut Kudrnovsky :
>
>> Hi Roberta,
>>
>> >The title of the project is "GRASS GIS module for Sentinel-2 cloud >and
>> shadow detection". It adds new tools for the processing of >Sentinel 2
>> images to GRASS GIS software (Organization: OSGeo).
>>
>> Thanks for the nice addon!
>>
>
> Thank you, I hope it will be useful for the GRASS community!
>
>
>>
>> Does your addon also  work with already atmospheric corrected sentinel
>> data
>> by other software, or is the step with i.sentinel.preproc  needed?
>>
>
> Sure, it works with bands corrected with other software. For instance
> before developing i.sentinel.preproc I used arcsi to correct bands (I also
> tested i.sentinel.mask with bands corrected using Qgis).
> It also works with Sentinel images of the L2A level. If I remember
> correctly Stefan told me to have tested i.sentinel.mask with L2A images
> obtaining good results.
>
>
>>
>> Is there maybe a workflow with such data documented in the wiki?
>>
>
> you can find more information and a general workflow about the module and
> the developed algorithm in the manual page [0]. Hope this helps!!
>
> [https://grass.osgeo.org/grass74/manuals/addons/i.sentinel.mask.html]
>

sorry, I thought you were referring to my GSoC wiki page but maybe I
understood what you meant for 'wiki' [0]. I will add the documentation
about i.sentinel.mask and i.sentinel.preproc in the next days.

Kind regards,

Roberta

[0] https://grasswiki.osgeo.org/wiki/SENTINEL


>
> kind regards
>
> Roberta
>
>
>>
>>
>>
>> -
>> best regards
>> Helmut
>> --
>> Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
>> ___
>> grass-dev mailing list
>> grass-dev@lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 final report week 13 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Helmut,

2018-08-21 18:46 GMT+02:00 Helmut Kudrnovsky :

> Hi Roberta,
>
> >The title of the project is "GRASS GIS module for Sentinel-2 cloud >and
> shadow detection". It adds new tools for the processing of >Sentinel 2
> images to GRASS GIS software (Organization: OSGeo).
>
> Thanks for the nice addon!
>

Thank you, I hope it will be useful for the GRASS community!


>
> Does your addon also  work with already atmospheric corrected sentinel data
> by other software, or is the step with i.sentinel.preproc  needed?
>

Sure, it works with bands corrected with other software. For instance
before developing i.sentinel.preproc I used arcsi to correct bands (I also
tested i.sentinel.mask with bands corrected using Qgis).
It also works with Sentinel images of the L2A level. If I remember
correctly Stefan told me to have tested i.sentinel.mask with L2A images
obtaining good results.


>
> Is there maybe a workflow with such data documented in the wiki?
>

you can find more information and a general workflow about the module and
the developed algorithm in the manual page [0]. Hope this helps!!

[https://grass.osgeo.org/grass74/manuals/addons/i.sentinel.mask.html]

kind regards

Roberta


>
>
>
> -
> best regards
> Helmut
> --
> Sent from: http://osgeo-org.1560.x6.nabble.com/Grass-Dev-f3991897.html
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] i.sentinal addons

[Roberta Fagandini]

Hi all,
obviously, it's ok for me but is it possible to wait for the announcement
of GSoc results?
I added the links to the SVN repository to my final report and I'd like
them to work for a few more days.

Thanks!

Roberta
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 final report week 13 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Thank you Moritz for your support!!

Roberta

2018-08-13 12:06 GMT+02:00 Moritz Lennert :

> Great work, Roberta !
>
> Thanks for these two very useful modules !
>
>
> Moritz
>
> On 13/08/18 10:20, Roberta Fagandini wrote:
>
>> Hi all!
>> I'm Roberta Fagandini and this is the final report of my GSoC project.
>>
>> The title of the project is "GRASS GIS module for Sentinel-2 cloud and
>> shadow detection". It adds new tools for the processing of Sentinel 2
>> images to GRASS GIS software (Organization: OSGeo).
>>
>> *Abstract:*
>> Optical sensors are unable to penetrate clouds leading to related
>> anomalous reflectance values. Unlike Landsat images, Sentinel 2 datasets do
>> not include thermal and Quality Assessment bands that simplify the
>> detection of clouds avoiding erroneous classification. At the same time,
>> also clouds shadows on the ground lead to anomalous reflectance values
>> which have to be taken into account during the image processing.
>> The project creates a specific module for GRASS GIS application
>> (i.sentinel.mask) which implements an automatic procedure for clouds and
>> shadows detection for Sentinel 2 images. The procedure is based on an
>> algorithm, developed within my PhD research, which allows to automatically
>> identify clouds and their shadows applying some rules on reflectance values
>> (values thresholds, comparisons between bands, etc.). These have been
>> defined starting from rules found in literature and conveniently refined.
>> In order to increase the accuracy of the final results, a control check is
>> implemented. Clouds and shadows are spatially intersected in order to
>> remove misclassified areas. The final outputs are two different vector maps
>> (OGR standard formats), one for clouds and one for shadows.
>> To run i.sentinel.mask, the bands of the desired Sentinel 2 images have
>> to be imported and the atmospheric correction has to be applied.
>> In order to make the data preparation easier, another GRASS
>> GISaddonmodule has been developed within the GSoC project.
>> i.sentinel.preprocis a module for the preprocessing of Sentinel 2 images
>> (Level-1C Single Tile product) which wraps the import and the atmospheric
>> correction using respectively two existing GRASS GIS modules,
>> i.sentinel.import and i.atcorr.
>>
>> *The state of the art before the project:*
>> Before this GSoC 2018 project, no modules for the detection of clouds and
>> shadows were available for Sentinel 2 images. Only a specific module for
>> Landsat automatic cloud coverage assessment was available within GRASS GIS
>> (i.landsat.acca) while regarding shadows, no specific module was available.
>> Moreover, performing the atmospheric correction was a bit complicated
>> especially for unexperiencedusers who have to process one band at a time
>> and provide all input parameters manually.
>>
>> *The added value that the project brought to GRASS GIS:*
>> Now a specific module for clouds and shadows detection,
>> i.sentinel.mask,is available in GRASS GIS.
>> Moreover, i.sentinel.preprocprovides a simplified module which allows
>> importing images and performing the atmospheric correction avoiding users
>> to supply all the required input parameters manually. The module should
>> help users in preparing data to use as input for i.sentinel.mask. In fact,
>> it makes especially the atmospheric correction procedure easier and faster
>> because it allows performing atmospheric correction of all bands of a
>> Sentinel 2 scene with a single process and it retrieves most of the
>> required input parameters from the image itself. Moreover, one of the
>> possible output of i.sentinel.preprocis a text file to be used as input for
>> i.sentinel.mask.
>>
>> *Follow up:*
>> Both i.sentinel.mask and i.sentinel.preprocare complete and working
>> modules which can be easily installed with g.extension from the official
>> GRASS GIS SVN repository.
>> Obviously, they can be improved therefore the next steps could be:
>>
>>   * Implementation of other existing algorithms of clouds and shadows
>> detection (i.sentinel.mask)
>>   * Implementation of a new download procedure avoiding dependencies
>> (i.sentinel.preproc)
>>   * Integration of the Topographic Correction (i.sentinel.preproc)
>>
>> NOTE: Implementation of other existing algorithms of clouds and shadows
>> detection was one of the possible goals of the GSoC project but the
>> codingand debuggingof some parts of the twoaddonsrequired more time than
>> expected.
>>

[GRASS-dev] GSoC 2018 final report week 13 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and this is the final report of my GSoC project.

The title of the project is "GRASS GIS module for Sentinel-2 cloud and
shadow detection". It adds new tools for the processing of Sentinel 2
images to GRASS GIS software (Organization: OSGeo).

*Abstract:*
Optical sensors are unable to penetrate clouds leading to related anomalous
reflectance values. Unlike Landsat images, Sentinel 2 datasets do not
include thermal and Quality Assessment bands that simplify the detection of
clouds avoiding erroneous classification. At the same time, also clouds
shadows on the ground lead to anomalous reflectance values which have to be
taken into account during the image processing.
The project creates a specific module for GRASS GIS application
(i.sentinel.mask) which implements an automatic procedure for clouds and
shadows detection for Sentinel 2 images. The procedure is based on an
algorithm, developed within my PhD research, which allows to automatically
identify clouds and their shadows applying some rules on reflectance values
(values thresholds, comparisons between bands, etc.). These have been
defined starting from rules found in literature and conveniently refined.
In order to increase the accuracy of the final results, a control check is
implemented. Clouds and shadows are spatially intersected in order to
remove misclassified areas. The final outputs are two different vector maps
(OGR standard formats), one for clouds and one for shadows.
To run i.sentinel.mask, the bands of the desired Sentinel 2 images have to
be imported and the atmospheric correction has to be applied.
In order to make the data preparation easier, another GRASS GIS addon module
has been developed within the GSoC project.
i.sentinel.preproc is a module for the preprocessing of Sentinel 2 images
(Level-1C Single Tile product) which wraps the import and the atmospheric
correction using respectively two existing GRASS GIS modules,
i.sentinel.import and i.atcorr.

*The state of the art before the project:*
Before this GSoC 2018 project, no modules for the detection of clouds and
shadows were available for Sentinel 2 images. Only a specific module for
Landsat automatic cloud coverage assessment was available within GRASS GIS
(i.landsat.acca) while regarding shadows, no specific module was available.
Moreover, performing the atmospheric correction was a bit complicated
especially for unexperienced users who have to process one band at a time
and provide all input parameters manually.

*The added value that the project brought to GRASS GIS:*
Now a specific module for clouds and shadows detection, i.sentinel.mask, is
available in GRASS GIS.
Moreover, i.sentinel.preproc provides a simplified module which allows
importing images and performing the atmospheric correction avoiding users
to supply all the required input parameters manually. The module should
help users in preparing data to use as input for i.sentinel.mask. In fact,
it makes especially the atmospheric correction procedure easier and faster
because it allows performing atmospheric correction of all bands of a
Sentinel 2 scene with a single process and it retrieves most of the
required input parameters from the image itself. Moreover, one of the
possible output of i.sentinel.preproc is a text file to be used as input
for i.sentinel.mask.

*Follow up:*
Both i.sentinel.mask and i.sentinel.preproc are complete and working
modules which can be easily installed with g.extension from the official
GRASS GIS SVN repository.
Obviously, they can be improved therefore the next steps could be:

   - Implementation of other existing algorithms of clouds and shadows
   detection (i.sentinel.mask)
   - Implementation of a new download procedure avoiding dependencies
   (i.sentinel.preproc)
   - Integration of the Topographic Correction (i.sentinel.preproc)

NOTE: Implementation of other existing algorithms of clouds and shadows
detection was one of the possible goals of the GSoC project but the coding and
debugging of some parts of the two addons required more time than expected.

*Permanent links:*

*Code developed during the GSoC coding period: *
https://github.com/RobiFag/GRASS_clouds_and_shadows

*Codes on the official GRASS GIS SVN repository:*
https://trac.osgeo.org/grass/browser/grass-addons/grass7/ima
gery/i.sentinel.mask
https://trac.osgeo.org/grass/browser/grass-addons/grass7/ima
gery/i.sentinel.preproc

*Documentation:*
https://grass.osgeo.org/grass74/manuals/addons/i.sentinel.mask.html
https://grass.osgeo.org/grass74/manuals/addons/i.sentinel.preproc.html

*Weekly reports: *
https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection

*Images to showcase the project:*
i.sentinel.mask
https://raw.githubusercontent.com/RobiFag/GRASS_clouds_and_s
hadows/master/images/i_sentinel_mask_GWF.png
https://raw.githubusercontent.com/RobiFag/GRASS_clouds_and_s
hadows/master/images/i_sentinel_mask_CD.png
https://raw.githubusercontent.com/RobiFag/GRASS_cl

Re: [GRASS-dev] new addon i.sentinel.preproc (GSoC 2018)

[Roberta Fagandini]

Thank you Martin!

2018-08-11 20:44 GMT+02:00 Martin Landa :

> Hi,
>
> so 11. 8. 2018 v 11:54 odesílatel Markus Neteler 
> napsal:
> > > I confirm that the addons uploaded after Sat Jul 21 20:45:20 UTC 2018
> can
> > > not be installed on Windows (using g.extension).
> >
> > As per other email from yesterday: the Windows server (operated by
> > Martin) has at time a disk full problem. He'll fix that later today.
>
> service is back. Ma
>
> --
> Martin Landa
> http://geo.fsv.cvut.cz/gwiki/Landa
> http://gismentors.cz/mentors/landa
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] new addon i.sentinel.preproc (GSoC 2018)

[Roberta Fagandini]

Hi all,
I confirm that the addons uploaded after Sat Jul 21 20:45:20 UTC 2018  can
not be installed on Windows (using g.extension).

Roberta


> From : Roberto Marzocchi 
> To : "Markus Neteler", "Martin Landa"<
> landa.mar...@gmail.com>
> Cc : "Helmut Kudrnovsky", "GRASS developers list"<
> grass-dev@lists.osgeo.org>, "Roberta Fagandini"
> Date : gio, 09 ago 2018 09:03:13 +0200
> Subject : Re: [GRASS-dev] new addon i.sentinel.preproc (GSoC 2018)
>
>
> Perhaps we can change the subject of this mail?
> I think this problem may affect the overview and the windows installation
> of new addons (but I can write something incorrect)
>
> R
>
> Il giorno mer 8 ago 2018 alle ore 22:49 Markus Neteler 
> ha scritto:
>
> Hi
>
> Helmut Kudrnovsky  schrieb am Mi., 8. Aug. 2018, 10:12:
>
> >I read here [1] that the addons manual pages are updated daily but
> regarding
> i.sentinel.mask the link refers >to the old version of the manual while
> i.sentinel.preproc still doesn't appear.
>
> last update of this site: Sat Jul 21 20:45:20 UTC 2018
>
> @Martin and/or @Markus: could be the update cronjob re-started manually?
>
>
> AFAIK the overview page is generated on Martin's Windows server, so I
> cannot do much here...
>
> Markus
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] new addon i.sentinel.preproc (GSoC 2018)

[Roberta Fagandini]

Hi all,
I uploaded the new GRASS GIS addon i.sentinel.preproc yesterday [0].
The addon has been developed as part of my GSoC project.

I also made some changes to the code and the manual page of i.sentinel.mask.
I read here [1] that the addons manual pages are updated daily but
regarding i.sentinel.mask the link refers to the old version of the manual
while i.sentinel.preproc still doesn't appear.

All the files are correctly updated to the latest version in the SVN
repository.

I would like to have the links to insert them in the final report of my
GSoC project.

Thanks in advance.

Roberta

[0]
https://trac.osgeo.org/grass/browser/grass-addons/grass7/imagery/i.sentinel.preproc
[1] https://grass.osgeo.org/grass74/manuals/addons
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC 2018 report week 12 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the twelfth week of coding.

1) What did I complete this week?

   - Taking the suggestions of the dev community into account and after a
   long discussion with my mentor, I decided to not implement
   i.sentinel.download in order to avoid dependencies due to the
   implementation of an existing module that users can use separately
   - Added support for the Old format Naming Convention of Sentinel 2
   images in i.sentinel.preproc  [0]
   - Improved the manual page of i.sentinel.preproc [1]
   - Small changes to the code and the GUI of i.sentinel. preproc in order
   to make it more congruent with the manual page of i.atcorr (e.g. change AOT
   in AOD) [2]
   - Improved the manual page of i.sentinel.mask adding a more detailed
   example and other information [3]
   - Started preparing deliverables for the final evaluation (updated the
   readme file of my GitHub repository) [4][5][6]
   - Tested both modules i.sentinel.mask and i.sentinel.preproc in order to
   improve and debug the code (small changes to the codes and the GUIs)

2) What am I going to achieve for next week?

   - Last tests and possible changes
   - Clean up the code of i.sentinel.preproc (PEP8 style guide and GRASS
   Python Scripting Library rules)
   - Final check to both modules, i.sentinel.preproc and i.sentinel.mask
   (codes and manual pages)
   - Preparing deliverables for the final evaluation
   - Check everything (codes, manuals and deliverables ) with my mentor

3) Is there any blocking issue?
No.

Here the links to my GitHub repository [7] and wiki page [8]

Kind regards,
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows/
commit/3bb503d2eb860dede36710ba7fb913de4fad17bf
[1] https://github.com/RobiFag/GRASS_clouds_and_shadows/
commit/b7e69b1bdbaa8e9c91579091febf46718cbaf4ee#diff-15b47cd
1e07802ebc64446c2fce5fef0
[2] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/949100564d79895bd992e62e3d214752e704faf7#diff-84085907e0e00fead4cef44afe6eb4e7
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/949100564d79895bd992e62e3d214752e704faf7#diff-84085907e0e00fead4cef44afe6eb4e7>*
[3] https://github.com/RobiFag/GRASS_clouds_and_shadows/
commit/fe2aa29bc656d436e28579f1086d6c60bce678aa
[4] https://github.com/RobiFag/GRASS_clouds_and_shadows/
commit/fbcaa32d9fa2bbd92e85f16ec6a828aaa575a85b
[5] https://github.com/RobiFag/GRASS_clouds_and_shadows/
commit/9ad83e286594012f58e44de63c9af9c9d8ce2c07
[6] https://github.com/RobiFag/GRASS_clouds_and_shadows/
commit/48f3747888eed2bcbde3ea95c318be3a2ef17d11
[7] https://github.com/RobiFag/GRASS_clouds_and_shadows
[8] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC 2018 report week 11 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the eleventh week of coding.

1) What did I complete this week?

   - Added a control check on input folder to check if it belongs to a L1C
   image [0]
   - Fixed relevant bugs on the -a flag [0]
   - Fixed a bug on the control file writing in case of a visibility map is
   provided [0]
   - Small changes to the code and the GUI
   - Discussed with dev community the implementation of a new download
   procedure in order to avoid too many dependencies and as the community
   suggested I decided to not write a new procedure but to use the existent
   addon i.sentinel.download
   - Wrote the manual page [1]
   - Tested i.sentinel.preproc both with sentinel 2A and 2B scenes (for
   Sentinel 2B it works only with GRASS GIS 7.5)

2) What am I going to achieve for next week?

   - Implement i.sentinel.download
   - Write the manual page for the download procedure
   - Test and fix bugs for both i.sentinel.preproc and i.sentinel.mask
   - Start preparing deliverables for the final evaluation

3) Is there any blocking issue?
No at the moment.

Here the links to my GitHub repository [2] and wiki page [3]

Kind regards,
Roberta

[0] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/1ad8f397b1eb6b2b76cf9d037e50a3dfe1a74c0c
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/1ad8f397b1eb6b2b76cf9d037e50a3dfe1a74c0c>*
[1] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/5758b6c796f8b32c35f35e02a581247ed9ba48a5
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/5758b6c796f8b32c35f35e02a581247ed9ba48a5>*
[2] https://github.com/RobiFag/GRASS_clouds_and_shadows
[3] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 report week 10 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Markus!

2018-07-24 14:43 GMT+02:00 Markus Neteler :

> Hi Roberta,
>
> Roberta Fagandini  schrieb am Di., 24. Juli
> 2018, 11:38:
>
>> Hi Martin,
>> as Moritz suggested, Id like to have your opinion about the
>> implementation of a new procedure for downloading Sentinel images avoiding
>> too many dependencies.
>>
>
> I'm following loosely as I'm on the road at time but I'd like to better
> understand this discussion.
>
>
> I'm working on a module (i.sentinel.preproc [0]) which wraps the import
>> and the atmospheric correction of sentinel images. My intention is to add
>> also the download phase but I'd like to avoid dependencies. That's
>>
> the reason why I'm not using i.sentinel.download at the moment.
>>
>
> This isn't clear to me so far. The only potential dependency would be
>
> g.extension i.sentinel
>
> right? Which uses a pip installable library.
>

i.sentinel.download requires both sentinelsat and pandas (both installable
with pip).
In a previous discussion, I asked about the installation of the python
library Py6S and the dev community strongly encouraged me to avoid too many
dependencies (also Py6S requires pandas). Consequently I wrote my own
routine to read AERONET file and compute AOT at 550nm.
That's the reason why I'm trying to avoid dependencies.


>
> I found this python script [1] that maybe could solve the problem of
>> dependencies and it could be a good starting point.
>>
>
> For me that script doesn't work, tried a few days ago (while
> i.sentinel.download does work).
> What is the advantage of having the dependency [1] over an existing GRASS
> add-on?
>

I have not tested the script yet, but looking at the code I think I can try
to implement part of the code in my module changing it accordingly with the
requirements of a GRASS GIS module. This should avoid the installation of
both sentinelsat and pandas. Right?


>
> What do you think?
>>
>> As always any feedback is welcome!
>>
>
> I'd rather consider to share code with the existing addon than starting
> from scratch.
> But perhaps I'm still overlooking something.
>

Obviously, it would be easier for me to use the existing addon
(i.sentinel.download) but I struggled quite a lot to avoid pandas and other
dependencies ;-). I do not know if it makes sense to add it now in order to
integrate a module that already exists and that users can use separately.
What do you think?


Roberta



>
> My 0.02 holiday cents :)
> Markus
>
>
>> Thanks in advance.
>>
>> Roberta
>>
>> [0] https://github.com/RobiFag/GRASS_clouds_and_shadows
>> [1] https://github.com/olivierhagolle/Sentinel-download
>>
>>
>
>>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 report week 10 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Martin,
as Moritz suggested, Id like to have your opinion about the implementation
of a new procedure for downloading Sentinel images avoiding too many
dependencies.
I'm working on a module (i.sentinel.preproc [0]) which wraps the import and
the atmospheric correction of sentinel images. My intention is to add also
the download phase but I'd like to avoid dependencies. That's the reason
why I'm not using i.sentinel.download at the moment.
I found this python script [1] that maybe could solve the problem of
dependencies and it could be a good starting point.

What do you think?

As always any feedback is welcome!

Thanks in advance.

Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://github.com/olivierhagolle/Sentinel-download

2018-07-23 8:25 GMT+02:00 Moritz Lennert :

> Hi Roberta,
>
> On 22/07/18 11:33, Roberta Fagandini wrote:
>
>> Hi all!
>> I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
>> module for Sentinel-2 cloud and shadow detection.
>> This is my report for the tenth week of coding.
>>
>> 1) What did I complete this week?
>>
>>   * Submitted a new version of i.sentinel.mask to the official GRASS-SVN
>> repository [0][1]
>>   * Integrated the import of Sentinel 2 images into i.sentinel.preproc [2]
>>   * Tested the module and fixed bugs
>>   * Discussed with mentors about next steps and we decided to not
>> implement the download procedure in the new module
>> i.sentinel.preproc in order to avoid unnecessary and undesirable
>> dependency as the dev community suggested
>>   * Studied other possible python libraries for the download of Sentinel
>> images in order to reduce the number of dependencies (e.g.
>> sentinelhub instead of sentinelsat)
>>   * Created a real complete GRASS GIS module that can be installed with
>> g.extension from my GitHub repository [3][4]
>>
>
> Thanks for the great work. Both i.sentinel.mask and i.sentinel.preproc
> will be very useful additions !
>
>
>> Unfortunately, I wasn't able for two days because of an unexpected
>> personal commitment.
>>
>> 2) What am I going to achieve for next week?
>>
>>   * Write the manual page
>>   * Start implementing a new procedure for downloading Sentinel image
>> avoiding too many dependencies
>>
>
> Please consult with Martin Landa on this last point. I would suggest that
> you provide a diff to the current i.sentinel.download instead of writing a
> completely new one.
>
> Moritz
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC 2018 report week 10 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the tenth week of coding.

1) What did I complete this week?

   - Submitted a new version of i.sentinel.mask to the official GRASS-SVN
   repository [0][1]
   - Integrated the import of Sentinel 2 images into i.sentinel.preproc [2]
   - Tested the module and fixed bugs
   - Discussed with mentors about next steps and we decided to not
   implement the download procedure in the new module i.sentinel.preproc in
   order to avoid unnecessary and undesirable dependency as the dev community
   suggested
   - Studied other possible python libraries for the download of Sentinel
   images in order to reduce the number of dependencies (e.g.
   sentinelhub instead of sentinelsat)
   - Created a real complete GRASS GIS module that can be installed with
   g.extension from my GitHub repository [3][4]

Unfortunately, I wasn't able for two days because of an unexpected personal
commitment.

2) What am I going to achieve for next week?

   - Write the manual page
   - Start implementing a new procedure for downloading Sentinel image
   avoiding too many dependencies


3) Is there any blocking issue?
No at the moment.

Here the links to my GitHub repository [5] and wiki page [6]

Kind regards,
Roberta

[0] 
*https://trac.osgeo.org/grass/changeset?reponame==72992%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.html=72816%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.html
<https://trac.osgeo.org/grass/changeset?reponame==72992%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.html=72816%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.html>*
[1] 
*https://trac.osgeo.org/grass/changeset?reponame==72992%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.py=72816%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.py
<https://trac.osgeo.org/grass/changeset?reponame==72992%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.py=72816%40grass-addons%2Fgrass7%2Fimagery%2Fi.sentinel.mask%2Fi.sentinel.mask.py>*
[2] https://github.com/RobiFag/GRASS_clouds_and_shadows/comm
it/e7151f1a73895f8c0acd5692444e4fd79d83b6a2
[3] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/d22a33b8af2848ce9b479deb26cd10bc15a98133
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/d22a33b8af2848ce9b479deb26cd10bc15a98133>*
[4] https://github.com/RobiFag/GRASS_clouds_and_shadows/comm
it/303592e6a73ec8b4d4178519fe507e6027040e3f
[5] https://github.com/RobiFag/GRASS_clouds_and_shadows
[6] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC 2018 report week 09 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the ninth week of coding (second evaluation).

1) What did I complete this week?

   - Finished implementing the GUI [0]
   - Made some changes to the code depending on the GUI requirements (add
   controls and check on input, output, etc.) [0]
   - Tested the module and fixed bugs
   - Discussed with mentors about next steps and we decided to not
   implement the cloud and shadow detection procedure in the new module
   i.sentinel.preproc
   - Added to i.sentinel.preproc a flag option to automatically create the
   text file to be used as input in the module i.sentinel.mask [0]
   - Made small changes to i.sentinel.mask in order to make it compatible
   with the output of i.sentinel.preproc [1]

2) What am I going to achieve for next week?

   - Integrate the download and import of Sentinel 2 images into the new
   GRASS module (i.sentinel.preproc)
   - Start writing the manual page
   - Create a real complete GRASS GIS module that can be installed with
   g.extension from my GitHub repository


3) Is there any blocking issue?
No at the moment even though I'm a little late on the roadmap because also
the implementation of the GUI took slightly more time than expected (made
some changes to the code depending on the GUI requirements).

Here the links to my GitHub repository [2] and wiki page [3]

Kind regards,
Roberta

[0] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/f60952c701e87d21a7010494dec10ec603446a1f
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/f60952c701e87d21a7010494dec10ec603446a1f>*
[1] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/e2b6978651efe063d1beed603ae2bd8341b9264e
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/e2b6978651efe063d1beed603ae2bd8341b9264e>*
[2] https://github.com/RobiFag/GRASS_clouds_and_shadows
[3] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC 2018 report week 08 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the eighth week of coding.

1) What did I complete this week?

   - Finished writing the routine to read AERONET file and compute the
   value of Aerosol Optical Thickness at 550 nm  (one of the parameters of the
   i.atcorr control file) [0]
   - Integrated the routine for AOT computation into the GRASS python
   script to execute i.atcorr for all bands of the input image changing
   accordingly the requested input parameters and control file  [1]
   - Added the automatic and simplified procedure to identify the
   atmospheric model (one of the parameters of the i.atcorr control file) [1]
   - Managed the use of visibility as input parameter instead of AOT value
   [1]
   - Finished defining the automatic procedure for retrieving all the last
   missing parameters for the control file
   - Finished and added to my GitHub repository the complete GRASS python
   script to execute i.atcorr for all bands [1]
   - Started implementing the GUI [2]

2) What am I going to achieve for next week?

   - Finish the implementation of the GUI
   - Integrate the download and import of Sentinel 2 images into the new
   GRASS module (i.sentinel.preproc)
   - Test and fix bugs
   - Make the new module available through my GitHub repository


3) Is there any blocking issue?
No at the moment even though I'm a little late on the roadmap because the
coding of the routine to compute AOT took slightly more time than expected.

Here the links to my GitHub repository [3] and wiki page [4]

Kind regards,
Roberta

[0] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/33d0832a0f8dc4aa0c45d37ba6598988579c0d9a
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/33d0832a0f8dc4aa0c45d37ba6598988579c0d9a>*
[1] 
*https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/1617184154ead85f83ce7f1a8750f00f100dc2cb
<https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/1617184154ead85f83ce7f1a8750f00f100dc2cb>*

[2] https://github.com/RobiFag/GRASS_clouds_and_shadows/comm
it/35175c68a35e01941faead903ec8f0380b317aa6
[3] https://github.com/RobiFag/GRASS_clouds_and_shadows
[4] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 report week 07 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

2018-07-02 10:57 GMT+02:00 Stefan Blumentrath :

> Ciao Roberta,
>

Ciao Stefan,


>
>
> Thanks for all your excellent work and comprehensive documentation and
> information also on dev list.
>

Thank you, I'm glad you appreciate it and I hope it will be useful for you!


>
>
> In the light of the discussion around the Sentinel-2 pre-processing
> wrapper script, I was wondering if you plan / were considering to add a
> multi-temporal approach to cloud detection [1,2,3] to your module?
>

No at the moment, I'm sorry. I have never worked on a multi-temporal
approach for cloud detection, one of the main goals of my PhD research is
indeed the definition of a procedure for the identification of clouds on a
single image.
Maybe it would take too long to integrate a new multi-temporal approach
into the project now.


>
>
> If your GSoC was a "pick and choose event”, I would personally be more
> than satisfied with an “i.atcorr.params” module (or the like) that compiles
> 6s input file (maybe just with simple user input on geometrical conditions,
> aerosol model, …) instead of a wrapper for a full preprocessing chain, if
> that allows you to work on a (at least preliminary) multitemporal could
> detection procedure…
>
>
>
> Maybe you discussed this already with your mentors. So, I have no
> intentions to interfere here, just indicate my personal preferences  …
>

I have already discussed the next steps of the project with my mentors and
we thought of integrating other algorithms for cloud detection (e.g. fmask)
into the module. I'm not able to evaluate if an existant multi-temporal
algorithm can be easily and quickly integrated into the module.
I will certainly read the links you suggested, but in the meantime, if you
have more precise ideas about it, please let me know..maybe it could be
easier than I expect! ;-)

I would like to know what you think, Moritz and Roberto, about the
integration of a multi-temporal approach in the module.


>
> As for AOT estimation, this paper might be of interest?
>
> http://www.mdpi.com/2072-4292/9/12/1230/htm
>
>
>
>
>
> Kind regards,
>
> Stefan
>

Cheers,
Roberta


>
>
> 1: https://www.sciencedirect.com/science/article/pii/S003442571908
>
> 2: http://www.cesbio.ups-tlse.fr/multitemp/?p=6832
>
> 3: https://forum.step.esa.int/t/maccs-maja-now-distributed-as-
> binary-code-for-non-commercial-use/5500
>
>
>
>
>
> *From:* grass-dev  *On Behalf Of *Roberta
> Fagandini
> *Sent:* søndag 1. juli 2018 11:23
> *To:* s...@lists.osgeo.org; GRASS developers list <
> grass-dev@lists.osgeo.org>
> *Subject:* [GRASS-dev] GSoC 2018 report week 07 - GRASS GIS module for
> Sentinel-2 cloud and shadow detection
>
>
>
> Hi all!
>
> I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
> module for Sentinel-2 cloud and shadow detection.
>
> This is my report for the seventh week of coding.
>
>
>
> 1) What did I complete this week?
>
> · Continued coding the GRASS python script to execute i.atcorr for all
> bands of the input image changing accordingly the requested input
> parameters and control file [0]
>
> · Changed some lines of the code according to the i.atcorr manual page
> (e.g. lon/lat retrieved from the computational region and not from metadata
> file) [0]
>
> · Added the automatic computation of mean target elevation from the input
> dem [0]
>
> · Wrote and added the python script for retrieving the aerosol optical
> thickness (AOT) value from AERONET data using Py6S library [1]
>
> · Discussed with dev community about the need to write my own routine to
> retrieve and compute AOT at 550 nm avoiding too many dependencies [2]
>
> · Started writing my own routine to extract and compute AOT at 550 (one
> of the parameters of the i.atcorr control file) [3]
>
> 2) What am I going to achieve for next week?
>
> · Finish writing the routine for AOT computation
>
> · Understand how to automatically retrieve some parameters for the
> control file like aerosol and atmospheric models
>
> · Finish defining the automatic procedure for retrieving all the last
> missing parameters for the control file
>
>
>
> 3) Is there any blocking issue?
>
> No at the moment but the coding of the routine takes more time than
> expected.
>
>
>
> Here the links to my GitHub repository [4] and wiki page [5]
>
>
>
> Kind regards,
>
> Roberta
>
>
>
> [0] https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/
> 52ede2e0e8d157f5b19fbb414c29bbde0e728b13#diff-
> d42beca70d363fcee5a6ec17260c5129
>
> [1] https://github.com/RobiFag/GRASS_clouds_and_shadows/commit/
> a8757bfaae04c283daab1b03216b3e0d7ed4c885
>
&g

Re: [GRASS-dev] compile 6S library in GRASS

[Roberta Fagandini]

Moritz, I don't know why but today I have some trouble with your email, I
receive them after some hours...anyway I read the last from the dev digest.

Regarding AERONET data, it's not possible to completely automate the
procedure (search for the proper file, download, unzip, read and so on..),
I had already verified and the AERONET website does not provide any API or
something that allows connecting from GRASS.
However, I think I can add the interpolation suggested by Markus (thank
you, Markus, for the link) so regarding the AOT value, users can choose to:

   - provide their own value
   - read the "nearest" value (timestamp) from an AERONET file (this part
   of the script is almost ready) and apply the interpolation (using the
   closest available wavelength)

Roberta

2018-06-28 15:26 GMT+02:00 Roberta Fagandini :

>
>
> 2018-06-28 14:46 GMT+02:00 Markus Metz :
>
>>
>>
>> On Thu, Jun 28, 2018 at 12:17 PM, Roberta Fagandini <
>> robifagand...@gmail.com> wrote:
>> >
>> >
>> >
>> > 2018-06-28 10:26 GMT+02:00 Moritz Lennert > >:
>> >>
>> >> On 27/06/18 15:40, Roberto Marzocchi wrote:
>> >>>
>> >>>
>> >>>
>> >>> Il giorno mer 27 giu 2018 alle ore 15:25 Markus Metz <
>> markus.metz.gisw...@gmail.com <mailto:markus.metz.gisw...@gmail.com>> ha
>> scritto:
>> >>>
>> >>>
>> >>>
>> >>> On Wed, Jun 27, 2018 at 3:06 PM, Roberta Fagandini
>> >>> mailto:robifagand...@gmail.com>> wrote:
>> >>>  >
>> >>>  >
>> >>>  >
>> >>>  > 2018-06-27 14:24 GMT+02:00 Markus Metz
>> >>> mailto:markus.metz.giswork@gm
>> ail.com>>:
>> >>>  >>
>> >>>  >>
>> >>>  >>
>> >>>  >> On Wed, Jun 27, 2018 at 2:16 PM, Roberta Fagandini
>> >>> mailto:robifagand...@gmail.com>> wrote:
>> >>>  >> >
>> >>>  >> > I'm trying to create an automatic procedure to retrieve all
>> >>> the input parameters for the control file of i.atcorr.
>> >>>  >> > I need py6S because I want to automatically read and compute
>> >>> AOT at 550nm from an AERONET file.
>> >>>  >>
>> >>>  >> With AOT you mean aerosol optical thickness right? This is
>> user
>> >>> input to i.atcorr. There are various sources for AOT at 550nm,
>> e.g.
>> >>> MODIS.
>> >>>  >
>> >>>  >
>> >>>  > Right!
>> >>>  >
>> >>>  >>
>> >>>  >>
>> >>>  >>
>> >>>  >>
>> >>>  >> Anyway, it is probably much easier to to write your own
>> routine
>> >>> to read the AERONET file and get the corresponding formula for AOT
>> >>> than to fight with 51821 lines of Fortran source code that is
>> >>> numerically unstable. Maybe I can help with getting AOT at 550nm
>> >>> from an AERONET file avoiding the Fortran version of 6S.
>> >>>  >
>> >>>  >
>> >>>  > Ok but I'm not able to create this kind of routine on my own.
>> If
>> >>> someone, more expert than me, can help me in translating the
>> 6S/Py6S
>> >>> functions I can go on in this way otherwise for me it's easier to
>> >>> use the fortran source code.
>> >>>
>> >>> Apparently the AERONET data are simple CSV files. You can import
>> >>> them with r.in.xyz <http://r.in.xyz> or v.in.ascii.
>> >>>
>> >>> Still, I think it is up to the user to decide on the source of AOT
>> >>> values. AERONET is one of many possible sources.
>> >>>
>> >>>
>> >>> Ok but I know that Roberta  want try to simplify the procedure for
>> atmospheric correction. In particular she would like to add an option (not
>> the only one) to read automatically the AOT at the wave length of 550 nm
>> from the AERONET file.
>> >>>
>> >>> The steps to do this IMHO are:
>> >>>
>> >>> 1) read the file (using GRASS or maybe better Python)
>> >>>
>> >>> 2) a formula to calcula

Re: [GRASS-dev] compile 6S library in GRASS

[Roberta Fagandini]

2018-06-28 14:46 GMT+02:00 Markus Metz :

>
>
> On Thu, Jun 28, 2018 at 12:17 PM, Roberta Fagandini <
> robifagand...@gmail.com> wrote:
> >
> >
> >
> > 2018-06-28 10:26 GMT+02:00 Moritz Lennert 
> :
> >>
> >> On 27/06/18 15:40, Roberto Marzocchi wrote:
> >>>
> >>>
> >>>
> >>> Il giorno mer 27 giu 2018 alle ore 15:25 Markus Metz <
> markus.metz.gisw...@gmail.com <mailto:markus.metz.gisw...@gmail.com>> ha
> scritto:
> >>>
> >>>
> >>>
> >>> On Wed, Jun 27, 2018 at 3:06 PM, Roberta Fagandini
> >>> mailto:robifagand...@gmail.com>> wrote:
> >>>  >
> >>>  >
> >>>  >
> >>>  > 2018-06-27 14:24 GMT+02:00 Markus Metz
> >>> mailto:markus.metz.giswork@gm
> ail.com>>:
> >>>  >>
> >>>  >>
> >>>  >>
> >>>  >> On Wed, Jun 27, 2018 at 2:16 PM, Roberta Fagandini
> >>> mailto:robifagand...@gmail.com>> wrote:
> >>>  >> >
> >>>  >> > I'm trying to create an automatic procedure to retrieve all
> >>> the input parameters for the control file of i.atcorr.
> >>>  >> > I need py6S because I want to automatically read and compute
> >>> AOT at 550nm from an AERONET file.
> >>>  >>
> >>>  >> With AOT you mean aerosol optical thickness right? This is user
> >>> input to i.atcorr. There are various sources for AOT at 550nm, e.g.
> >>> MODIS.
> >>>  >
> >>>  >
> >>>  > Right!
> >>>  >
> >>>  >>
> >>>  >>
> >>>  >>
> >>>  >>
> >>>  >> Anyway, it is probably much easier to to write your own routine
> >>> to read the AERONET file and get the corresponding formula for AOT
> >>> than to fight with 51821 lines of Fortran source code that is
> >>> numerically unstable. Maybe I can help with getting AOT at 550nm
> >>> from an AERONET file avoiding the Fortran version of 6S.
> >>>  >
> >>>  >
> >>>  > Ok but I'm not able to create this kind of routine on my own. If
> >>> someone, more expert than me, can help me in translating the
> 6S/Py6S
> >>> functions I can go on in this way otherwise for me it's easier to
> >>> use the fortran source code.
> >>>
> >>> Apparently the AERONET data are simple CSV files. You can import
> >>> them with r.in.xyz <http://r.in.xyz> or v.in.ascii.
> >>>
> >>> Still, I think it is up to the user to decide on the source of AOT
> >>> values. AERONET is one of many possible sources.
> >>>
> >>>
> >>> Ok but I know that Roberta  want try to simplify the procedure for
> atmospheric correction. In particular she would like to add an option (not
> the only one) to read automatically the AOT at the wave length of 550 nm
> from the AERONET file.
> >>>
> >>> The steps to do this IMHO are:
> >>>
> >>> 1) read the file (using GRASS or maybe better Python)
> >>>
> >>> 2) a formula to calculate the AOT550
> >>>
> >>> Unfortunately I have no idea about the 2nd point :-(
> >>
> >>
> >> I'm not sure either, what exactly the necessary calculations are.
> >>
> >> Superficially reading through the relevant class in Py6S [1], I
> understasnd that it does two things:
> >>
> >> 1) Get the value of AOT550
> >> 2) Create a continuous profile by interpolating values
> >>
> >> If all you need is 1), then all they do (see _get_aot() method at the
> end) is to read all the AOT_* columns and chose the value of the line with
> the timestamp closest to the one asked for and the wavelength closest to
> 550.
> >>
> >>
> >> As the code is GPL you could probably just extract the necessary parts
> and integrate them into your code. The only thing I'm not to sure about is
> their use of pandas which creates yet again another dependency which I
> don't really think necessary and desirable.
> >
> >
> > Yesterday I studied the library better and I understood that it only
> extracts the available AOT values closest to the waveleng

Re: [GRASS-dev] compile 6S library in GRASS

[Roberta Fagandini]

2018-06-28 10:26 GMT+02:00 Moritz Lennert :

> On 27/06/18 15:40, Roberto Marzocchi wrote:
>
>>
>>
>> Il giorno mer 27 giu 2018 alle ore 15:25 Markus Metz <
>> markus.metz.gisw...@gmail.com <mailto:markus.metz.gisw...@gmail.com>> ha
>> scritto:
>>
>>
>>
>> On Wed, Jun 27, 2018 at 3:06 PM, Roberta Fagandini
>> mailto:robifagand...@gmail.com>> wrote:
>>  >
>>  >
>>  >
>>  > 2018-06-27 14:24 GMT+02:00 Markus Metz
>> mailto:markus.metz.gisw...@gmail.com
>> >>:
>>  >>
>>  >>
>>  >>
>>  >> On Wed, Jun 27, 2018 at 2:16 PM, Roberta Fagandini
>> mailto:robifagand...@gmail.com>> wrote:
>>  >> >
>>  >> > I'm trying to create an automatic procedure to retrieve all
>> the input parameters for the control file of i.atcorr.
>>  >> > I need py6S because I want to automatically read and compute
>> AOT at 550nm from an AERONET file.
>>  >>
>>  >> With AOT you mean aerosol optical thickness right? This is user
>> input to i.atcorr. There are various sources for AOT at 550nm, e.g.
>> MODIS.
>>  >
>>  >
>>  > Right!
>>  >
>>  >>
>>  >>
>>  >>
>>  >>
>>  >> Anyway, it is probably much easier to to write your own routine
>> to read the AERONET file and get the corresponding formula for AOT
>> than to fight with 51821 lines of Fortran source code that is
>> numerically unstable. Maybe I can help with getting AOT at 550nm
>> from an AERONET file avoiding the Fortran version of 6S.
>>  >
>>  >
>>  > Ok but I'm not able to create this kind of routine on my own. If
>> someone, more expert than me, can help me in translating the 6S/Py6S
>> functions I can go on in this way otherwise for me it's easier to
>> use the fortran source code.
>>
>> Apparently the AERONET data are simple CSV files. You can import
>> them with r.in.xyz <http://r.in.xyz> or v.in.ascii.
>>
>> Still, I think it is up to the user to decide on the source of AOT
>> values. AERONET is one of many possible sources.
>>
>>
>> Ok but I know that Roberta  want try to simplify the procedure for
>> atmospheric correction. In particular she would like to add an option (not
>> the only one) to read automatically the AOT at the wave length of 550 nm
>> from the AERONET file.
>>
>> The steps to do this IMHO are:
>>
>> 1) read the file (using GRASS or maybe better Python)
>>
>> 2) a formula to calculate the AOT550
>>
>> Unfortunately I have no idea about the 2nd point :-(
>>
>
> I'm not sure either, what exactly the necessary calculations are.
>
> Superficially reading through the relevant class in Py6S [1], I
> understasnd that it does two things:
>
> 1) Get the value of AOT550
> 2) Create a continuous profile by interpolating values
>
> If all you need is 1), then all they do (see _get_aot() method at the end)
> is to read all the AOT_* columns and chose the value of the line with the
> timestamp closest to the one asked for and the wavelength closest to 550.


> As the code is GPL you could probably just extract the necessary parts and
> integrate them into your code. The only thing I'm not to sure about is
> their use of pandas which creates yet again another dependency which I
> don't really think necessary and desirable.


Yesterday I studied the library better and I understood that it only
extracts the available AOT values closest to the wavelength 550 for the
specified timestamp. No calculation is made so I'm trying to write my own
routine avoiding any dependency.


>

It should be enough to extract from the file the date and time (or maybe
> easier to work with: year and the Julian day) and all AOT_* columns, parse
> the AOT_* columns for their wavelength value and then identify the value
> which has closes time and wavelength to the time requested and 550nm.
>

That's exactly what I want to do and I'm working on it!


>
> Moritz
>

I know that AERONET is not the only source and obviously in my module there
will be both an option for providing manually the value, as Markus and
Stefan suggested, and an option to extract the AOT from an AERONET file.
I'm not an expert in MODIS data so if someone wants to give suggestions
about how to retrieve the AOT from these data, I will definitely add this
option too.

Thanks
Roberta


>
>
>
>
> [1] https://github.com/robintw/Py6S/blob/master/Py6S/SixSHelpers
> /aeronet.py
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] compile 6S library in GRASS

[Roberta Fagandini]

2018-06-27 14:24 GMT+02:00 Markus Metz :

>
>
> On Wed, Jun 27, 2018 at 2:16 PM, Roberta Fagandini <
> robifagand...@gmail.com> wrote:
> >
> > I'm trying to create an automatic procedure to retrieve all the input
> parameters for the control file of i.atcorr.
> > I need py6S because I want to automatically read and compute AOT at
> 550nm from an AERONET file.
>
> With AOT you mean aerosol optical thickness right? This is user input to
> i.atcorr. There are various sources for AOT at 550nm, e.g. MODIS.
>

Right!


>
>

> Anyway, it is probably much easier to to write your own routine to read
> the AERONET file and get the corresponding formula for AOT than to fight
> with 51821 lines of Fortran source code that is numerically unstable. Maybe
> I can help with getting AOT at 550nm from an AERONET file avoiding the
> Fortran version of 6S.
>

Ok but I'm not able to create this kind of routine on my own. If someone,
more expert than me, can help me in translating the 6S/Py6S functions I can
go on in this way otherwise for me it's easier to use the fortran source
code.
Here [0] a link to my Github repository in which you can find the small
script that I wrote using the Py6S library to compute AOT at 550nm

Roberta

[0]
https://github.com/RobiFag/GRASS_clouds_and_shadows/blob/master/read_aeronet.py


>
> Markus M
>
> >
> > 2018-06-27 14:01 GMT+02:00 Moritz Lennert 
> :
> >>
> >> On 27/06/18 13:54, Roberto Marzocchi wrote:
> >>>
> >>>
> >>> Il giorno mer 27 giu 2018 alle ore 13:47 Markus Metz <
> markus.metz.gisw...@gmail.com <mailto:markus.metz.gisw...@gmail.com>> ha
> scritto:
> >>>
> >>> Hi Roberta,
> >>>
> >>> On Wed, Jun 27, 2018 at 1:20 PM, Roberta Fagandini
> >>> mailto:robifagand...@gmail.com>> wrote:
> >>>  >
> >>>  > Hi all!
> >>>  > I need to compile the 6S library in GRASS in order to install
> the
> >>> python library Py6S [0].
> >>>
> >>> do you really need Py6S? Can't you use i.atcorr instead?
> >>>
> >>>
> >>> She use Py6S to calculate imput for i.atcorr
> >>
> >>
> >> That seems a bit overkill: why use Py6S to then use i.atcorr ? What are
> you trying to get from Py6S ?
> >>
> >> Moritz
> >>
> >
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] compile 6S library in GRASS

[Roberta Fagandini]

I'm trying to create an automatic procedure to retrieve all the input
parameters for the control file of i.atcorr.
I need py6S because I want to automatically read and compute AOT at 550nm
from an AERONET file.

2018-06-27 14:01 GMT+02:00 Moritz Lennert :

> On 27/06/18 13:54, Roberto Marzocchi wrote:
>
>>
>> Il giorno mer 27 giu 2018 alle ore 13:47 Markus Metz <
>> markus.metz.gisw...@gmail.com <mailto:markus.metz.gisw...@gmail.com>> ha
>> scritto:
>>
>> Hi Roberta,
>>
>> On Wed, Jun 27, 2018 at 1:20 PM, Roberta Fagandini
>> mailto:robifagand...@gmail.com>> wrote:
>>  >
>>  > Hi all!
>>  > I need to compile the 6S library in GRASS in order to install the
>> python library Py6S [0].
>>
>> do you really need Py6S? Can't you use i.atcorr instead?
>>
>>
>> She use Py6S to calculate imput for i.atcorr
>>
>
> That seems a bit overkill: why use Py6S to then use i.atcorr ? What are
> you trying to get from Py6S ?
>
> Moritz
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] ​GSoC 2018 report week 06 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the sixth week of coding.

*1) What did I complete this week?*


   - Better investigated the library ElementTree for parsing xml file
   (sentinel metadata)
   - Started defining an automatic procedure in order to retrieve all the
   necessary parameters for the control file of i.atcorr
   - Started writing the basic code for the automatic compilation of the
   control file
   - Wrote a basic python script for retrieving AOT value from AERONET data
   - Discussed with dev community about the implementation of the
   topographic correction too
   - Made some tests about topographic correction using the GRASS GIS
   module i.topo.cor

Unfortunately, I wasn't able to code for two days because of some
commitments related to the PhD.

*2) What am I going to achieve for next week?*

   - Understand how to automatically retrieve some parameters for the
   control file like aerosol and atmospheric models
   - Finish defining the automatic procedure for retrieve all the necessary
   parameters for the control file
   - Start integrating the atmospheric correction (i.atcorr)

*3) Is there any blocking issue?*
No at the moment.

Here the links to GitHub repository [0] and my wiki page [1]

Kind regards,
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] New GRASS addon i.sentinel.mask is now available (GSoC 2018 project)

[Roberta Fagandini]

Hi Ivan!

2018-06-18 12:05 GMT+02:00 Ivan Barka :

> Hi Roberta,
>
> thank you for your effort. I tried i.sentinel.mask just now with one
> Sentinel-2 granule. I have considerably better results with Level 2A
> Sentinel product, topographically and atmospherically corrected from Level
> 1C by sen2cor with default settings.
>

Thank you so much for testing i.sentinel.mask! If it is possible I would be
very interested in seeing your results.


>
> Regarding strange results of i.topo.corr, I also had a problem few months
> ago. In the first pass, if the resolution of DEM raster differs from
> current region settings, you can create strange illumination model. The
> solution was to set region from the DEM (e.g. with 25 m resolution in case
> of EU-DEM), then to create illumination model with "i.topo.corr -i ..."),
> restore region settings (e.g. with 30 m for Landsat) and finally to apply
> topo correction in the second pass.
> For some unknown reason, i.topo.corr did not change region settings
> automatically, despite you can find "The illumination model (cos_i) with
> flag -i uses the actual region as limits and the resolution of the
> elevation map." in its manual (Notes section).
>

Interesting! I will test i.topo.corr as you suggest.

Thank you!
Roberta


>
> Best regards,
>
> Ivan
>
>
> 2018-06-14 13:08 GMT+02:00 Stefan Blumentrath 
> :
>
>> i.topo.corr performed quite well for us in the Norwegian mountains with
>> minnaert method…
>>
>> What options did you try in i.topo.corr?
>>
>>
>>
>> Cheers
>>
>> Stefan
>>
>>
>>
>> *From:* Roberta Fagandini 
>> *Sent:* torsdag 14. juni 2018 13:01
>> *To:* Stefan Blumentrath 
>> *Cc:* Moritz Lennert ; GRASS developers
>> list 
>>
>> *Subject:* Re: [GRASS-dev] New GRASS addon i.sentinel.mask is now
>> available (GSoC 2018 project)
>>
>>
>>
>> Hi Stefan!
>>
>> Certainly applying the topographic correction could be very useful to
>> avoid misclassification.
>>
>> I did several tests with i.topo.corr but I always got strange results
>> especially in areas with steeper terrain.
>>
>> I also tested the topographic correction tool implemented in arcsi [0]
>> but again the results were not satisfactory at all. This is why I have not
>> further investigated this issue within my PhD research.
>>
>>
>>
>> In order to remove misclassifications, e.g. due to topographic shadows, I
>> implemented the shadow mask cleaning procedure. It intersects the rough
>> shadow mask with the cloud mask that is shifted according to the sun
>> position. In this way, all the areas identified as shadows without a
>> corresponding cloud are removed from the final shadow mask.
>>
>>
>>
>> I'm still very interested in investigating the topographic correction so
>> if you have any suggestion please, let me know!!
>>
>>
>>
>> Ciao,
>>
>> Roberta
>>
>>
>>
>> [0] https://www.arcsi.remotesensing.info/index.html
>>
>>
>>
>> 2018-06-14 10:55 GMT+02:00 Stefan Blumentrath > >:
>>
>> Hi Roberta,
>>
>>
>>
>> What about topographic correction (i.topo.corr [1])?
>>
>> Should that be run before as well?
>>
>> I would assume it has some impact on shadow detection in steeper terrain…
>>
>>
>>
>> Cheers
>>
>> Stefan
>>
>>
>>
>> 1: https://grass.osgeo.org/grass74/manuals/i.topo.corr.html
>>
>>
>>
>> *From:* grass-dev  *On Behalf Of *Roberta
>> Fagandini
>> *Sent:* torsdag 14. juni 2018 10:29
>> *To:* Moritz Lennert 
>> *Cc:* GRASS developers list 
>> *Subject:* Re: [GRASS-dev] New GRASS addon i.sentinel.mask is now
>> available (GSoC 2018 project)
>>
>>
>>
>> Hi Moritz!
>>
>>
>>
>> 2018-06-14 10:03 GMT+02:00 Moritz Lennert :
>>
>> On 13/06/18 17:35, Roberta Fagandini wrote:
>>
>> Hi all!
>> The first version of i.sentinel.mask is now available and can be
>> installed from the official svn repository.
>> i.sentinel.mask is a module for cloud and shadow masks computation and it
>> is the first step of my GSoC project.
>>
>>
>> Thank you, Roberta. Great job !
>>
>>
>>
>> Thank you!
>>
>>
>>
>>
>> One question: ISTR that you mentioned that the input to this module has
>> to be atmospherically corrected images, i.e. land surface reflectance. Is
>> this true ? If yes, then this needs to be mentioned in the man page.
>>
>>
>>
>> Yes, it's true! I'm going to add it.
>>
>>
>>
>> Roberta
>>
>>
>>
>>
>>
>> Moritz
>>
>>
>>
>>
>>
>> ___
>> grass-dev mailing list
>> grass-dev@lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] ​GSoC 2018 report week 05 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the fifth week (first evaluation).

*1) What did I complete this week?*

   - Implemented some changes from dev feedback (e.g. simplified the code
   for reading the input text file and the handling of temporary maps, small
   changes to make the code more readable, etc.)
   - Finished writing the first version of the manual page
   - Cleaned up further the code from the style point of view in order to
   prepare it for the submission to the official GRASS-SVN repository
   (followed PEP8 style guide and GRASS Python Scripting Library rules.)
   - Frequently added the new version of the code to my GitHub repository
   [0]
   - Read and applied all the rules for submitting a GRASS GIS Addon
   - Submitted the code to the official GRASS-SVN repository and informed
   the dev community
   - Discussed possible improvements with the dev community and mentors
   - Shared progress with the community

*2) What am I going to achieve for next week?*

   - Implement any change from discussions and feedback
   - Test and fix bugs
   - Start integrating the atmospheric correction (i.atcorr) within the
   clouds and shadows detection algorithm
   - Start defining an automatic procedure in order to retrieve all the
   necessary parameters for the control file of i.atcorr

*3) Is there any blocking issue?*
No at the moment.

Here the links to GitHub repository [0] and my wiki page [1]

Kind regards,
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] New GRASS addon i.sentinel.mask is now available (GSoC 2018 project)

[Roberta Fagandini]

Hi Stefan!
Certainly applying the topographic correction could be very useful to avoid
misclassification.
I did several tests with i.topo.corr but I always got strange results
especially in areas with steeper terrain.
I also tested the topographic correction tool implemented in arcsi [0]
but again the results were not satisfactory at all. This is why I have not
further investigated this issue within my PhD research.

In order to remove misclassifications, e.g. due to topographic shadows, I
implemented the shadow mask cleaning procedure. It intersects the rough
shadow mask with the cloud mask that is shifted according to the sun
position. In this way, all the areas identified as shadows without a
corresponding cloud are removed from the final shadow mask.

I'm still very interested in investigating the topographic correction so if
you have any suggestion please, let me know!!

Ciao,
Roberta

[0] https://www.arcsi.remotesensing.info/index.html

2018-06-14 10:55 GMT+02:00 Stefan Blumentrath :

> Hi Roberta,
>
>
>
> What about topographic correction (i.topo.corr [1])?
>
> Should that be run before as well?
>
> I would assume it has some impact on shadow detection in steeper terrain…
>
>
>
> Cheers
>
> Stefan
>
>
>
> 1: https://grass.osgeo.org/grass74/manuals/i.topo.corr.html
>
>
>
> *From:* grass-dev  *On Behalf Of *Roberta
> Fagandini
> *Sent:* torsdag 14. juni 2018 10:29
> *To:* Moritz Lennert 
> *Cc:* GRASS developers list 
> *Subject:* Re: [GRASS-dev] New GRASS addon i.sentinel.mask is now
> available (GSoC 2018 project)
>
>
>
> Hi Moritz!
>
>
>
> 2018-06-14 10:03 GMT+02:00 Moritz Lennert :
>
> On 13/06/18 17:35, Roberta Fagandini wrote:
>
> Hi all!
> The first version of i.sentinel.mask is now available and can be installed
> from the official svn repository.
> i.sentinel.mask is a module for cloud and shadow masks computation and it
> is the first step of my GSoC project.
>
>
> Thank you, Roberta. Great job !
>
>
>
> Thank you!
>
>
>
>
> One question: ISTR that you mentioned that the input to this module has to
> be atmospherically corrected images, i.e. land surface reflectance. Is this
> true ? If yes, then this needs to be mentioned in the man page.
>
>
>
> Yes, it's true! I'm going to add it.
>
>
>
> Roberta
>
>
>
>
>
> Moritz
>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] New GRASS addon i.sentinel.mask is now available (GSoC 2018 project)

[Roberta Fagandini]

Hi Moritz!

2018-06-14 10:03 GMT+02:00 Moritz Lennert :

> On 13/06/18 17:35, Roberta Fagandini wrote:
>
>> Hi all!
>> The first version of i.sentinel.mask is now available and can be
>> installed from the official svn repository.
>> i.sentinel.mask is a module for cloud and shadow masks computation and it
>> is the first step of my GSoC project.
>>
>
> Thank you, Roberta. Great job !
>

Thank you!


>
> One question: ISTR that you mentioned that the input to this module has to
> be atmospherically corrected images, i.e. land surface reflectance. Is this
> true ? If yes, then this needs to be mentioned in the man page.


Yes, it's true! I'm going to add it.

Roberta


>
>
> Moritz
>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [EXTERNAL] New GRASS addon i.sentinel.mask is now available (GSoC 2018 project)

[Roberta Fagandini]

Hi Doug!

Thank you!!
I have just tested the installation on Windows and, as Helmut written, I
confirm that it works today!

If you test the module please do not hesitate to send me your feedback
about the results, usability or whatever.

Thanks!

Roberta

2018-06-13 18:33 GMT+02:00 Doug Newcomb :

> Trying to reinstall and getting:
>  Downloading precompiled GRASS Addons ...
> ERROR: Extension  not found
>
> Either Roberta has started looking at it  already or it is a local
> problem.  I will try to chase it down here before I go on vacation.  Either
> way, I appreciate the work Roberta continues to put into this.  Thanks
> again Roberta!
>
>
>
> Doug
>
>
> On Wed, Jun 13, 2018 at 12:17 PM Vaclav Petras 
> wrote:
>
>>
>>
>> On Wed, Jun 13, 2018 at 12:04 PM, Doug Newcomb 
>> wrote:
>>
>>>
>>> Looks like it is set up to require administrative access by default?
>>>
>>> ERROR: Unable to create 'C:\Program Files\GRASS GIS 7.4.0\docs\rest':
>>> [Error 5] Access is denied: 'C:\\Program Files\\GRASS GIS 7.4.0\\docs\\rest'
>>>
>>
>>
>> Are you sure it is not a local problem? Works fine with latest trunk on
>> Linux:
>>
>> grass --tmp-location -c --exec g.extension i.sentinel.mask
>>
>> Likely not related to i.sentinel.mask. Please, try different module.
>>
>
>
> --
> Doug Newcomb
> USFWS
> 551F Pylon Dr
> 
> Raleigh, NC
> 
> 919-856-4520 ext. 14 doug_newc...@fws.gov
> 
> -
>
> *NOTE: This email correspondence and any attachments to and from this
> sender is subject to the Freedom of Information Act (FOIA) and may be
> disclosed to third parties.*​
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] New GRASS addon i.sentinel.mask is now available (GSoC 2018 project)

[Roberta Fagandini]

Hi all!
The first version of i.sentinel.mask is now available and can be installed
from the official svn repository.
i.sentinel.mask is a module for cloud and shadow masks computation and it
is the first step of my GSoC project.

Thanks to those who contributed with their suggestions during this first
period of coding!
I will continue keeping the community constantly updated on the progress of
the module [0][1].
As always, any feedback is welcome!

Kind regards,

Roberta

[0] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
[1] https://github.com/RobiFag/GRASS_clouds_and_shadows
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC 2018 report week 04 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

2018-06-11 10:29 GMT+02:00 Moritz Lennert :

> Hi Roberta,
>
> Thanks for your report and your great work !
>

Thank to you for your support!


>
> Here are a few remarks:
>
> - You have a -t flag with description "Do not delete temporary files".
>   Is this only for debugging purposes (and which temporary files are
>   created), or does this have any real use for the user ? If the
>   former, this should probably not be part of the module UI, if the
>   latter, it should be explained in the man page.
>

I have not yet decided whether to keep the option. At the moment it is
certainly useful for debugging purposes but I also think it could be useful
to users interested in understanding how the procedure works.
What do you think? Could it be useful?


>
> - I have several comments concerning your input_file parameter
>
>
> - The syntax of this file has to be explained in the man page,
>   including the precise variable names (blue, not Blue, not
>   BLUE, etc)
>

Of course! I have already added the explanation this morning.


>
> - The code for reading this file can probably be simplified
>   quite easily by using something like this:
>
> for line in file(input_file):
> a = line.split('=')
> if len(a) <> 2 or a[0] not in ['blue', 'red', etc ]:
> gscript.fatal("Syntax error in the txt file.")
> a[1] = a[1].strip()
> bands[a[0]] = a[1]
>

Thank you! this is a better solution than mine. It was a first experiment
but I have already implemented your suggestion.


>
> - Again a (minor) remark on readability of the code. When you use named
>   variables in format(), I would suggest that you use the actual names.
>   i.e. instead of
>
> gscript.mapcalc('{r} = 1.0 * ({a})/{c}'.format(
> r=("{}_{}".format(b, d)),
> a=b, c=scale_fac),
> overwrite=True)
>
> why not use this:
>
> gscript.mapcalc('{r} = 1.0 * ({b})/{scale_fac}'.format(
> r=("{}_{}".format(b, d)),
> b=b, scale_fac=scale_fac),
> overwrite=True)
>
> ?
>
> I think it makes the formula more easily readable.
>

Yes, you are right! Done!


>
>
> - Some remarks on your handling of temporary maps:
>
> - You use
>
> processid = "{:.2f}".format(time.time())
> processid = processid.replace(".", "_")
>
> why not simply:
>
> processid = os.getpid() ?
>

I didn't know this function, it seems to be cleaner than mine..thank you,
added!


>
> - Instead of having to check for the type of every single map
>   in the cleanup function, you could include the type in the
>   info, i.e. something like this:
>
> r = 'raster'
> v = 'vector'
>
> tmp["cloud_v"] = ["cloud_v_" + processid, v]
> (I personally use "cloud_v_%i" % processid; not sure
> what is preferable)
>
> which then allows you to do something like this in cleanup():
>
> for temp_map, maptype in tmp:
> if gscript.find_file(temp_map, element=maptype)['name']:
> gscript.run_command('g.remove',
> flags='f',
> type=maptype,
> name=temp_map,
> quiet=True)
>

I tried to implement this solution but in this way, I get a warning message:

 WARNING: Illegal filename  etc.

I tried different ways and I looked for something similar but I can not
find how to add the map type in the info.


>
> - In its final version your man page should contain an example,
>   ideally a complete example starting with i.sentinel.download and
>   going all the way to i.sentinal.mask in order to show the use of the
>   module within a reproducible workflow, best using a North Carolina
>   example to fit with the demo dataset.
>

I had already thought about making a complete example. I hope to prepare
and add this first part by the end of this week.


>
>
> Moritz
>

Roberta


>
> Le Sun, 10 Jun 2018 10:58:37 +0200,
> Roberta Fagandini  a écrit :
>
> > Hi all!
> > I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
> > module for Sentinel-2 cloud and shadow detection.
> > This is my report for

[GRASS-dev] ​GSoC 2018 report week 04 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the fourth week of coding.

*1) What did I complete this week?*

   - Implemented some changes from dev feedback (e.g. added a new flag to
   manage the two procedure separately and added the text file option to
   specify input bands)
   - Tested the modified python script and fixed bugs (e.g. solved a bug
   for -s flag)
   - Created a real complete GRASS GIS module that can be installed with
   g.extension
   - Finished implementing the GUI
   - Tested the GUI and fixed bugs
   - Cleaned up the code from the style point of view in order to make it
   more readable (followed PEP8 style guide and GRASS Python Scripting
   Library rules, converted python lists into dictionaries, added comments,
   messages and warnings, etc.)
   - Started writing the manual page
   - Solved a problem with g.extension thanks to dev community suggestions
   - Discussed future improvements with the dev community
   - Frequently added the new version of the code to my GitHub repository
   [0]
   - Shared progress with the community

*2) What am I going to achieve for next week?*

   - Implement any change from discussions and feedback
   - Test and fix bugs
   - Finish writing the manual page
   - Check the code with mentors
   - Prepare deliverable for the evaluation

*3) Is there any blocking issue?*
No at the moment.

Here the links to my wiki page [1] and GitHub repository [0]

Kind regards,
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] ​GSoC 2018 report week 03 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Moritz,

2018-06-06 9:12 GMT+02:00 Moritz Lennert :

> Hi Roberta,
>
> On 04/06/18 16:14, Roberta Fagandini wrote:
>
>> 2018-06-04 11:54 GMT+02:00 Nikos Alexandris > <mailto:n...@nikosalexandris.net>>:
>>
>> - for using the metadata file, and parsing it -- my experience with
>>   Landsat and other high-resolution satellite products, showed it's
>> best to
>>   trust the individual metadata that accompany an acquisition.
>>Parameters may be very specific to one single acquisition.
>>   Also, a module that is designed to be "dynamic" is more
>>   future-proof and easy to maintain and update.
>>For example, reading band names from the meta-data, as opposed to
>> more
>>   "static" designs, i.e. expecting specific hardcoded options, such as
>>   band names, or their order.
>>
>> I have already thought about parsing the metadatafile to retrieve the
>> input bands but at the moment the module requires atmospherically corrected
>> bands and if users perform the atmospheric correction on their own I don't
>> have any control on naming. Moreover, the module needs to know which raster
>> map corresponds to the blue band, to the green band and so on in order to
>> apply the rules for clouds and shadows detection. Therefore I need users
>> specify each band but maybe I can manage this issue requiring a specific
>> suffix in the bands' names (e.g. blabla_blue, blabla_green, etc.). In this
>> way, users have to provide only the prefix (blabla) while the module search
>> for all raster maps with the specified prefix and at the same time it is
>> able to recognize each band.
>>
>
> I forgot that the data had to be pretreated, so reading your
> argumentation, I actually think your current approach is the most flexible
> and so the best. Imposing band names is not a good idea IMHO. One option
> could be a file= parameter which allows providing all the names of all
> input bands in a text file (respecting a given order), but I think this is
> not a priority.


Thank you for the hint! I think the file option is the best choice at the
moment.


>
>> Anyway, the aim of the next coding period is to create a python script
>> that wraps in a single GRASS module the download and import phase
>> (i.sentinel.download and i.sentinel.import), the atmospheric correction
>> using i.atcorr and the cloud and shadow detection procedure. In particular,
>> for what concerns the atmospheric correction, I'd like to implement an
>> iterative procedure that executes i.atcorr for all bands of the input image
>> changing accordingly the requested input parameters. This part should
>> simplify the management of input maps.
>>
>
> That's sounds really nice. I agree that your module should do one thing
> and do it good. As you say, wrapper scripts can then combine different
> modules to provide more automation.


Providing more automation as possible is my goal! I hope to be able to
reach it ;-)

Roberta

>
>
> Moritz
>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] unable to install my grass module from the GitHub repository

[Roberta Fagandini]

Thank you, Vaclav!
I moved the module at the top level and now it works!!

Roberta

2018-06-05 15:31 GMT+02:00 Vaclav Petras :

>
>
> On Tue, Jun 5, 2018 at 8:49 AM, Moritz Lennert <
> mlenn...@club.worldonline.be> wrote:
>
>>
>>
>> Am 5. Juni 2018 14:38:49 MESZ schrieb Roberta Fagandini <
>> robifagand...@gmail.com>:
>> >Hi all!
>> >I'm trying to install my module i.sentinel.mask from the GitHub
>> >repository
>> >[0] using g.extension but I get the following error:
>> >
>> >g.extension extension=i.sentinel.mask operation=add url=
>> >https://github.com/RobiFag/GRASS_clouds_and_shadows
>>
>> I think you have to point it to the directory of your add-on, i.e.
>>
>> https://github.com/RobiFag/GRASS_clouds_and_shadows/i.sentinel.mask
>>
>> But am in a train and can't test right now.
>>
>
>
> Unfortunately, g.extension GitHub/GitLab/... repository downloads
> currently support only module (Makefile to be exact) at the top level. You
> need to download the repo (e.g. a snapshot in the ZIP file) and point
> g.extension to the right (sub)directory (with Makefile) or just add couple
> of functions to g.extension to find that directory.
>
> Vaclav
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] unable to install my grass module from the GitHub repository

[Roberta Fagandini]

Hi Markus!

2018-06-05 14:49 GMT+02:00 Markus Metz :

> Hi Roberta,
>
> On Tue, Jun 5, 2018 at 2:38 PM, Roberta Fagandini 
> wrote:
> >
> > Hi all!
> > I'm trying to install my module i.sentinel.mask from the GitHub
> repository [0] using g.extension but I get the following error:
> >
> > g.extension extension=i.sentinel.mask operation=add url=
> https://github.com/RobiFag/GRASS_clouds_and_shadows
> >
> > Fetching  from <https://github.com/RobiFag/GR
> ASS_clouds_and_shadows/archive/master.zip> (be patient)...
> > Compiling...
> > Installing...
> > make: *** No rule to make target `install'. Stop.
> > WARNING: Installation failed, sorry. Please check above error messages.
> >
> > any suggestion?
>
> One error was
> Compiling...
> make[1]: *** No rule to make target `/tmp/grass7-roberta-701
> 4/tmpe7QEso/i.sentinel.mask/scripts/i.sentinel.mask', needed
> by `script'. Stop.
> /bin/sh: 1: cannot create /usr/lib/grass74/error.log:
> Permission denied
>
> i.e. this is a system-wide installation of GRASS 7.4
>
> Can you try again with GRASS 7.5 compiled from source, without installing?
> That should avoid the "Permission denied" error.
> The GRASS start script is in the source tree in bin.x86_64-pc-linux-gnu
>

I tried with GRASS 7.5 and I got the error message

Fetching  from <https://github.com/RobiFag/
GRASS_clouds_and_shadows/archive/master.zip> (be patient)...
Compiling...
Installing...
make: *** No rule to make target `install'. Stop.
WARNING: Installation failed, sorry. Please check above error messages.

While if I point it to the directory of the add-on (
https://github.com/RobiFag/GRASS_clouds_and_shadows/i.sentinel.mask) I get
another error:

Fetching  from <
https://github.com/RobiFag/GRASS_clouds_and_shadows/i.sentinel.mask/archive/master.zip>
(be patient)...
ERROR: Extension  not found

Roberta


> Markus M
>
> >
> > Thanks in advance!
> > Roberta
> >
> > [0] https://github.com/RobiFag/GRASS_clouds_and_shadows
> >
> > ___
> > grass-dev mailing list
> > grass-dev@lists.osgeo.org
> > https://lists.osgeo.org/mailman/listinfo/grass-dev
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] unable to install my grass module from the GitHub repository

[Roberta Fagandini]

Hi all!
I'm trying to install my module i.sentinel.mask from the GitHub repository
[0] using g.extension but I get the following error:

g.extension extension=i.sentinel.mask operation=add url=
https://github.com/RobiFag/GRASS_clouds_and_shadows

Fetching  from <
https://github.com/RobiFag/GRASS_clouds_and_shadows/archive/master.zip> (be
patient)...
Compiling...
Installing...
make: *** No rule to make target `install'. Stop.
WARNING: Installation failed, sorry. Please check above error messages.

any suggestion?

Thanks in advance!
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] ​GSoC 2018 report week 03 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Nikos!

2018-06-04 17:23 GMT+02:00 Nikos Alexandris :

> * Roberta Fagandini  [2018-06-04 16:14:16 +0200]:
>
>
> Hi all!
>>
>> Thank you, Moritz and Nikos, for your suggestions!
>>
>> 2018-06-04 11:54 GMT+02:00 Nikos Alexandris :
>>
>> Ciao Roberta,
>>>
>>> great work!
>>>
>>> Moritz got me faster, as I intended to chime in, with similar
>>> suggestions.
>>>
>>> So +1 for:
>>>
>>> - a "real" module, as Moritz described it
>>>
>>>
>> Done! I added the folder to my github repository but I have some trouble
>> compiling the module with g.extension:
>>
>> g.extension extension=i.sentinel.mask operation=add url=
>> https://github.com/RobiFag/GRASS_clouds_and_shadows
>>
>> error message:
>> g.extension extension=i.sentinel.mask operation=add url=
>> https://github.com/RobiFag/GRASS_clouds_and_shadows
>> Fetching  from <
>> https://github.com/RobiFag/GRASS_clouds_and_shadows/archive/master.zip>
>> (be
>> patient)...
>> Compiling...
>> make[1]: *** No rule to make target `/tmp/grass7-roberta-701
>> 4/tmpe7QEso/i.sentinel.mask/scripts/i.sentinel.mask', needed
>> by `script'. Stop.
>> /bin/sh: 1: cannot create /usr/lib/grass74/error.log:
>> Permission denied
>> make: *** [i.sentinel.mask] Error 2
>> ERROR: Compilation failed, sorry. Please check above error messages.
>>
>> any suggestion?
>>
>
> Maybe irrelevant, but perhaps it is best to name the script as
> `i.sentinel.mask.py`?


I named the file as you suggested but I still have some problems, now the
error message is:

Fetching  from <
https://github.com/RobiFag/GRASS_clouds_and_shadows/archive/master.zip> (be
patient)...
Compiling...
Installing...
make: *** No rule to make target `install'. Stop.
WARNING: Installation failed, sorry. Please check above error messages.


>
>
>
> - for using the metadata file, and parsing it -- my experience with
>>>  Landsat and other high-resolution satellite products, showed it's best
>>> to
>>>  trust the individual metadata that accompany an acquisition.
>>>   Parameters may be very specific to one single acquisition.
>>>  Also, a module that is designed to be "dynamic" is more
>>>  future-proof and easy to maintain and update.
>>>   For example, reading band names from the meta-data, as opposed to more
>>>  "static" designs, i.e. expecting specific hardcoded options, such as
>>>  band names, or their order.
>>>
>>>
>> I have already thought about parsing the metadatafile to retrieve the
>> input
>> bands but at the moment the module requires atmospherically corrected
>> bands
>> and if users perform the atmospheric correction on their own I don't have
>> any control on naming. Moreover, the module needs to know which raster map
>> corresponds to the blue band, to the green band and so on in order to
>> apply
>> the rules for clouds and shadows detection. Therefore I need users specify
>> each band but maybe I can manage this issue requiring a specific suffix in
>> the bands' names (e.g. blabla_blue, blabla_green, etc.). In this way,
>> users
>> have to provide only the prefix (blabla) while the module search for all
>> raster maps with the specified prefix and at the same time it is able to
>> recognize each band.
>>
>> Anyway, the aim of the next coding period is to create a python script
>> that
>> wraps in a single GRASS module the download and import phase
>> (i.sentinel.download and i.sentinel.import), the atmospheric correction
>> using i.atcorr and the cloud and shadow detection procedure. In
>> particular,
>> for what concerns the atmospheric correction, I'd like to implement an
>> iterative procedure that executes i.atcorr for all bands of the input
>> image
>> changing accordingly the requested input parameters. This part should
>> simplify the management of input maps.
>>
>
> One thing here: massive processing workflows like to have simple
> processing building blocks. One Input -> one Process -> one Output. In
> "your" case:
>
> - Input: name of/request one band and associated
>  metadata, and optionally other ancillary data.
>
> - Process: download, import, removal of atmospheric effects to estimate
>  surface reflectance
>
> - Output: surface reflectance ("corrected" for atmospheric effects) of
>  the requested input band
>
> This building block can run in one processing units/node. Making use of
> many
> processing unit

Re: [GRASS-dev] ​GSoC 2018 report week 03 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!

Thank you, Moritz and Nikos, for your suggestions!

2018-06-04 11:54 GMT+02:00 Nikos Alexandris :

> Ciao Roberta,
>
> great work!
>
> Moritz got me faster, as I intended to chime in, with similar
> suggestions.
>
> So +1 for:
>
> - a "real" module, as Moritz described it
>

Done! I added the folder to my github repository but I have some trouble
compiling the module with g.extension:

g.extension extension=i.sentinel.mask operation=add url=
https://github.com/RobiFag/GRASS_clouds_and_shadows

error message:
g.extension extension=i.sentinel.mask operation=add url=
https://github.com/RobiFag/GRASS_clouds_and_shadows
Fetching  from <
https://github.com/RobiFag/GRASS_clouds_and_shadows/archive/master.zip> (be
patient)...
Compiling...
make[1]: *** No rule to make target `/tmp/grass7-roberta-701
4/tmpe7QEso/i.sentinel.mask/scripts/i.sentinel.mask', needed
by `script'. Stop.
/bin/sh: 1: cannot create /usr/lib/grass74/error.log:
Permission denied
make: *** [i.sentinel.mask] Error 2
ERROR: Compilation failed, sorry. Please check above error messages.

any suggestion?


>
> - for using the metadata file, and parsing it -- my experience with
>  Landsat and other high-resolution satellite products, showed it's best to
>  trust the individual metadata that accompany an acquisition.
>   Parameters may be very specific to one single acquisition.
>  Also, a module that is designed to be "dynamic" is more
>  future-proof and easy to maintain and update.
>   For example, reading band names from the meta-data, as opposed to more
>  "static" designs, i.e. expecting specific hardcoded options, such as
>  band names, or their order.
>

I have already thought about parsing the metadatafile to retrieve the input
bands but at the moment the module requires atmospherically corrected bands
and if users perform the atmospheric correction on their own I don't have
any control on naming. Moreover, the module needs to know which raster map
corresponds to the blue band, to the green band and so on in order to apply
the rules for clouds and shadows detection. Therefore I need users specify
each band but maybe I can manage this issue requiring a specific suffix in
the bands' names (e.g. blabla_blue, blabla_green, etc.). In this way, users
have to provide only the prefix (blabla) while the module search for all
raster maps with the specified prefix and at the same time it is able to
recognize each band.

Anyway, the aim of the next coding period is to create a python script that
wraps in a single GRASS module the download and import phase
(i.sentinel.download and i.sentinel.import), the atmospheric correction
using i.atcorr and the cloud and shadow detection procedure. In particular,
for what concerns the atmospheric correction, I'd like to implement an
iterative procedure that executes i.atcorr for all bands of the input image
changing accordingly the requested input parameters. This part should
simplify the management of input maps.


> - PEP8 rules and keeping module options in separate lines to increase
> legibility
>
> In line with the suggestions on style, I would stress out to fully
> spell out the names of functions, options, descriptions of flags,
> iterables and iterators.  It will make it easier for the next reader of
> your code.
>

Yes, you are both right!! I have to clean up the code from the style point
of view and it will be one of the tasks of this week and especially of the
last days before the GSoC Evaluation.


>
> Finally, it's a good idea to write even mini-tests, while you are
> progressing, for the small functions that eventually develop to keep the
> full scrip compact, functional and more legible.
>
> Writing a test, for your module, in the end, will be much easier.
>

Sorry Nikos but I don't really understand what you mean by
"mini-tests"..are you referring to the examples in the manual page?


>
> I am sure you know all this. Yet, discussing it is a good thing in
> my view.
>

Discussing it is very useful especially for me so please do not take
anything for granted and keep sending me your feedback!


>
> Keep up the good work, Nikos
>

Cheers!
Roberta


>
>
>
> * Moritz Lennert  [2018-06-04 11:03:41
> +0200]:
>
> Hi Roberta !
>>
>> On 03/06/18 14:38, Roberta Fagandini wrote:
>>
>>> Hi all!
>>> I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
>>> module for Sentinel-2 cloud and shadow detection.
>>> This is my report for the third week of coding.
>>>
>>> *1) What did I complete this week?*
>>>
>>>  * Implemented some changes from dev feedback (e.g. r.univar instead of
>>>r.stats.zonal)
>>>  * Tested the modified python script and fixed bugs
>>>  * Prepared the pytho

Re: [GRASS-dev] ​GSoC 2018 report week 03 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi Stefan,
thank you for the question!!
The two procedures are not completely indipendent from each other, indeed
the shadows mask relies on the computation of the clouds mask for the
"cleaning" phase. Maybe it could make sense to manage both procedures using
a flag. In this way users can decide via GUI whether to compute only the
clouds mask or both.
What do you think? Would it be helpful?

Ciao
Roberta

2018-06-03 15:04 GMT+02:00 Stefan Blumentrath :

> Nice progress!
>
> Quick question: Would it make sense to split the module into one
> cloud-detection and one cloud shadow detection module? Or are both
> processes interdependent?
>
>
>
> Cheers,
>
> Stefan
>
>
>
> *From:* grass-dev  *On Behalf Of *Roberta
> Fagandini
> *Sent:* søndag 3. juni 2018 14:39
> *To:* s...@lists.osgeo.org; GRASS developers list <
> grass-dev@lists.osgeo.org>
> *Subject:* [GRASS-dev] ​GSoC 2018 report week 03 - GRASS GIS module for
> Sentinel-2 cloud and shadow detection
>
>
>
> Hi all!
>
> I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
> module for Sentinel-2 cloud and shadow detection.
>
> This is my report for the third week of coding.
>
>
>
> *1) What did I complete this week?*
>
> · Implemented some changes from dev feedback (e.g. r.univar instead of
> r.stats.zonal)
>
> · Tested the modified python script and fixed bugs
>
> · Prepared the python script in order to start implementing the GUI
>
> · Started implementing the GUI
>
> · Made some changes to the code depending on the GUI requirements (add
> controls and check on input, output and temporary file, etc.)
>
> · Cleaned up the whole code
>
> · Tested the GUI and fixed bugs
>
> · Frequently added the basic version of the GUI to my GitHub repository
> [0]
>
> · Shared progress with the community
>
> *2) What am I going to achieve for next week?*
>
> · Implement any change from discussions and feedback
>
> · Test and fix bugs
>
> · Finish the implementation of the GUI
>
> · Start writing the manual page
>
> *3) Is there any blocking issue?*
>
> No at the moment.
>
>
>
> Here the links to my wiki page [1] and GitHub repository [0]
>
>
>
> Kind regards,
>
> Roberta
>
>
>
> [0] https://github.com/RobiFag/GRASS_clouds_and_shadows
>
> [1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
>
>
>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] ​GSoC 2018 report week 03 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the third week of coding.

*1) What did I complete this week?*

   - Implemented some changes from dev feedback (e.g. r.univar instead of
   r.stats.zonal)
   - Tested the modified python script and fixed bugs
   - Prepared the python script in order to start implementing the GUI
   - Started implementing the GUI
   - Made some changes to the code depending on the GUI requirements (add
   controls and check on input, output and temporary file, etc.)
   - Cleaned up the whole code
   - Tested the GUI and fixed bugs
   - Frequently added the basic version of the GUI to my GitHub repository
   [0]
   - Shared progress with the community

*2) What am I going to achieve for next week?*

   - Implement any change from discussions and feedback
   - Test and fix bugs
   - Finish the implementation of the GUI
   - Start writing the manual page

*3) Is there any blocking issue?*
No at the moment.

Here the links to my wiki page [1] and GitHub repository [0]

Kind regards,
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] Avoid the addition of @mymapset in output map name

[Roberta Fagandini]

2018-05-31 15:08 GMT+02:00 Roberto Marzocchi :

>
>
> 2018-05-29 14:09 GMT+02:00 Markus Metz :
>
>> Hi Roberta,
>>
>> On Tue, May 29, 2018 at 1:41 PM, Moritz Lennert <
>> mlenn...@club.worldonline.be> wrote:
>> >
>> > Hi Roberta,
>> >
>> > Le Tue, 29 May 2018 13:16:48 +0200,
>> > Roberta Fagandini  a écrit :
>> >
>> > > Hi all!
>> > > I'm working on the GUI of my module for clouds and shadows detection
>> > > in Sentinel 2 images  (GSoC 2018 project) and I have some trouble
>> > > with the automatic addition of the mapset name in the output maps.
>> > > I have several input bands imported in GRASS that I convert into float
>> > > value and rescale using r.mapcalc, each output map should be
>> > > automatically named with the inputs band name and a suffix (e.g.
>> > > input: nir - output: nir_float).
>> > > When I run the script using the GUI I have an error due to the @mapset
>> > > automatically added to the output map name (e.g. nir@mymapset_float).
>> > >
>> > > At the moment, I solved the problem with a replace() function but I'm
>> > > not sure this can be the best solution, do you have any hint?
>> >
>> > A classic solution that you will find in many scripts is using split():
>> >
>> > mapname_without_mapset = mapname_with_mapset.split('@')[0]
>>
>> there is find_file() in lib/python/script/core.py with returns a
>> dictionary of keys/values including the name without mapset
>>
>> Markus M
>>
>
> With find_file it should work also for maps in different mapset.
> Roberta can you test it?
>
> R
>

Yes, it works!
Thank you all for your help!

Roberta

>
>
>
>>
>> >
>> > Moritz
>> > ___
>> > grass-dev mailing list
>> > grass-dev@lists.osgeo.org
>> > https://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>>
>> ___
>> grass-dev mailing list
>> grass-dev@lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] Avoid the addition of @mymapset in output map name

[Roberta Fagandini]

Hi all!
I'm working on the GUI of my module for clouds and shadows detection in
Sentinel 2 images  (GSoC 2018 project) and I have some trouble with the
automatic addition of the mapset name in the output maps.
I have several input bands imported in GRASS that I convert into float
value and rescale using r.mapcalc, each output map should be automatically
named with the inputs band name and a suffix (e.g. input: nir - output:
nir_float).
When I run the script using the GUI I have an error due to the @mapset
automatically added to the output map name (e.g. nir@mymapset_float).

At the moment, I solved the problem with a replace() function but I'm not
sure this can be the best solution, do you have any hint?

Following you can find the code:

mapset = gscript.gisenv()['MAPSET']
mapset2 = '@%s' % mapset
b1 = options['blu']
b1 = b1.replace(mapset2, "")
b2 = options['green']
b2 = b2.replace(mapset2, "")
b3 = options['red']
b3 = b3.replace(mapset2, "")
b4 = options['nir']
b4 = b4.replace(mapset2, "")
b5 = options['nir8a']
b5 = b5.replace(mapset2, "")
b7 = options['swir11']
b7 = b7.replace(mapset2, "")
b8 = options['swir12']
b8 = b8.replace(mapset2, "")
f = 'float'
bands = [b1, b2, b3, b4, b5, b7, b8]

for b in bands:
gscript.mapcalc('{r} = 1.0 * ({a})/{c}'.format(r="%s_%s" % (b, f), a=b,
c=scale_fac), overwrite=True)
f_bands.append ("%s_%s" % (b, f))


Thanks in advance,
Roberta
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] ​GSoC 2018 report week 02 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the second week of coding.

*1) What did I complete this week?*

   - Added a basic version of the shadow detection procedure
   - Implemented some changes from dev feedback
   - Cleaned up the cloud detection code reducing the r.mapcalc calls and
   other computations in order to improve performance
   - Cleaned up the shadow detection code reducing the r.mapcalc calls and
   other computations in order to improve performance
   - Integrated the cloud and shadow intersection part
   - Managed temporary file
   - Tested the python script and fixed bugs
   - Frequently added the python script to my GitHub repository [0]
   - Shared progress with the community

*2) What am I going to achieve for next week?*

   - Implement any change from discussions and feedback
   - Test it and fix bugs
   - Start implementing the GUI

*3) Is there any blocking issue?*
No at the moment.

Here the links to my wiki page [1] and GitHub repository [0]

Kind regards,
Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Ciao Stefan!

2018-05-25 11:19 GMT+02:00 Stefan Blumentrath <stefan.blumentr...@nina.no>:

> Ciao Roberta,
>
>
>
> Thanks, that was exactly what I had in mind!
>

I'm still cleaning the code managing temporary file and arranging it in
order to add the GUI next week! I hope the next version will be even better
(I'm going to upload it later in the afternoon).

Thank you for your suggestions, they are so useful for me!


>
>
> When you find the time you could consider the following further
> improvements:
>
>- Scaling in the beginning: Currently input is scaled with a
>hard-coded factor, that is not necessarily generic. You could either:
>
>
>1. Drop scaling completely and document in the manual how input should
>be scaled. Esp. if the input to your algorithm is output from i.atcorr, as
>i.atcorr has a scaling option for output.
>2. Make scaling factor a parameter that users can provide (would be
>useful if atmospheric correction is performed with other tools than
>i.atcorr)
>
> I agree with you! The next month aim is to implement an automatic
procedure to run i.atcorr within mine, retrieving automatically all
necessary parameters for the control file. Therefore, I think making the
scaling factor an user-defined parameter can be the best choice, in this
way users can choose their own factor or to not use it in case the
atmospheric correction is performed with i.atcorr or within the cloud and
shadow detection procedure. At the moment I have changed the code defining
the scaling factor as a variable, this should help in managing the GUI for
this step.


>
>- Band statistics: It seems you are computing “zonal statistics” with
>just one zone which in practice will be a sort of global maximum per band.
>In that case you do not need a map and can use a constant in r.mapcalc.
>If you need to use global maximum reflectance per band, you could use:
>
> gscript.parse_command(‘r.info’, flags=’g’, …) if the maximum for the
> entire map is needed. This would be the fastest option.
> If you need to use maximum within current computational region (or e.g.
> with a different mask applied) you could use:
> gscript.parse_command(‘r.univar’, flags=’g’, …); then statistics are
> computed
> From that you get “max” as a variable.
>

You're right! At the moment I manage the stats maps as temporary files but
actually, it is not necessary to create them..I have already change the
code.


>
>- Also having an eye on coding style (pep8 in this case) from the
>beginning, can be very helpful, especially in the beginning (at least that
>is my experience). To start with you could check your code as described
>here:
>https://trac.osgeo.org/grass/wiki/Submitting/Python#Style A more
>comprehensive tutorial can be found e.g. here:
>https://www.datacamp.com/community/tutorials/pep8-tutorial-python-code
><https://www.datacamp.com/community/tutorials/pep8-tutorial-python-code>
>
> Thank you for the hint! these will certainly help me..I'm a bit messy!


> Just for inspiration…
>
>
>
> Kind regards,
>
> Stefan
>

Kind regards,
Roberta


>
>
>
>
> *From:* Roberta Fagandini <robifagand...@gmail.com>
> *Sent:* onsdag 23. mai 2018 17.07
> *To:* GRASS developers list <grass-dev@lists.osgeo.org>
> *Cc:* Stefan Blumentrath <stefan.blumentr...@nina.no>; Roberto Marzocchi <
> roberto.marzoc...@gmail.com>; Moritz Lennert <mlenn...@club.worldonline.be
> >; s...@lists.osgeo.org
> *Subject:* Re: [GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module
> for Sentinel-2 cloud and shadow detection
>
>
>
> Hi all!
>
> I have just added a new version of the grass python script to my GitHub
> repository [0].
>
> I tried to clean up the code.
>
> As always, any feedback is welcome!
>
>
>
> Thanks in advance!
>
>
>
> Roberta
>
>
>
> [0] https://github.com/RobiFag/GRASS_clouds_and_shadows
>
>
>
> 2018-05-21 15:19 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com>:
>
> Ciao Stefan!
>
>
>
> 2018-05-20 21:44 GMT+02:00 Stefan Blumentrath <stefan.blumentr...@nina.no
> >:
>
> Ciao Roberta,
>
> Thanks for the comprehensive report!
>
> One general hint: Even if the drawback is complex expression(s) I would
> suggest merging r.mapcalc calls. That can improve performance quite a bit
> (less data read and written) and reduces the need to manage temporary data.
>
> See also: https://grass.osgeo.org/
> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
> grass74
> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
> /manuals/r.mapcal

Re: [GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I have just added a new version of the grass python script to my GitHub
repository [0].
I tried to clean up the code.
As always, any feedback is welcome!

Thanks in advance!

Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows

2018-05-21 15:19 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com>:

> Ciao Stefan!
>
> 2018-05-20 21:44 GMT+02:00 Stefan Blumentrath <stefan.blumentr...@nina.no>
> :
>
>> Ciao Roberta,
>>
>> Thanks for the comprehensive report!
>>
>> One general hint: Even if the drawback is complex expression(s) I would
>> suggest merging r.mapcalc calls. That can improve performance quite a bit
>> (less data read and written) and reduces the need to manage temporary data.
>>
>> See also: https://grass.osgeo.org/
>> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
>> grass74
>> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
>> /manuals/r.mapcalc.html#multiple-computations
>> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
>>
>> If you don't need the first_... To fifth_... files later, I would even
>> say everything in 3rd_procedure.py until r.to.vect could be solved in a
>> single mapcalc operation...
>>
>
> Thank you so much for your hints! I'm trying to clean up the code without
> creating a too complex expression..I hope to share the new version by this
> evening or tomorrow at the latest.
>
>
>>
>> Kind regards and again thank for your GSoC work,
>> Stefan
>>
>>
> Thanks again!!
> Roberta
>
>
>>
>> --
>> *From:* grass-dev <grass-dev-boun...@lists.osgeo.org> on behalf of
>> Roberta Fagandini <robifagand...@gmail.com>
>> *Sent:* Sunday, May 20, 2018 4:33:57 PM
>> *To:* s...@lists.osgeo.org; GRASS developers list
>> *Subject:* [GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module for
>> Sentinel-2 cloud and shadow detection
>>
>> Hi all!
>> I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
>> module for Sentinel-2 cloud and shadow detection.
>> This is my report for the first week of coding.
>> Since my progress has been a bit faster than expected I have already
>> discussed with my mentors about further additions to the project. Therefore
>> I have already updated my wiki page [0] changing the timeline. In this way,
>> I will be able to release a more complete module.
>>
>> *1) What did I complete this week?*
>>
>>- Checked the prototype version of the algorithm for cloud and shadow
>>detection
>>- Tested it
>>- I better studied the documentation of the GRASS Python Scripting
>>Library and started coding the GRASS python script following the
>>workflow schema prepared during the bonding period [1]
>>- Coded the 'data preparation' phase
>>- Coded the clouds detection procedure
>>- Added this first part of python script to my GitHub repository [2]
>>- Discussed with my mentors about further additions
>>- Discussed with the community about testing phase. I received some
>>feedback and some developers stepped forward to help me in testing the
>>algorithm
>>- Shared progress with the community
>>
>> Unfortunately, I wasn't able to code on Thursday because of a PhD meeting
>> with my supervisor.
>>
>> *2) What am I going to achieve for next week?*
>>
>>- Finish the translation of the algorithm in a basic python script
>>adding the shadows detection procedure and the steps for checking and
>>cleaning the final outputs (see [1] for details)
>>- Improve the python script so as to have a "light" working python
>>script (manage temporary file, clean up the code, etc.)
>>- Test it and fix bugs
>>- Start implementing the GUI
>>
>> *3) Is there any blocking issue?*
>> No at the moment.
>>
>> Best wishes,
>> Roberta
>>
>> [0] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
>> [1] https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW
>> 80Z-7br81/view?usp=sharing
>> [2] https://github.com/RobiFag/GRASS_clouds_and_shadows
>>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Ciao Stefan!

2018-05-20 21:44 GMT+02:00 Stefan Blumentrath <stefan.blumentr...@nina.no>:

> Ciao Roberta,
>
> Thanks for the comprehensive report!
>
> One general hint: Even if the drawback is complex expression(s) I would
> suggest merging r.mapcalc calls. That can improve performance quite a bit
> (less data read and written) and reduces the need to manage temporary data.
>
> See also: https://grass.osgeo.org/
> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
> grass74
> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
> /manuals/r.mapcalc.html#multiple-computations
> <https://grass.osgeo.org/grass74/manuals/r.mapcalc.html#multiple-computations>
>
> If you don't need the first_... To fifth_... files later, I would even say
> everything in 3rd_procedure.py until r.to.vect could be solved in a single
> mapcalc operation...
>

Thank you so much for your hints! I'm trying to clean up the code without
creating a too complex expression..I hope to share the new version by this
evening or tomorrow at the latest.


>
> Kind regards and again thank for your GSoC work,
> Stefan
>
>
Thanks again!!
Roberta


>
> ------
> *From:* grass-dev <grass-dev-boun...@lists.osgeo.org> on behalf of
> Roberta Fagandini <robifagand...@gmail.com>
> *Sent:* Sunday, May 20, 2018 4:33:57 PM
> *To:* s...@lists.osgeo.org; GRASS developers list
> *Subject:* [GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module for
> Sentinel-2 cloud and shadow detection
>
> Hi all!
> I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
> module for Sentinel-2 cloud and shadow detection.
> This is my report for the first week of coding.
> Since my progress has been a bit faster than expected I have already
> discussed with my mentors about further additions to the project. Therefore
> I have already updated my wiki page [0] changing the timeline. In this way,
> I will be able to release a more complete module.
>
> *1) What did I complete this week?*
>
>- Checked the prototype version of the algorithm for cloud and shadow
>detection
>- Tested it
>- I better studied the documentation of the GRASS Python Scripting
>Library and started coding the GRASS python script following the
>workflow schema prepared during the bonding period [1]
>- Coded the 'data preparation' phase
>- Coded the clouds detection procedure
>- Added this first part of python script to my GitHub repository [2]
>- Discussed with my mentors about further additions
>- Discussed with the community about testing phase. I received some
>feedback and some developers stepped forward to help me in testing the
>algorithm
>- Shared progress with the community
>
> Unfortunately, I wasn't able to code on Thursday because of a PhD meeting
> with my supervisor.
>
> *2) What am I going to achieve for next week?*
>
>- Finish the translation of the algorithm in a basic python script
>adding the shadows detection procedure and the steps for checking and
>cleaning the final outputs (see [1] for details)
>- Improve the python script so as to have a "light" working python
>script (manage temporary file, clean up the code, etc.)
>- Test it and fix bugs
>- Start implementing the GUI
>
> *3) Is there any blocking issue?*
> No at the moment.
>
> Best wishes,
> Roberta
>
> [0] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
> [1] https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW
> 80Z-7br81/view?usp=sharing
> [2] https://github.com/RobiFag/GRASS_clouds_and_shadows
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] ​GSoC 2018 report week 01 - GRASS GIS module for Sentinel-2 cloud and shadow detection

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini and I'm working on my GSoC project, a GRASS GIS
module for Sentinel-2 cloud and shadow detection.
This is my report for the first week of coding.
Since my progress has been a bit faster than expected I have already
discussed with my mentors about further additions to the project. Therefore
I have already updated my wiki page [0] changing the timeline. In this way,
I will be able to release a more complete module.

*1) What did I complete this week?*

   - Checked the prototype version of the algorithm for cloud and shadow
   detection
   - Tested it
   - I better studied the documentation of the GRASS Python Scripting
   Library and started coding the GRASS python script following the
   workflow schema prepared during the bonding period [1]
   - Coded the 'data preparation' phase
   - Coded the clouds detection procedure
   - Added this first part of python script to my GitHub repository [2]
   - Discussed with my mentors about further additions
   - Discussed with the community about testing phase. I received some
   feedback and some developers stepped forward to help me in testing the
   algorithm
   - Shared progress with the community

Unfortunately, I wasn't able to code on Thursday because of a PhD meeting
with my supervisor.

*2) What am I going to achieve for next week?*

   - Finish the translation of the algorithm in a basic python script
   adding the shadows detection procedure and the steps for checking and
   cleaning the final outputs (see [1] for details)
   - Improve the python script so as to have a "light" working python
   script (manage temporary file, clean up the code, etc.)
   - Test it and fix bugs
   - Start implementing the GUI

*3) Is there any blocking issue?*
No at the moment.

Best wishes,
Roberta

[0] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
[1] https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW
80Z-7br81/view?usp=sharing
[2] https://github.com/RobiFag/GRASS_clouds_and_shadows
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Pierre,

2018-05-16 23:42 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:

> Hi Stefan and Roberta,
>
> We can probably help too -- I work on Antarctic datasets: relief,
> clouds, and very cold, white surface!
>

Thank you so much, I really appreciate it!

Here the link to my wiki page [0] and github repository [1] to follow the
project progress.

[0] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
[1] https://github.com/RobiFag/GRASS_clouds_and_shadows


>
> Cheers,
>
> P
>

Keep in touch!
best wishes

Roberta



>
> On 17 May 2018 at 02:22, Stefan Blumentrath <stefan.blumentr...@nina.no>
> wrote:
> > Hi Roberta,
> >
> >
> >
> > Here in Norway we can do some “worst case” testing for your algorithm.
> > Plenty of snow and clouds in the mountains, and heavily rugged terrain,
> that
> > presumably has quite some effect on cloud shadows…
> >
> >
> >
> > Looking forward to following your project from the side!
> >
> >
> >
> > Kind regards,
> >
> > Stefan
> >
> >
> >
> >
> >
> > From: grass-dev <grass-dev-boun...@lists.osgeo.org> On Behalf Of Roberta
> > Fagandini
> > Sent: onsdag 16. mai 2018 16.01
> > To: Pierre Roudier <pierre.roud...@gmail.com>
> > Cc: grass-dev <grass-dev@lists.osgeo.org>
> > Subject: Re: [GRASS-dev] GSoC introduction Roberta Fagandini
> >
> >
> >
> >
> >
> > Thank you, Pierre!! I will keep the community constantly updated on the
> > progress of the module.
> >
> > Every feedback is welcome so please do not hesitate to send me yours! ;)
> >
> >
> >
> > Roberta
> >
> >
> >
> > 2018-05-15 23:46 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:
> >
> > Interesting to hear your results, Roberta -- the reason I brought this
> > up is that some of my colleagues (non-GRASS users :( ) tried it very
> > successfully.
> >
> > Happy to follow up with them if need be,
> >
> > P
> >
> >
> > On 15 May 2018 at 22:03, Roberta Fagandini <robifagand...@gmail.com>
> wrote:
> >> Hi Pierre!
> >> Thank you so much for your hints!
> >> I have already tested Fmask with Sentinel 2 images but I didn't have
> great
> >> results. However, it is worth investigating better!
> >> Thanks for all the references!
> >>
> >> Roberta
> >>
> >>
> >> 2018-05-15 0:51 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:
> >>>
> >>> Hi Roberta,
> >>>
> >>> On top of the review linked by Vero, I thought I'd mention the Fmask
> >>> procedure -- it seems to give great results and there is a python
> >>> library on Github.
> >>>
> >>> *Relevant GRASS GIS tickets*:
> >>>
> >>> https://trac.osgeo.org/grass/ticket/3473
> >>> https://trac.osgeo.org/grass/ticket/3283
> >>>
> >>> *Papers*:
> >>>
> >>>
> >>>
> >>> https://www.researchgate.net/publication/270596187_
> Improvement_and_expansion_of_the_Fmask_algorithm_Cloud_
> cloud_shadow_and_snow_detection_for_Landsats_4-7_8_and_Sentinel_2_images
> >>>
> >>>
> >>> https://www.researchgate.net/publication/324836341_
> Improvement_of_the_Fmask_algorithm_for_Sentinel-2_
> images_Separating_clouds_from_bright_surfaces_based_on_parallax_effects
> >>>
> >>> *Software*:
> >>>
> >>> http://pythonfmask.org/en/latest/
> >>> https://github.com/prs021/fmask
> >>>
> >>> Hopefully this is helpful,
> >>>
> >>> Pierre
> >>>
> >>> On 7 May 2018 at 19:49, Roberta Fagandini <robifagand...@gmail.com>
> >>> wrote:
> >>> >
> >>> >
> >>> > 2018-05-06 21:52 GMT+02:00 Veronica Andreo <veroand...@gmail.com>:
> >>> >>
> >>> >> Hey Robi,
> >>> >
> >>> >
> >>> > Hi Vero!!
> >>> >
> >>> >>
> >>> >>
> >>> >> I just found this review [0]. It is for Landsat, but maybe some
> >>> >> insights
> >>> >> could be also useful for you (?)
> >>> >
> >>> >
> >>> > Thank you so much! I know this paper and it could be very useful
> >>> > especially
> >>> > for the second part of the 

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Stefan!!

2018-05-16 16:22 GMT+02:00 Stefan Blumentrath <stefan.blumentr...@nina.no>:

> Hi Roberta,
>
>
>
> Here in Norway we can do some “worst case” testing for your algorithm.
> Plenty of snow and clouds in the mountains, and heavily rugged terrain,
> that presumably has quite some effect on cloud shadows…
>

Thank you so much!!
The cases you describe are "the best cases" for me, clouds and snow are
hard to distinguish and shadows are strongly dependent on land use/cover.
Now I'm working on the python script, as soon as it is ready I will share
it with the community and commit it to my GitHub repository [0]


>
> Looking forward to following your project from the side!
>

If you want you can follow the project progress on my wiki page [1]


>
>
> Kind regards,
>
> Stefan
>

Keep in touch!
best wishes

Roberta

[0] https://github.com/RobiFag/GRASS_clouds_and_shadows
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection



>
>
>
>
> *From:* grass-dev <grass-dev-boun...@lists.osgeo.org> *On Behalf Of *Roberta
> Fagandini
> *Sent:* onsdag 16. mai 2018 16.01
> *To:* Pierre Roudier <pierre.roud...@gmail.com>
> *Cc:* grass-dev <grass-dev@lists.osgeo.org>
> *Subject:* Re: [GRASS-dev] GSoC introduction Roberta Fagandini
>
>
>
>
>
> Thank you, Pierre!! I will keep the community constantly updated on the
> progress of the module.
>
> Every feedback is welcome so please do not hesitate to send me yours! ;)
>
>
>
> Roberta
>
>
>
> 2018-05-15 23:46 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:
>
> Interesting to hear your results, Roberta -- the reason I brought this
> up is that some of my colleagues (non-GRASS users :( ) tried it very
> successfully.
>
> Happy to follow up with them if need be,
>
> P
>
>
> On 15 May 2018 at 22:03, Roberta Fagandini <robifagand...@gmail.com>
> wrote:
> > Hi Pierre!
> > Thank you so much for your hints!
> > I have already tested Fmask with Sentinel 2 images but I didn't have
> great
> > results. However, it is worth investigating better!
> > Thanks for all the references!
> >
> > Roberta
> >
> >
> > 2018-05-15 0:51 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:
> >>
> >> Hi Roberta,
> >>
> >> On top of the review linked by Vero, I thought I'd mention the Fmask
> >> procedure -- it seems to give great results and there is a python
> >> library on Github.
> >>
> >> *Relevant GRASS GIS tickets*:
> >>
> >> https://trac.osgeo.org/grass/ticket/3473
> >> https://trac.osgeo.org/grass/ticket/3283
> >>
> >> *Papers*:
> >>
> >>
> >> https://www.researchgate.net/publication/270596187_Improveme
> nt_and_expansion_of_the_Fmask_algorithm_Cloud_cloud_shadow_
> and_snow_detection_for_Landsats_4-7_8_and_Sentinel_2_images
> >>
> >> https://www.researchgate.net/publication/324836341_Improveme
> nt_of_the_Fmask_algorithm_for_Sentinel-2_images_Separating_
> clouds_from_bright_surfaces_based_on_parallax_effects
> >>
> >> *Software*:
> >>
> >> http://pythonfmask.org/en/latest/
> >> https://github.com/prs021/fmask
> >>
> >> Hopefully this is helpful,
> >>
> >> Pierre
> >>
> >> On 7 May 2018 at 19:49, Roberta Fagandini <robifagand...@gmail.com>
> wrote:
> >> >
> >> >
> >> > 2018-05-06 21:52 GMT+02:00 Veronica Andreo <veroand...@gmail.com>:
> >> >>
> >> >> Hey Robi,
> >> >
> >> >
> >> > Hi Vero!!
> >> >
> >> >>
> >> >>
> >> >> I just found this review [0]. It is for Landsat, but maybe some
> >> >> insights
> >> >> could be also useful for you (?)
> >> >
> >> >
> >> > Thank you so much! I know this paper and it could be very useful
> >> > especially
> >> > for the second part of the procedure.
> >> > I'll read it carefully!
> >> >
> >> >>
> >> >>
> >> >> Cheers :),
> >> >> Vero
> >> >
> >> >
> >> > Thanks!
> >> > Robi
> >> >
> >> >>
> >> >>
> >> >> [0]
> >> >>
> >> >> https://www.researchgate.net/publication/324975294_Cloud_and
> _Cloud_Shadow_Detection_for_Landsat_Images_The_Fundamental
> _Basis_for_Analyzing_Landsat_Time_Series
> >> &g

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Thank you, Pierre!! I will keep the community constantly updated on the
progress of the module.
Every feedback is welcome so please do not hesitate to send me yours! ;)

Roberta

2018-05-15 23:46 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:

> Interesting to hear your results, Roberta -- the reason I brought this
> up is that some of my colleagues (non-GRASS users :( ) tried it very
> successfully.
>
> Happy to follow up with them if need be,
>
> P
>
> On 15 May 2018 at 22:03, Roberta Fagandini <robifagand...@gmail.com>
> wrote:
> > Hi Pierre!
> > Thank you so much for your hints!
> > I have already tested Fmask with Sentinel 2 images but I didn't have
> great
> > results. However, it is worth investigating better!
> > Thanks for all the references!
> >
> > Roberta
> >
> >
> > 2018-05-15 0:51 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:
> >>
> >> Hi Roberta,
> >>
> >> On top of the review linked by Vero, I thought I'd mention the Fmask
> >> procedure -- it seems to give great results and there is a python
> >> library on Github.
> >>
> >> *Relevant GRASS GIS tickets*:
> >>
> >> https://trac.osgeo.org/grass/ticket/3473
> >> https://trac.osgeo.org/grass/ticket/3283
> >>
> >> *Papers*:
> >>
> >>
> >> https://www.researchgate.net/publication/270596187_
> Improvement_and_expansion_of_the_Fmask_algorithm_Cloud_
> cloud_shadow_and_snow_detection_for_Landsats_4-7_8_and_Sentinel_2_images
> >>
> >> https://www.researchgate.net/publication/324836341_
> Improvement_of_the_Fmask_algorithm_for_Sentinel-2_
> images_Separating_clouds_from_bright_surfaces_based_on_parallax_effects
> >>
> >> *Software*:
> >>
> >> http://pythonfmask.org/en/latest/
> >> https://github.com/prs021/fmask
> >>
> >> Hopefully this is helpful,
> >>
> >> Pierre
> >>
> >> On 7 May 2018 at 19:49, Roberta Fagandini <robifagand...@gmail.com>
> wrote:
> >> >
> >> >
> >> > 2018-05-06 21:52 GMT+02:00 Veronica Andreo <veroand...@gmail.com>:
> >> >>
> >> >> Hey Robi,
> >> >
> >> >
> >> > Hi Vero!!
> >> >
> >> >>
> >> >>
> >> >> I just found this review [0]. It is for Landsat, but maybe some
> >> >> insights
> >> >> could be also useful for you (?)
> >> >
> >> >
> >> > Thank you so much! I know this paper and it could be very useful
> >> > especially
> >> > for the second part of the procedure.
> >> > I'll read it carefully!
> >> >
> >> >>
> >> >>
> >> >> Cheers :),
> >> >> Vero
> >> >
> >> >
> >> > Thanks!
> >> > Robi
> >> >
> >> >>
> >> >>
> >> >> [0]
> >> >>
> >> >> https://www.researchgate.net/publication/324975294_Cloud_
> and_Cloud_Shadow_Detection_for_Landsat_Images_The_Fundamental_Basis_for_
> Analyzing_Landsat_Time_Series
> >> >>
> >> >> El jue., 3 may. 2018 a las 22:06, Roberto Marzocchi
> >> >> (<roberto.marzoc...@gmail.com>) escribió:
> >> >>>
> >> >>> Nice! The last step of the script you have written in python works
> as
> >> >>> you
> >> >>> expected.
> >> >>>
> >> >>> Now it is important to draw a diagram (or schema ) as a summary for
> >> >>> you
> >> >>> (you have worked a lot in the last few months) and to share it with
> >> >>> Moritz
> >> >>> and Markus.
> >> >>>
> >> >>> After that, test, test and test ;-) for validation/calibration of
> the
> >> >>> automatic procedure.
> >> >>>
> >> >>> R
> >> >>>
> >> >>> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini
> >> >>> <robifagand...@gmail.com>:
> >> >>>>
> >> >>>>
> >> >>>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert
> >> >>>> <mlenn...@club.worldonline.be>:
> >> >>>>>
> >> >>>>> Hi Roberta,
> >> >>>>
> >> >>>>
> >> >>>> Hi Moritz and Roberto!
>

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Pierre!
Thank you so much for your hints!
I have already tested Fmask with Sentinel 2 images but I didn't have great
results. However, it is worth investigating better!
Thanks for all the references!

Roberta

2018-05-15 0:51 GMT+02:00 Pierre Roudier <pierre.roud...@gmail.com>:

> Hi Roberta,
>
> On top of the review linked by Vero, I thought I'd mention the Fmask
> procedure -- it seems to give great results and there is a python
> library on Github.
>
> *Relevant GRASS GIS tickets*:
>
> https://trac.osgeo.org/grass/ticket/3473
> https://trac.osgeo.org/grass/ticket/3283
>
> *Papers*:
>
> https://www.researchgate.net/publication/270596187_Improveme
> nt_and_expansion_of_the_Fmask_algorithm_Cloud_cloud_shadow_
> and_snow_detection_for_Landsats_4-7_8_and_Sentinel_2_images
> https://www.researchgate.net/publication/324836341_Improveme
> nt_of_the_Fmask_algorithm_for_Sentinel-2_images_Separating_
> clouds_from_bright_surfaces_based_on_parallax_effects
>
> *Software*:
>
> http://pythonfmask.org/en/latest/
> https://github.com/prs021/fmask
>
> Hopefully this is helpful,
>
> Pierre
>
> On 7 May 2018 at 19:49, Roberta Fagandini <robifagand...@gmail.com> wrote:
> >
> >
> > 2018-05-06 21:52 GMT+02:00 Veronica Andreo <veroand...@gmail.com>:
> >>
> >> Hey Robi,
> >
> >
> > Hi Vero!!
> >
> >>
> >>
> >> I just found this review [0]. It is for Landsat, but maybe some insights
> >> could be also useful for you (?)
> >
> >
> > Thank you so much! I know this paper and it could be very useful
> especially
> > for the second part of the procedure.
> > I'll read it carefully!
> >
> >>
> >>
> >> Cheers :),
> >> Vero
> >
> >
> > Thanks!
> > Robi
> >
> >>
> >>
> >> [0]
> >> https://www.researchgate.net/publication/324975294_Cloud_and
> _Cloud_Shadow_Detection_for_Landsat_Images_The_Fundamental
> _Basis_for_Analyzing_Landsat_Time_Series
> >>
> >> El jue., 3 may. 2018 a las 22:06, Roberto Marzocchi
> >> (<roberto.marzoc...@gmail.com>) escribió:
> >>>
> >>> Nice! The last step of the script you have written in python works as
> you
> >>> expected.
> >>>
> >>> Now it is important to draw a diagram (or schema ) as a summary for you
> >>> (you have worked a lot in the last few months) and to share it with
> Moritz
> >>> and Markus.
> >>>
> >>> After that, test, test and test ;-) for validation/calibration of the
> >>> automatic procedure.
> >>>
> >>> R
> >>>
> >>> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com
> >:
> >>>>
> >>>>
> >>>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert
> >>>> <mlenn...@club.worldonline.be>:
> >>>>>
> >>>>> Hi Roberta,
> >>>>
> >>>>
> >>>> Hi Moritz and Roberto!
> >>>>
> >>>>>
> >>>>>
> >>>>> On 25/04/18 18:03, Roberta Fagandini wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert
> >>>>>> <mlenn...@club.worldonline.be <mailto:mlenn...@club.worldonline.be
> >>:
> >>>>>> Looking at your bash scripts, I think the first thing to do
> during
> >>>>>> this bonding period is, as you planned yourself, to get familiar
> >>>>>> with the writing of GRASS modules in Python. You can have a look
> >>>>>> at
> >>>>>> existing scripts [1, 2] to get feeling for this works and how to
> >>>>>> structure addon code in order to make it directly installable
> with
> >>>>>> g.extension.
> >>>>>>
> >>>>>> You can find the actual function definitions and documentation
> of
> >>>>>> the GRASS Python scripting library at [3]. The functions in that
> >>>>>> library should be more than enough to translate your scripts
> into
> >>>>>> a
> >>>>>> (or several) modules.
> >>>>>>
> >>>>>> Be aware that GRASS modules create their own GUI. So, unless you
> >>>>>> need some interactive features in your modules, yo

[GRASS-dev] Bonding Period Report (R. Fagandini)

[Roberta Fagandini]

Hi all!
The bonding period was very useful for me.
I got in contact with my mentors and the dev list, set up both a wiki page
and a public repository, requested all the necessary write access and
familiarized myself with the scripting libraries.
Each step has been discussed and shared with my mentors and the dev list.

You can find the full report of my bonding period here [0] or on my wiki
page [1].

Best wishes,
Roberta


[0]
https://docs.google.com/document/d/177amKStJMCvbQMU8TneoR89So4AzlWGGH5co3s0dyWA/edit?usp=sharing
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC project for cloud and shadow detection - request of feedback

[Roberta Fagandini]

Hi all!

I'd like to share with you my GSoC project about an automatic procedure for
the detection of clouds and shadows in Sentinel 2 images.
I'm very interested in knowing what the community thinks of it, so any
suggestion, help, idea, opinion is welcome!

Below you can find the links to my GSoC proposal [0], wiki page [1]
and github repository [2].
Here's [3] the link to the workflow schema of the procedure
(unfortunately it is necessary to open it with a google drive app,
diagram.io [4], to see all the pages).

Thanks in advance for your time and feedback!

Roberta

[0]
https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
[1] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection
[2] https://github.com/RobiFag/GRASS_clouds_and_shadows
[3]
https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW80Z-7br81/view?usp=sharing
[4] http://diagram.io/
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

2018-05-09 13:04 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> On 09/05/18 12:46, Roberta Fagandini wrote:
>
>> Hi Moritz and Roberto!
>> As you may already know I sent the email to the PSC list asking for write
>> access to the GRASS-Addons-SVN repository.
>>
>
> Yes, thank you.
>
>
>> 2018-05-09 10:58 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>>:
>>
>> On 09/05/18 09:41, Roberto Marzocchi wrote:
>>
>> Hi Roberta and Moritz!
>>
>> SCHEMA: Roberta has already written the rules in the schema, but
>> I think you need to open it with a google drive app called
>> diagram.io <http://diagram.io> <http://diagram.io>
>>
>>
>> Right, a  lot of hoops to jump through to finally being able to see
>> it, but I got there. I'm not much of a user of Google services... ;-)
>>
>> This app is not so bad but if you know a better tool, please let me know
>> :-)
>>
>
> I don't know much in terms of online tools in general, so don't worry,
> just keeping using what works for you.
>
>
>>
>> But IMHO the schema would be more helpful if it contained the actual
>> rules. For example, in the cloud detection procedure, it says "First
>> rule: blue-green-red", but this does not provide the actual decision
>> rule. This would be helpful to have.
>>
>>
>> I have just added all the rules.
>>
>
> Thanks !
>
> Not sure I understand, though:
>
> (blue > 0.08(blue))
>
> will always be true. Or do you mean
>
> (blue > 0.08)
>
> ?
>
>
Sorry, I misspelled the rule..the right meaning is (blue > 0.08 *
max(blue)), I missed the max () function but I have already corrected the
schema.


>
> I would send the new email to the list if you agree.
>>
>
> +1
>
> Is there any keyword to be inserted in the mail subject in order to
>> require feedback or hints?
>>
>
> You should definitely start a new thread. Mention your project theme and
> explicitely state that it is a request for feedback.


Ok thank you, I'll send the email after lunch!

Roberta


>
>
> Moritz
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Moritz and Roberto!
As you may already know I sent the email to the PSC list asking for write
access to the GRASS-Addons-SVN repository.

2018-05-09 10:58 GMT+02:00 Moritz Lennert :

> On 09/05/18 09:41, Roberto Marzocchi wrote:
>
>> Hi Roberta and Moritz!
>>
>> SCHEMA: Roberta has already written the rules in the schema, but I think
>> you need to open it with a google drive app called diagram.io <
>> http://diagram.io>
>>
>
> Right, a  lot of hoops to jump through to finally being able to see it,
> but I got there. I'm not much of a user of Google services... ;-)
>

This app is not so bad but if you know a better tool, please let me know :-)


>
> But IMHO the schema would be more helpful if it contained the actual
> rules. For example, in the cloud detection procedure, it says "First rule:
> blue-green-red", but this does not provide the actual decision rule. This
> would be helpful to have.


I have just added all the rules. I would send the new email to the list if
you agree. Is there any keyword to be inserted in the mail subject in order
to require feedback or hints?

Thanks!
Roberta


>
>
> Moritz
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Moritz and Roberto!
Here [0] you can find the updated version of the project wiki page!
Tomorrow I'll better detail the procedure schema and then I'll share
everything with the grass dev list asking for feedback.
At the same time, I want to follow the procedure for access to the
GRASS-Addons-SVN repository (maybe another thing to do during the bonding
period ).

Roberta

[0] https://trac.osgeo.org/grass/wiki/GSoC/2018/CloudsAndShadowsDetection

2018-05-08 13:42 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> On 08/05/18 13:38, Roberta Fagandini wrote:
>
>>
>>
>> 2018-05-08 9:59 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>>:
>> Thanks ! I think the most interesting part would actually be the
>> details of the two detection procedures, so it would be good to
>> detail them :-).
>>
>>
>> Yes, I will add all the rules from the procedure file. Then I'd like to
>> send a new mail with all the links related to the project (wiki, github and
>> schema) to the grass dev list asking for feedback, hints, etc. What do you
>> think?
>>
>
>
> Good idea.
>
> :-)
>
> Moritz
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

2018-05-08 9:59 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> Hi Roberta,


Hi Moritz!

>
>
> On 07/05/18 18:00, Roberta Fagandini wrote:
>
>> Hi Moritz and Roberto!
>> Here [0] you can find the schema of the algorithm!
>>
>
> Thanks ! I think the most interesting part would actually be the details
> of the two detection procedures, so it would be good to detail them :-).
>

Yes, I will add all the rules from the procedure file. Then I'd like to
send a new mail with all the links related to the project (wiki, github and
schema) to the grass dev list asking for feedback, hints, etc. What do you
think?


>
> And I see that you have committed a first python script as well. Great !


Yes, but it's only a test ;-) since I have to get familiar with the GRASS
Python scripting library, I tried to do something that could be useful
during the coding period.


>
>> I committed [1] the first results of the procedure. In this case, I used
>> the image S2A_MSIL1C_20171025T095101_N0206_R079_T33SVB_20171025T134153
>> (Sicily). I have already tested the procedure using other two or three
>> images but I want to keep on testing!
>> If you have any suggestions about the testing phase please let me know!
>> As I wrote in another mail, I have the intention of trying out the
>> procedure using several images sensed in different seasons, latitude, etc.
>>
>
> For GSoC, don't forget that you are in bonding period right now, so IMHO
> the most important is to get the schema out and discuss it with the
> community and to familiarize yourself with GRASS programming. Now that you
> have managed to program a Python script, you should look into how to make
> this into a module, i.e. how to use the parser instructions, how to create
> a Makefile and things like that.


> The actual coding and testing of results can come during coding period
> starting next week.
>

You are right and I will investigate all these issues in the next days!
Today I want to update my wiki page with more details especially about the
timeline (as requested in the soc-list).


> Best wishes,
> Moritz
>

Best wishes,
Roberta


>
>
>
>> Best wishes
>> Roberta
>>
>> [0] https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW80Z-
>> 7br81/view?usp=sharing
>> [1] https://github.com/RobiFag/GRASS_clouds_and_shadows
>>
>>
>> 2018-05-03 22:06 GMT+02:00 Roberto Marzocchi <roberto.marzoc...@gmail.com
>> <mailto:roberto.marzoc...@gmail.com>>:
>>
>> Nice! The last step of the script you have written in python works
>> as you expected.
>>
>> Now it is important to draw a diagram (or schema ) as a summary for
>>     you (you have worked a lot in the last few months) and to share it
>> with Moritz and Markus.
>>
>> After that, test, test and test ;-) for validation/calibration of
>> the automatic procedure.
>>
>> R
>>
>> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini
>> <robifagand...@gmail.com <mailto:robifagand...@gmail.com>>:
>>
>>
>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert
>> <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>>:
>>
>> Hi Roberta,
>>
>>
>> Hi Moritz and Roberto!
>>
>>
>> On 25/04/18 18:03, Roberta Fagandini wrote:
>>
>>
>>
>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert
>> <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>
>> <mailto:mlenn...@club.worldonline.be
>>
>> <mailto:mlenn...@club.worldonline.be>>>:
>>  Looking at your bash scripts, I think the first
>> thing to do during
>>  this bonding period is, as you planned yourself, to
>> get familiar
>>  with the writing of GRASS modules in Python. You
>> can have a look at
>>  existing scripts [1, 2] to get feeling for this
>> works and how to
>>  structure addon code in order to make it directly
>> installable with
>>  g.extension.
>>
>>  You can find the actual function definitions and
>> documentation of
>>  the GRASS Python scripting library at [3]. The
>> functions in that
>>  library should be more t

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Moritz and Roberto!
Here [0] you can find the schema of the algorithm!

I committed [1] the first results of the procedure. In this case, I used
the image S2A_MSIL1C_20171025T095101_N0206_R079_T33SVB_20171025T134153
(Sicily). I have already tested the procedure using other two or three
images but I want to keep on testing!
If you have any suggestions about the testing phase please let me know! As
I wrote in another mail, I have the intention of trying out the procedure
using several images sensed in different seasons, latitude, etc.

Best wishes
Roberta

[0]
https://drive.google.com/file/d/1KYEKvNBurBFHw1xUTLjM0PW80Z-7br81/view?usp=sharing
[1] https://github.com/RobiFag/GRASS_clouds_and_shadows


2018-05-03 22:06 GMT+02:00 Roberto Marzocchi <roberto.marzoc...@gmail.com>:

> Nice! The last step of the script you have written in python works as you
> expected.
>
> Now it is important to draw a diagram (or schema ) as a summary for you (you
> have worked a lot in the last few months) and to share it with Moritz and
> Markus.
>
> After that, test, test and test ;-) for validation/calibration of the
> automatic procedure.
>
> R
>
> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com>:
>
>>
>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:
>>
>>> Hi Roberta,
>>>
>>
>> Hi Moritz and Roberto!
>>
>>
>>>
>>> On 25/04/18 18:03, Roberta Fagandini wrote:
>>>
>>>>
>>>>
>>>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be
>>>> <mailto:mlenn...@club.worldonline.be>>:
>>>> Looking at your bash scripts, I think the first thing to do during
>>>> this bonding period is, as you planned yourself, to get familiar
>>>> with the writing of GRASS modules in Python. You can have a look at
>>>> existing scripts [1, 2] to get feeling for this works and how to
>>>> structure addon code in order to make it directly installable with
>>>> g.extension.
>>>>
>>>> You can find the actual function definitions and documentation of
>>>> the GRASS Python scripting library at [3]. The functions in that
>>>> library should be more than enough to translate your scripts into a
>>>> (or several) modules.
>>>>
>>>> Be aware that GRASS modules create their own GUI. So, unless you
>>>> need some interactive features in your modules, you will not have to
>>>> program your own GUI.
>>>>
>>>>
>>>> Thank you for your precious suggestions! I'll start studying how to
>>>> write a GRASS module in Python in the next days and at the same time I will
>>>> keep on testing the procedures so as to show you some results and fix some
>>>> open points.
>>>>
>>>>
>>>> Something else you should probably do during this bonding time is to
>>>> elaborate a schema of your algorithm, so that it is easier to
>>>> understand what it does at each step.
>>>>
>>>>
>>>> Yes, this could be very useful also for me in order to better organize
>>>> and put in order everything!
>>>>
>>>>
>>> Have you advanced on any of this ? Do you have any questions ? Please
>>> don't hesitate to ask on the mailing list.
>>>
>>
>> Yes, I started working with GRASS Python scripting library. I'm following
>> the link [0] you suggested, I'm also looking at other existing GRASS
>> scripts [1,2] and moreover, Roberto gave me one of his scripts as an
>> example. I have just committed the first version of the python script I'm
>> working on, it works and I'm quite satisfied ;-)
>> Tomorrow I want to elaborate the schema of the algorithm and at the same
>> time, I have to keep testing the procedure. As I wrote in the bash file,
>> shadows detection seems to be strongly land cover dependent therefore I
>> think it is necessary to test the procedure using several images sensed in
>> different seasons, latitude, etc.
>>
>> Anyway, I'll commit some results tomorrow so as to show you something
>> more concrete!
>>
>>>
>>> Best wishes,
>>> Moritz
>>>
>>
>> Best regards,
>> Roberta
>>
>> [0] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
>> [1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
>> [2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
>>
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

2018-05-06 21:52 GMT+02:00 Veronica Andreo <veroand...@gmail.com>:

> Hey Robi,
>

Hi Vero!!


>
> I just found this review [0]. It is for Landsat, but maybe some insights
> could be also useful for you (?)
>

Thank you so much! I know this paper and it could be very useful especially
for the second part of the procedure.
I'll read it carefully!


>
> Cheers :),
> Vero
>

Thanks!
Robi


>
> [0] https://www.researchgate.net/publication/324975294_Cloud_
> and_Cloud_Shadow_Detection_for_Landsat_Images_The_Fundamental_Basis_for_
> Analyzing_Landsat_Time_Series
>
> El jue., 3 may. 2018 a las 22:06, Roberto Marzocchi (<
> roberto.marzoc...@gmail.com>) escribió:
>
>> Nice! The last step of the script you have written in python works as you
>> expected.
>>
>> Now it is important to draw a diagram (or schema ) as a summary for you (you
>> have worked a lot in the last few months) and to share it with Moritz
>> and Markus.
>>
>> After that, test, test and test ;-) for validation/calibration of the
>> automatic procedure.
>>
>> R
>>
>> 2018-05-03 18:48 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com>:
>>
>>>
>>> 2018-05-03 14:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>
>>> :
>>>
>>>> Hi Roberta,
>>>>
>>>
>>> Hi Moritz and Roberto!
>>>
>>>
>>>>
>>>> On 25/04/18 18:03, Roberta Fagandini wrote:
>>>>
>>>>>
>>>>>
>>>>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert <
>>>>> mlenn...@club.worldonline.be <mailto:mlenn...@club.worldonline.be>>:
>>>>> Looking at your bash scripts, I think the first thing to do during
>>>>> this bonding period is, as you planned yourself, to get familiar
>>>>> with the writing of GRASS modules in Python. You can have a look at
>>>>> existing scripts [1, 2] to get feeling for this works and how to
>>>>> structure addon code in order to make it directly installable with
>>>>> g.extension.
>>>>>
>>>>> You can find the actual function definitions and documentation of
>>>>> the GRASS Python scripting library at [3]. The functions in that
>>>>> library should be more than enough to translate your scripts into a
>>>>> (or several) modules.
>>>>>
>>>>> Be aware that GRASS modules create their own GUI. So, unless you
>>>>> need some interactive features in your modules, you will not have
>>>>> to
>>>>> program your own GUI.
>>>>>
>>>>>
>>>>> Thank you for your precious suggestions! I'll start studying how to
>>>>> write a GRASS module in Python in the next days and at the same time I 
>>>>> will
>>>>> keep on testing the procedures so as to show you some results and fix some
>>>>> open points.
>>>>>
>>>>>
>>>>> Something else you should probably do during this bonding time is
>>>>> to
>>>>> elaborate a schema of your algorithm, so that it is easier to
>>>>> understand what it does at each step.
>>>>>
>>>>>
>>>>> Yes, this could be very useful also for me in order to better organize
>>>>> and put in order everything!
>>>>>
>>>>>
>>>> Have you advanced on any of this ? Do you have any questions ? Please
>>>> don't hesitate to ask on the mailing list.
>>>>
>>>
>>> Yes, I started working with GRASS Python scripting library. I'm
>>> following the link [0] you suggested, I'm also looking at other existing
>>> GRASS scripts [1,2] and moreover, Roberto gave me one of his scripts as an
>>> example. I have just committed the first version of the python script I'm
>>> working on, it works and I'm quite satisfied ;-)
>>> Tomorrow I want to elaborate the schema of the algorithm and at the same
>>> time, I have to keep testing the procedure. As I wrote in the bash file,
>>> shadows detection seems to be strongly land cover dependent therefore I
>>> think it is necessary to test the procedure using several images sensed in
>>> different seasons, latitude, etc.
>>>
>>> Anyway, I'll commit some results tomorrow so as to show you something
>>> more concrete!
>>>
>>>>
>>>> Best wishes,
>>>> Moritz
>>>>
>>>
>>> Best regards,
>>> Roberta
>>>
>>> [0] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
>>> [1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
>>> [2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
>>>
>>
>> ___
>> grass-dev mailing list
>> grass-dev@lists.osgeo.org
>> https://lists.osgeo.org/mailman/listinfo/grass-dev
>
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

2018-05-03 14:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> Hi Roberta,
>

Hi Moritz and Roberto!


>
> On 25/04/18 18:03, Roberta Fagandini wrote:
>
>>
>>
>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>>:
>> Looking at your bash scripts, I think the first thing to do during
>> this bonding period is, as you planned yourself, to get familiar
>> with the writing of GRASS modules in Python. You can have a look at
>> existing scripts [1, 2] to get feeling for this works and how to
>> structure addon code in order to make it directly installable with
>> g.extension.
>>
>> You can find the actual function definitions and documentation of
>> the GRASS Python scripting library at [3]. The functions in that
>> library should be more than enough to translate your scripts into a
>> (or several) modules.
>>
>> Be aware that GRASS modules create their own GUI. So, unless you
>> need some interactive features in your modules, you will not have to
>> program your own GUI.
>>
>>
>> Thank you for your precious suggestions! I'll start studying how to write
>> a GRASS module in Python in the next days and at the same time I will keep
>> on testing the procedures so as to show you some results and fix some open
>> points.
>>
>>
>> Something else you should probably do during this bonding time is to
>> elaborate a schema of your algorithm, so that it is easier to
>> understand what it does at each step.
>>
>>
>> Yes, this could be very useful also for me in order to better organize
>> and put in order everything!
>>
>>
> Have you advanced on any of this ? Do you have any questions ? Please
> don't hesitate to ask on the mailing list.
>

Yes, I started working with GRASS Python scripting library. I'm following
the link [0] you suggested, I'm also looking at other existing GRASS
scripts [1,2] and moreover, Roberto gave me one of his scripts as an
example. I have just committed the first version of the python script I'm
working on, it works and I'm quite satisfied ;-)
Tomorrow I want to elaborate the schema of the algorithm and at the same
time, I have to keep testing the procedure. As I wrote in the bash file,
shadows detection seems to be strongly land cover dependent therefore I
think it is necessary to test the procedure using several images sensed in
different seasons, latitude, etc.

Anyway, I'll commit some results tomorrow so as to show you something more
concrete!

>
> Best wishes,
> Moritz
>

Best regards,
Roberta

[0] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
[1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
[2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi all!
Here [0] you can find the GSoC project wiki page!

Have a nice weekend!

Roberta

[0] https://trac.osgeo.org/grass/wiki/GSoC

2018-04-26 15:37 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com>:

> Hi all!
> I requested the right OSGeo user id and now I can log in and set up a wiki
> page for the project.
>
> Regarding the development, I'll use github for now but at the same time I
> can follow the procedure for access to the GRASS-Addons-SVN repository.
>
> Thank you for your suggestions!
>
> Roberta
>
> 2018-04-26 14:27 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:
>
>> On 26/04/18 12:59, Roberto Marzocchi wrote:
>>
>>> Your OSGeo_id is "Robifag".
>>>
>>> I give you write access to SVN add-ons GRASS repository, but I do not
>>> know how to give you access to trac system.
>>>
>>
>> Please note that for access to the add-ons SVN, Roberta has to officially
>> state in a mail to the PSC list that she has read and abides to RFC2 [1]
>> (see [2] for more info).
>>
>> I would suggest to develop in github for now and move to addons could
>> then be done once the module is ripe. Or, as said earlier, to use the SVN
>> sandbox for developing.
>>
>> Moritz
>>
>>
>>
>> [1] https://trac.osgeo.org/grass/wiki/RFC/2_LegalAspectsOfCodeCo
>> ntributions
>> [2] https://trac.osgeo.org/grass/wiki/HowToContribute#Writeacces
>> stotheGRASS-Addons-SVNrepository
>>
>>
>>> R
>>>
>>> 2018-04-26 12:56 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com
>>> <mailto:robifagand...@gmail.com>>:
>>>
>>> Hi Moritz and Roberto,
>>> I'm trying to set up the wiki page but I can't access the site [0]
>>> using my OSGeo user id.
>>>
>>> Can you help me?
>>>
>>> Thanks,
>>> Roberta
>>>
>>>
>>> [0] https://trac.osgeo.org/grass/wiki
>>> <https://trac.osgeo.org/grass/wiki>
>>>
>>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert
>>> <mlenn...@club.worldonline.be <mailto:mlenn...@club.worldonline.be
>>> >>:
>>>
>>> Hi Roberta,
>>>
>>> On 24/04/18 13:55, Roberta Fagandini wrote:
>>>
>>> 2018-04-24 13:15 GMT+02:00 Moritz Lennert
>>> <mlenn...@club.worldonline.be
>>> <mailto:mlenn...@club.worldonline.be>
>>> <mailto:mlenn...@club.worldonline.be
>>>
>>> <mailto:mlenn...@club.worldonline.be>>>:
>>>
>>>
>>>  Hi Roberta,
>>>
>>>
>>> Hi Moritz!
>>>
>>>
>>>  On 24/04/18 13:01, Roberta Fagandini wrote:
>>>
>>>  Hi all!
>>>  I'm Roberta Fagandini, Ph.D. student at Politecnico
>>> of Milano.
>>>  My proposal "GRASS GIS module for Sentinel-2 cloud
>>> and shadow
>>>  detection" has been accepted therefore I've been
>>> selected for
>>>  the GSoC 2018.
>>>  I'm glad to start contributing to OSGeo and
>>> especially to GRASS
>>>  GIS with the help of my mentors Roberto Marzocchi
>>> and Moritz
>>>  Lennert.
>>>
>>>  My project consists in the realization of a GRASS
>>> GIS module for
>>>  the detection of clouds and their shadows in
>>> Sentinel-2 images
>>>  without using time series.
>>>  Below you can find the link to my proposal:
>>>
>>> https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1
>>> eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>>> <https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc
>>> 1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing>
>>> <https://docs.google.com/docum
>>> ent/d/1mQyouqbHGHugn5DjEDZI3hc1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>>> <https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc
>>> 1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing>>
>>>
>>>  I would be grateful if you c

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi all!
I requested the right OSGeo user id and now I can log in and set up a wiki
page for the project.

Regarding the development, I'll use github for now but at the same time I
can follow the procedure for access to the GRASS-Addons-SVN repository.

Thank you for your suggestions!

Roberta

2018-04-26 14:27 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> On 26/04/18 12:59, Roberto Marzocchi wrote:
>
>> Your OSGeo_id is "Robifag".
>>
>> I give you write access to SVN add-ons GRASS repository, but I do not
>> know how to give you access to trac system.
>>
>
> Please note that for access to the add-ons SVN, Roberta has to officially
> state in a mail to the PSC list that she has read and abides to RFC2 [1]
> (see [2] for more info).
>
> I would suggest to develop in github for now and move to addons could then
> be done once the module is ripe. Or, as said earlier, to use the SVN
> sandbox for developing.
>
> Moritz
>
>
>
> [1] https://trac.osgeo.org/grass/wiki/RFC/2_LegalAspectsOfCodeCo
> ntributions
> [2] https://trac.osgeo.org/grass/wiki/HowToContribute#Writeacces
> stotheGRASS-Addons-SVNrepository
>
>
>> R
>>
>> 2018-04-26 12:56 GMT+02:00 Roberta Fagandini <robifagand...@gmail.com
>> <mailto:robifagand...@gmail.com>>:
>>
>> Hi Moritz and Roberto,
>> I'm trying to set up the wiki page but I can't access the site [0]
>> using my OSGeo user id.
>>
>> Can you help me?
>>
>> Thanks,
>> Roberta
>>
>>
>> [0] https://trac.osgeo.org/grass/wiki
>> <https://trac.osgeo.org/grass/wiki>
>>
>> 2018-04-25 16:03 GMT+02:00 Moritz Lennert
>> <mlenn...@club.worldonline.be <mailto:mlenn...@club.worldonline.be>>:
>>
>> Hi Roberta,
>>
>> On 24/04/18 13:55, Roberta Fagandini wrote:
>>
>> 2018-04-24 13:15 GMT+02:00 Moritz Lennert
>> <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>
>>     <mailto:mlenn...@club.worldonline.be
>>
>> <mailto:mlenn...@club.worldonline.be>>>:
>>
>>
>>  Hi Roberta,
>>
>>
>> Hi Moritz!
>>
>>
>>  On 24/04/18 13:01, Roberta Fagandini wrote:
>>
>>  Hi all!
>>  I'm Roberta Fagandini, Ph.D. student at Politecnico
>> of Milano.
>>  My proposal "GRASS GIS module for Sentinel-2 cloud
>> and shadow
>>  detection" has been accepted therefore I've been
>> selected for
>>  the GSoC 2018.
>>  I'm glad to start contributing to OSGeo and
>> especially to GRASS
>>  GIS with the help of my mentors Roberto Marzocchi
>> and Moritz
>>  Lennert.
>>
>>  My project consists in the realization of a GRASS
>> GIS module for
>>  the detection of clouds and their shadows in
>> Sentinel-2 images
>>  without using time series.
>>  Below you can find the link to my proposal:
>>
>> https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1
>> eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>> <https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc
>> 1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing>
>> <https://docs.google.com/docum
>> ent/d/1mQyouqbHGHugn5DjEDZI3hc1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>> <https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc
>> 1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing>>
>>
>>  I would be grateful if you could have a look at the
>> proposal and
>>  provide any suggestions.
>>  Every feedback is welcome and it will be useful to
>> improve my
>>  project.
>>
>>  I'm waiting for the writing access to the OSGeo
>> wiki, therefore,
>>  I will share my wiky page as soon as possible.
>>
>>  Thanks for this great opportunity!
>>
>>
>>  It is great to have you with us ! I'm looking forward
>> to working
>>  with you on 

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi Moritz and Roberto,
I'm trying to set up the wiki page but I can't access the site [0] using my
OSGeo user id.

Can you help me?

Thanks,
Roberta


[0] https://trac.osgeo.org/grass/wiki

2018-04-25 16:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> Hi Roberta,
>
> On 24/04/18 13:55, Roberta Fagandini wrote:
>
>> 2018-04-24 13:15 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>>:
>>
>>
>> Hi Roberta,
>>
>>
>> Hi Moritz!
>>
>>
>> On 24/04/18 13:01, Roberta Fagandini wrote:
>>
>> Hi all!
>> I'm Roberta Fagandini, Ph.D. student at Politecnico of Milano.
>> My proposal "GRASS GIS module for Sentinel-2 cloud and shadow
>> detection" has been accepted therefore I've been selected for
>> the GSoC 2018.
>> I'm glad to start contributing to OSGeo and especially to GRASS
>> GIS with the help of my mentors Roberto Marzocchi and Moritz
>> Lennert.
>>
>> My project consists in the realization of a GRASS GIS module for
>> the detection of clouds and their shadows in Sentinel-2 images
>> without using time series.
>> Below you can find the link to my proposal:
>>
>> https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1
>> eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>> <https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc
>> 1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing>
>>
>> I would be grateful if you could have a look at the proposal and
>> provide any suggestions.
>> Every feedback is welcome and it will be useful to improve my
>> project.
>>
>> I'm waiting for the writing access to the OSGeo wiki, therefore,
>> I will share my wiky page as soon as possible.
>>
>> Thanks for this great opportunity!
>>
>>
>> It is great to have you with us ! I'm looking forward to working
>> with you on this project.
>>
>>
>> First of all I want to thank you for being my mentor!
>>
>> The first thing I would love to see is your existing python script
>> to get a better understanding of the exact approach you are planning
>> on implementing.
>>
>>
>> Depending on what tool you prefer, you can either set up a github
>> repository for the project, or you could also use the sandbox in the
>> GRASS svn [1]. You could then share your code there.
>>
>>
>> A the moment I have only some bash script. I'm testing different
>> procedures for shadows detection, which is the task that is creating more
>> troubles at the moment.  Anyway, I already had the intention of setting up
>> a github repository for the project therefore, I hope to share it as soon
>> as possible.
>>
>>
>
> Please also set up a wiki page about your project. See [0] for examples
> from last year.
>
> Looking at your bash scripts, I think the first thing to do during this
> bonding period is, as you planned yourself, to get familiar with the
> writing of GRASS modules in Python. You can have a look at existing scripts
> [1, 2] to get feeling for this works and how to structure addon code in
> order to make it directly installable with g.extension.
>
> You can find the actual function definitions and documentation of the
> GRASS Python scripting library at [3]. The functions in that library should
> be more than enough to translate your scripts into a (or several) modules.
>
> Be aware that GRASS modules create their own GUI. So, unless you need some
> interactive features in your modules, you will not have to program your own
> GUI.
>
> Something else you should probably do during this bonding time is to
> elaborate a schema of your algorithm, so that it is easier to understand
> what it does at each step.
>
> Best wishes,
> Moritz
>
>
> [0] https://trac.osgeo.org/grass/wiki/GSoC
> [1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
> [2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
> [3] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

2018-04-25 16:03 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> Hi Roberta,


Hi Moritz,


>
> On 24/04/18 13:55, Roberta Fagandini wrote:
>
>> 2018-04-24 13:15 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be
>> <mailto:mlenn...@club.worldonline.be>>:
>>
>>
>> Hi Roberta,
>>
>>
>> Hi Moritz!
>>
>>
>> On 24/04/18 13:01, Roberta Fagandini wrote:
>>
>> Hi all!
>> I'm Roberta Fagandini, Ph.D. student at Politecnico of Milano.
>> My proposal "GRASS GIS module for Sentinel-2 cloud and shadow
>> detection" has been accepted therefore I've been selected for
>> the GSoC 2018.
>> I'm glad to start contributing to OSGeo and especially to GRASS
>> GIS with the help of my mentors Roberto Marzocchi and Moritz
>> Lennert.
>>
>> My project consists in the realization of a GRASS GIS module for
>> the detection of clouds and their shadows in Sentinel-2 images
>> without using time series.
>> Below you can find the link to my proposal:
>>
>> https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1
>> eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>> <https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc
>> 1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing>
>>
>> I would be grateful if you could have a look at the proposal and
>> provide any suggestions.
>> Every feedback is welcome and it will be useful to improve my
>> project.
>>
>> I'm waiting for the writing access to the OSGeo wiki, therefore,
>> I will share my wiky page as soon as possible.
>>
>> Thanks for this great opportunity!
>>
>>
>> It is great to have you with us ! I'm looking forward to working
>> with you on this project.
>>
>>
>> First of all I want to thank you for being my mentor!
>>
>> The first thing I would love to see is your existing python script
>> to get a better understanding of the exact approach you are planning
>> on implementing.
>>
>>
>> Depending on what tool you prefer, you can either set up a github
>> repository for the project, or you could also use the sandbox in the
>> GRASS svn [1]. You could then share your code there.
>>
>>
>> A the moment I have only some bash script. I'm testing different
>> procedures for shadows detection, which is the task that is creating more
>> troubles at the moment.  Anyway, I already had the intention of setting up
>> a github repository for the project therefore, I hope to share it as soon
>> as possible.
>>
>>
>
> Please also set up a wiki page about your project. See [0] for examples
> from last year.
>

Sure, tomorrow I'm going to set up the wiki page!


>
> Looking at your bash scripts, I think the first thing to do during this
> bonding period is, as you planned yourself, to get familiar with the
> writing of GRASS modules in Python. You can have a look at existing scripts
> [1, 2] to get feeling for this works and how to structure addon code in
> order to make it directly installable with g.extension.
>
> You can find the actual function definitions and documentation of the
> GRASS Python scripting library at [3]. The functions in that library should
> be more than enough to translate your scripts into a (or several) modules.
>
> Be aware that GRASS modules create their own GUI. So, unless you need some
> interactive features in your modules, you will not have to program your own
> GUI.
>

Thank you for your precious suggestions! I'll start studying how to write a
GRASS module in Python in the next days and at the same time I will keep on
testing the procedures so as to show you some results and fix some open
points.


>
> Something else you should probably do during this bonding time is to
> elaborate a schema of your algorithm, so that it is easier to understand
> what it does at each step.
>

Yes, this could be very useful also for me in order to better organize and
put in order everything!


>
> Best wishes,
> Moritz
>

Thanks again!
Best regards,
Roberta


>
>
> [0] https://trac.osgeo.org/grass/wiki/GSoC
> [1] https://trac.osgeo.org/grass/browser/grass/trunk/scripts
> [2] https://trac.osgeo.org/grass/browser/grass-addons/grass7
> [3] https://grass.osgeo.org/grass75/manuals/libpython/script_intro.html
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

2018-04-24 13:15 GMT+02:00 Moritz Lennert <mlenn...@club.worldonline.be>:

> Hi Roberta,


Hi Moritz!

>
> On 24/04/18 13:01, Roberta Fagandini wrote:
>
>> Hi all!
>> I'm Roberta Fagandini, Ph.D. student at Politecnico of Milano.
>> My proposal "GRASS GIS module for Sentinel-2 cloud and shadow detection"
>> has been accepted therefore I've been selected for the GSoC 2018.
>> I'm glad to start contributing to OSGeo and especially to GRASS GIS with
>> the help of my mentors Roberto Marzocchi and Moritz Lennert.
>>
>> My project consists in the realization of a GRASS GIS module for the
>> detection of clouds and their shadows in Sentinel-2 images without using
>> time series.
>> Below you can find the link to my proposal:
>>
>> https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1
>> eU_bT_b0qLJPPwkt_hk/edit?usp=sharing
>>
>> I would be grateful if you could have a look at the proposal and provide
>> any suggestions.
>> Every feedback is welcome and it will be useful to improve my project.
>>
>> I'm waiting for the writing access to the OSGeo wiki, therefore, I will
>> share my wiky page as soon as possible.
>>
>> Thanks for this great opportunity!
>>
>
> It is great to have you with us ! I'm looking forward to working with you
> on this project.
>

First of all I want to thank you for being my mentor!


> The first thing I would love to see is your existing python script to get
> a better understanding of the exact approach you are planning on
> implementing.


> Depending on what tool you prefer, you can either set up a github
> repository for the project, or you could also use the sandbox in the GRASS
> svn [1]. You could then share your code there.
>

A the moment I have only some bash script. I'm testing different procedures
for shadows detection, which is the task that is creating more troubles at
the moment.  Anyway, I already had the intention of setting up a github
repository for the project therefore, I hope to share it as soon as
possible.


>
> Moritz
>

Roberta

>
>
> [1] https://trac.osgeo.org/grass/browser/sandbox?order=name
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GSoC introduction Roberta Fagandini

[Roberta Fagandini]

Hi all!
I'm Roberta Fagandini, Ph.D. student at Politecnico of Milano.
My proposal "GRASS GIS module for Sentinel-2 cloud and shadow detection"
has been accepted therefore I've been selected for the GSoC 2018.
I'm glad to start contributing to OSGeo and especially to GRASS GIS with
the help of my mentors Roberto Marzocchi and Moritz Lennert.

My project consists in the realization of a GRASS GIS module for the
detection of clouds and their shadows in Sentinel-2 images without using
time series.
Below you can find the link to my proposal:

https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1eU_bT_b0qLJPPwkt_hk/edit?usp=sharing

I would be grateful if you could have a look at the proposal and provide
any suggestions.
Every feedback is welcome and it will be useful to improve my project.

I'm waiting for the writing access to the OSGeo wiki, therefore, I will
share my wiky page as soon as possible.

Thanks for this great opportunity!

Roberta Fagandini
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] GRASS GSoC 2018 proposal

[Roberta Fagandini]

Hi all!
I have already submitted a draft proposal (title: GRASS GIS module for
Sentinel-2 cloud and shadow detection) in response to the idea about cloud
masking published on the GRASS Google Summer of Code 2018 wiki page.
I'd like to share the propose with you [1].
Obviously, any hint/suggestion/feedback is welcome!

Roberta

[1] https://docs.google.com/document/d/1mQyouqbHGHugn5DjEDZI3hc1eU_
bT_b0qLJPPwkt_hk/edit?usp=sharing
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev