Re: [GRASS-dev] [GRASS-SVN] r70814 - grass-addons/grass7/raster/r.vif

2017-05-02 Thread Paulo van Breugel 


On 5/2/17 9:02 PM, Vaclav Petras wrote:


On Fri, Mar 31, 2017 at 8:56 AM, > wrote:


Author: pvanbosgeo
Date: 2017-03-31 05:56:38 -0700 (Fri, 31 Mar 2017)
New Revision: 70814

Modified:
   grass-addons/grass7/raster/r.vif/r.vif.html
   grass-addons/grass7/raster/r.vif/r.vif.py 
Log:
r.vif addon: computation of vif is now in Python, resulting in
strongly reduced computing times. There is an option to use a
random subsample of raster cells as input to further speed up the
computations. There is furthermore a 'low-memory' option (this is
the old implementation which uses r.regression.multi).

...

 # import libraries
 import os
 import sys
 import math
 import numpy as np
-import grass.script as grass
+from scipy import stats


Hi Paulo,

it seems that the scipy is not used. I would just remove the line to 
make the module work on computers without scipy, but you may be still 
planning some changes, so I don't want to interfere. Please let me know.




Hi Vaclac, yes, you are right, a left-over from an earlier test version. 
I removed it, thanks!




Vaclav


--
Paulo van Breugel, PhD
t:  +31 6 12189147
s:  paulovb
w:  https://ecodiv.earth

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS-SVN] r70814 - grass-addons/grass7/raster/r.vif

2017-05-02 Thread Vaclav Petras 
On Fri, Mar 31, 2017 at 8:56 AM,  wrote:

> Author: pvanbosgeo
> Date: 2017-03-31 05:56:38 -0700 (Fri, 31 Mar 2017)
> New Revision: 70814
>
> Modified:
>grass-addons/grass7/raster/r.vif/r.vif.html
>grass-addons/grass7/raster/r.vif/r.vif.py
> Log:
> r.vif addon: computation of vif is now in Python, resulting in strongly
> reduced computing times. There is an option to use a random subsample of
> raster cells as input to further speed up the computations. There is
> furthermore a 'low-memory' option (this is the old implementation which
> uses r.regression.multi).
>
> ...
>
 # import libraries
>  import os
>  import sys
>  import math
>  import numpy as np
> -import grass.script as grass
> +from scipy import stats
>

Hi Paulo,

it seems that the scipy is not used. I would just remove the line to make
the module work on computers without scipy, but you may be still planning
some changes, so I don't want to interfere. Please let me know.

Vaclav
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev