Re: [GRASS-dev] Pull requests for new addon 'r.zonal.classes'
Hi Taïs, On Tue, Sep 24, 2019 at 8:05 AM tgrippa wrote: > On Mon, Sep 23, 2019 at 4:09 PM Taïs wrote: > I noticed the table in the manual page looks terribly bad > (https://grass.osgeo.org/grass76/manuals/addons/r.zonal.classes). I wasn't > expecting that... What do you suggest: is it unnecessary and should be > removed completely or should I make a print-screen of the attribute table and > integrate it as an image ? Not sure about image, how about simple ASCII in the section? best Markus ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] Pull requests for new addon 'r.zonal.classes'
Hi Taïs, On Mon, Sep 23, 2019 at 4:09 PM Taïs wrote: > > Hi Markus, > > Thanks for the review I committed all the changes you suggested + fix > the line length on the html file. > > I think it's ready to be merge. I have merged it but fixed it again, see: https://github.com/OSGeo/grass-addons/commit/666b1c8a69e6dd41f5b9ae418541c198bfdd699e Cheers Markus ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] Pull requests for new addon 'r.zonal.classes'
Hi Markus, Thanks for the review I committed all the changes you suggested + fix the line length on the html file. I think it's ready to be merge. Cheers Le 22/09/19 à 19:10, Markus Neteler a écrit : Dear Taïs, On Wed, Sep 11, 2019 at 11:28 AM Taïs Grippa wrote: Dear GRASS developers, For your information, I just made a pull request on the grass-addon repository: https://github.com/OSGeo/grass-addons/pull/28 This addon computes class proportions and majority class of a "cover layer" (e.g., a land cover map) according to how it intersects with areas/objects in a "base layer". This function is similar to what r.stats.zonal performs, but is intended to be used on integer values raster (CELL type) instead. Nice, thanks for your contribution. I made a minor review (see GH) with some editing. One wish: As per style guide (https://trac.osgeo.org/grass/wiki/Submitting/Docs) long lines in the HTML manual should be avoided, if possible, please reformat the file. thanks for your work, Markus <>___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] Pull requests for new addon 'r.zonal.classes'
Dear Taïs, On Wed, Sep 11, 2019 at 11:28 AM Taïs Grippa wrote: > > Dear GRASS developers, > > For your information, I just made a pull request on the grass-addon > repository: > > https://github.com/OSGeo/grass-addons/pull/28 > > This addon computes class proportions and majority class of a "cover layer" > (e.g., a land cover map) according to how it intersects with areas/objects in > a "base layer". This function is similar to what r.stats.zonal performs, but > is intended to be used on integer values raster (CELL type) instead. Nice, thanks for your contribution. I made a minor review (see GH) with some editing. One wish: As per style guide (https://trac.osgeo.org/grass/wiki/Submitting/Docs) long lines in the HTML manual should be avoided, if possible, please reformat the file. thanks for your work, Markus -- Markus Neteler, PhD https://www.mundialis.de - free data with free software https://grass.osgeo.org https://courses.neteler.org/blog ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] Pull requests for new addon 'r.zonal.classes'
Dear GRASS developers, For your information, I just made a pull request on the grass-addon repository: https://github.com/OSGeo/grass-addons/pull/28 This addon computes class proportions and majority class of a "cover layer" (e.g., a land cover map) according to how it intersects with areas/objects in a "base layer". This function is similar to what r.stats.zonal performs, but is intended to be used on integer values raster (CELL type) instead. Best, -- *M. GRIPPA Taïs* Geographer - PhD - ANAGEO Lab (IGEAT) ULB CP 130/03 Av. F.D. Roosevelt, 50 - 1050 Bruxelles Tél: 02/650.68.03 Mail: tais.gri...@ulb.ac.be ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
