Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-11-05 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  closed
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:  fixed|   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-
Changes (by annakrat):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Tested and backported in r69778 and r69779.

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-

Comment (by annakrat):

 Replying to [comment:13 mlennert]:
 > Replying to [comment:12 annakrat]:
 > > I applied the patch in r69607.
 >
 > Thanks. So it works ? ;-)
 >
 On Linux yes, I haven't tried yet on Windows. But I don't see why it
 wouldn't.

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-

Comment (by mlennert):

 Replying to [comment:12 annakrat]:
 > I applied the patch in r69607.

 Thanks. So it works ? ;-)

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-

Comment (by annakrat):

 I applied the patch in r69607.

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-

Comment (by mlennert):

 Replying to [comment:10 sbl]:
 > Confirmed on Win7.
 >
 > g.remove type=rast pattern=MASK -f does not remove a map "mask" on
 Windows, while
 > g.remove -fi type=rast pattern=MASK does.

 Ok. I've attached a patch that AFAICT should check for Windows and then
 make the g.remove call case insensitive.

 Please test.

 Moritz

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-
Changes (by mlennert):

 * Attachment "rmask_windows.diff" added.

 patch to make removal of 'MASK' raster map case insensitive on Windows

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-

Comment (by sbl):

 Confirmed on Win7.

 g.remove type=rast pattern=MASK -f does not remove a map "mask" on
 Windows, while
 g.remove -fi type=rast pattern=MASK does.

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2016-09-29 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
--+-
  Reporter:  baharmon |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.2.0
 Component:  Raster   |Version:  svn-trunk
Resolution:   |   Keywords:  r.mask
   CPU:  Unspecified  |   Platform:  MSWindows 8
--+-

Comment (by mlennert):

 Could anyone test this on Windows, i.e. create a raster file named mask
 (lowercase) and then attempt 'g.remove type=rast pattern=MASK -f' and
 'g.remove -i type=rast pattern=MASK' ?

 And if the first doesn't work, but the second does could the following
 lines in r.mask:


 {{{
 grass.run_command('g.remove', flags='f', quiet=True,
   type='raster', name='MASK')
 }}}

 be replaced by


 {{{
 grass.run_command('g.remove', flags='fi', quiet=True,
   type='raster', name='MASK')

 }}}

 if we are in Windows ?

--
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-11 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  MSWindows 8  
  Cpu:  Unspecified  |  
-+--

Comment(by annakrat):

 Replying to [comment:6 glynn]:
 > Replying to [comment:5 annakrat]:
 > > Wontfix?
 > No. If a map is recognised as a mask by
 `Rast__check_for_auto_masking()`, then `r.mask -r` should remove it.
 >
 > On Windows, remove("MASK") will remove a file named "MASK", "mask",
 "Mask", "MaSK" or any other variation (you can't have more than one of
 those in any given directory).
 >
 > Does `g.remove type=rast pattern=MASK` remove the file? If not, that's a
 bug in g.remove. Indeed, this appears to be the problem.

 I haven't tested specifically this command but r.mask is using it for
 removing the mask.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-11 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  MSWindows 8  
  Cpu:  Unspecified  |  
-+--

Comment(by glynn):

 Replying to [comment:5 annakrat]:
 > Wontfix?
 No. If a map is recognised as a mask by `Rast__check_for_auto_masking()`,
 then `r.mask -r` should remove it.

 On Windows, remove("MASK") will remove a file named "MASK", "mask",
 "Mask", "MaSK" or any other variation (you can't have more than one of
 those in any given directory).

 Does `g.remove type=rast pattern=MASK` remove the file? If not, that's a
 bug in g.remove. Indeed, this appears to be the problem.

 Looking at source:grass/trunk/lib/gis/ls_filter.c#L151, regcomp() should
 probably be using REG_ICASE on Windows (and also on Unix if GISDBASE is on
 a case-insensitive filesystem, but that's easier said than done).

 IOW, this bug is a consequence of replacing g.remove with g.mremove; the
 former doesn't care about case, the latter does.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-10 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  MSWindows 8  
  Cpu:  Unspecified  |  
-+--

Comment(by annakrat):

 It's because the mask was created from raster map 'mask' (lowercase). So
 on Windows, there is I guess no way how to distinguish it. Wontfix? Should
 we put it in r.mask manual?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-09 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  MSWindows 8  
  Cpu:  Unspecified  |  
-+--

Comment(by baharmon):

 I'm using Windows 8.1.  There was no error message.

 r.mask -r
 Raster MASK removed
 (Thu Oct 09 17:34:34 2014) Command finished (0 sec)

 The map display however still shows the mask and the there is the red
 'MASK' tag in the lower right corner of the display.  After re-rendering
 there is still the mask.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-09 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  MSWindows 8  
  Cpu:  Unspecified  |  
-+--
Changes (by baharmon):

  * platform:  Unspecified => MSWindows 8


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-09 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  Unspecified  
  Cpu:  Unspecified  |  
-+--

Comment(by neteler):

 I check on Linux, no problem:

 {{{
 GRASS 7.1.svn (nc_spm_08_grass7):~ > r.mask zipcodes
 All subsequent raster operations will be limited to the MASK area.
 Removing
 or renaming raster map named 'MASK' will restore raster operations to
 normal.
 [Raster MASK present]

 GRASS 7.1.svn (nc_spm_08_grass7):~ > r.mask -r
 Raster MASK removed

 GRASS 7.1.svn (nc_spm_08_grass7):~ > g.version -g
 version=7.1.svn
 date=2014
 revision=62126M
 build_date=2014-09-28
 build_platform=x86_64-unknown-linux-gnu
 }}}

 Which operating system are you using? And: what is the error?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #2445: r.mask -r removal not working in GRASS 7.1 svn r.62210

2014-10-09 Thread GRASS GIS 
#2445: r.mask -r removal not working in GRASS 7.1 svn  r.62210
-+--
 Reporter:  baharmon |   Owner:  grass-dev@…  
 Type:  defect   |  Status:  new  
 Priority:  normal   |   Milestone:  7.1.0
Component:  Raster   | Version:  svn-trunk
 Keywords:  r.mask   |Platform:  Unspecified  
  Cpu:  Unspecified  |  
-+--
Changes (by martinl):

  * keywords:  => r.mask
  * component:  Default => Raster


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev