Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-24 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-

Comment (by sbl):

 The test actually only tests if the module works, but contains additinal
 tests that have nothing to to with the module in question (and rather
 tests data or other modules). Took the liberty to deactivate the test
 until fixed with proper test cases.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-24 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-

Comment (by sbl):

 In [changeset:"74423" 74423]:
 {{{
 #!CommitTicketReference repository="" revision="74423"
 deactivate erroneous test; see #3822
 }}}

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-21 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-

Comment (by pmav99):

 After applying the patch, the tests do pass, but the "elevation" map still
 gets corrupted.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-20 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-

Comment (by neteler):

 Replying to [comment:2 mmetz]:
 > Replying to [comment:1 neteler]:
 > > After renaming the maps (see attached patch) the test passes here.
 >
 > Does it make sense to adjust tests to a test location that is 1) not
 available,

 It is available:
 http://fatra.cnr.ncsu.edu/data/

 > 2) in alpha state?

 In the end I only restored the names of the standard sample data set and
 found that the tests works.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-20 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-

Comment (by mmetz):

 Replying to [comment:1 neteler]:
 > After renaming the maps (see attached patch) the test passes here.

 Does it make sense to adjust tests to a test mapset that is 1) not
 available, 2) in alpha state?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-20 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-
Changes (by neteler):

 * Attachment "testrbf_fix_mapnames.diff" added.

 Update map names to those used in nc_spm_full_v2alpha

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3822: Tests for r.basins.fill are broken

2019-04-20 Thread GRASS GIS
#3822: Tests for r.basins.fill are broken
--+-
  Reporter:  pmav99   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:
 Component:  Tests|Version:  svn-trunk
Resolution:   |   Keywords:
   CPU:  Unspecified  |   Platform:  Unspecified
--+-

Comment (by neteler):

 After renaming the maps (see attached patch) the test passes here.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev