Re: [GRASS-dev] [GRASS GIS] #613: clean_temp: not safe for concurrent use

[GRASS GIS]

#613: clean_temp: not safe for concurrent use
--+--
  Reporter:  hamish   |  Owner:  grass-dev@…
  Type:  defect   | Status:  closed
  Priority:  normal   |  Milestone:  7.6.0
 Component:  Startup  |Version:  6.4.0 RCs
Resolution:  fixed|   Keywords:  clean_temp init grass.py
   CPU:  All  |   Platform:  All
--+--

Comment (by hamish):

 Replying to [comment:4 wenzeslaus]:
 > Note: There is another `clean_temp` at the end. My assumption is that
 the start
 > time one is meant to clean the mapset just in case.

 Yes exactly right, as the previous session may have ended uncleanly with a
 crash/kill/reboot.


 best,
 Hamish

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #613: clean_temp: not safe for concurrent use

[GRASS GIS]

#613: clean_temp: not safe for concurrent use
--+--
  Reporter:  hamish   |  Owner:  grass-dev@…
  Type:  defect   | Status:  closed
  Priority:  normal   |  Milestone:  7.6.0
 Component:  Startup  |Version:  6.4.0 RCs
Resolution:  fixed|   Keywords:  clean_temp init grass.py
   CPU:  All  |   Platform:  All
--+--
Changes (by wenzeslaus):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"73342" 73342]:
 {{{
 #!CommitTicketReference repository="" revision="73342"
 init: clean mapset only after locking it (fixes #613, see #1286)

 Only after we set the user-requested mapset as current (GISRC) and lock
 it,
 we can do the startup cleaning using clean_temp (to clean after previous
 sessions
 if needed).

 The cleaning was in place at least since r11260 but it got moved to a
 wrong place some
 time after that but before r37863.
 }}}

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #613: clean_temp: not safe for concurrent use

[GRASS GIS]

#613: clean_temp: not safe for concurrent use
--+--
  Reporter:  hamish   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.6.0
 Component:  Startup  |Version:  6.4.0 RCs
Resolution:   |   Keywords:  clean_temp init grass.py
   CPU:  All  |   Platform:  All
--+--

Comment (by wenzeslaus):

 My current understanding is that that `clean_temp` is called in `grass.py`
 right when it checks if it determines that it is not a new user which is
 taken as a reason to clean the current mapset. Unfortunately the current
 mapset is the last used mapset, not necessarily the one requested. The
 mapset locking happens later on and only after that we can clean the
 mapset. Therefore, I will move  the `clean_temp` call only after the lock.

 Note: There is another `clean_temp` at the end. My assumption is that the
 start time one is meant to clean the mapset just in case.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #613: clean_temp: not safe for concurrent use

[GRASS GIS]

#613: clean_temp: not safe for concurrent use
--+--
  Reporter:  hamish   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.6.0
 Component:  Startup  |Version:  6.4.0 RCs
Resolution:   |   Keywords:  clean_temp init grass.py
   CPU:  All  |   Platform:  All
--+--
Changes (by wenzeslaus):

 * keywords:  clean_temp => clean_temp init grass.py
 * milestone:  6.4.6 => 7.6.0


Comment:

 This still might be an issue. `clean_temp()` (which calls `clean_temp`) is
 called on [source:grass/trunk/lib/init/grass.py?rev=73199#L2037 line 2040]
 while mapset is set and ready later on
 [source:grass/trunk/lib/init/grass.py?rev=73199#L2079 line 2087]. Same in
 7.0 and trunk (7.7). (Now I have second thoughts about closing #1286, but
 if it is an issue (location being set, but possibly garbage), it is really
 this one anyway.)

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #613: clean_temp: not safe for concurrent use

[GRASS GIS]

#613: clean_temp: not safe for concurrent use
+---
 Reporter:  hamish  |   Owner:  grass-dev@…  
 Type:  defect  |  Status:  new  
 Priority:  normal  |   Milestone:  6.4.4
Component:  Startup | Version:  6.4.0 RCs
 Keywords:  clean_temp  |Platform:  All  
  Cpu:  All |  
+---
Changes (by hamish):

  * component:  Default => Startup
  * milestone:  6.4.0 => 6.4.4


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev