Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-09-06 Thread Stefan Blumentrath
Hei Markus,

I see.
With Maris hint on r.support, I managed to assign custom band names at import / 
t.register.
I still have to figure out how (or if) the different temporal modules handle 
band references.
I do get invalid temporal topology errors in g.gui.animation for example, but 
that may be due to start = end time stamp.

Documentation of features and none-features with band-references deserves some 
love for GRASS 8 release I guess…

Cheers
Stefan

From: Markus Metz 
Sent: mandag 6. september 2021 09:27
To: Maris Nartiss 
Cc: Stefan Blumentrath ; Martin Landa 
; GRASS developers list 
Subject: Re: [GRASS-dev] lib/gis/band_reference.c ?

The easiest way to assign custom band names to raster maps in a strds is to 
create a corresponding file for t.register.

Note that band names in a strds do not need to match band names assigned with 
i.bands. The whole concept of band references in GRASS is IMHO still 
experimental and unfortunately far away from the STAC eo bands extension.

Markus M


On Tue, Aug 24, 2021 at 11:09 AM Maris Nartiss 
mailto:maris@gmail.com>> wrote:
Band reference rules were totally relaxed 7 days a go:
https://github.com/OSGeo/grass/commit/abe194dce78adf5f63885a6a09c452fc7ae4f735<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOSGeo%2Fgrass%2Fcommit%2Fabe194dce78adf5f63885a6a09c452fc7ae4f735=04%7C01%7C%7C84da7a235fa0418cfe3f08d97107ae4d%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637665100081158341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000=OXOunlOeOPMIGv8lyo6bpVMnOVkJ7SpTYgHfu5iXsXc%3D=0>

New relaxed rule changes haven't propagated to the documentation yet
(PR's welcome).

Band reference editing via r.support was added on 4th of July:
https://github.com/OSGeo/grass/commit/ca1551206eaa0fc462f4849a06ebb035808470da<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOSGeo%2Fgrass%2Fcommit%2Fca1551206eaa0fc462f4849a06ebb035808470da=04%7C01%7C%7C84da7a235fa0418cfe3f08d97107ae4d%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637665100081168336%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000=MqIan9AmoGhM3PIJ1AF3kEyE%2FXmRtiw9PG9%2FqUVDfYw%3D=0>

Still – keep in mind – there are no changes in band metadata as
managed by g.bands. Changes only deal with ability to have a band
reference without extended metadata in json files. Thus limitation of
not being able to define your own band reference is still in place,
now only you can assign a band reference without having a definition
(and thus any extended metadata apart from its name).

Māris.

2021-08-24 11:18 GMT+03:00, Stefan Blumentrath 
mailto:stefan.blumentr...@nina.no>>:
> Thanks Maris for the reply.
>
> I could not find that option in r.support.
>
> i.band allows to add e.g. S2_12 as band reference, but nothing custom. And
> the g.bands manual says that user-defined band references are not yet
> supported.
>
> Has that been added recently? Or would I have to edit the bands json file of
> the system first?
>
> My system is:
> g.version -ger
> version=8.0.dev<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2F8.0.dev%2F=04%7C01%7C%7C84da7a235fa0418cfe3f08d97107ae4d%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637665100081178328%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000=fxKLaiDra3SU%2FFu3d%2F4CUCH9x1wQ0nshhcFgrR0RazQ%3D=0>
> date=2021
> revision=dd9d36830
> build_date=2021-07-08
> build_platform=x86_64-pc-linux-gnu
> build_off_t_size=8
> libgis_revision=d2a5e8e8f
> libgis_date=2021-06-16T04:05:21+00:00
> proj=7.0.0
> gdal=3.0.4
> geos=3.8.0
> sqlite=3.22.0
>
> Cheers
> Stefan
>
> -Original Message-
> From: Maris Nartiss mailto:maris@gmail.com>>
> Sent: tirsdag 24. august 2021 09:03
> To: Stefan Blumentrath 
> mailto:stefan.blumentr...@nina.no>>
> Cc: Martin Landa mailto:landa.mar...@gmail.com>>; 
> Markus Metz
> mailto:markus.metz.gisw...@gmail.com>>; GRASS 
> developers list
> mailto:grass-dev@lists.osgeo.org>>
> Subject: Re: [GRASS-dev] lib/gis/band_reference.c ?
>
> GRASS supports arbitrary band reference names. Just make them unique enough
> to not mix together apples with oranges by accident (e.g. "min"
> is a bad idea, "min_t_c" is better; "NDVI" would work; "elevation" – bad,
> "elevation_m" – better).
> You can set band references after import with r.support module.
>
> Have fun,
> Māris.
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-09-06 Thread Markus Metz
The easiest way to assign custom band names to raster maps in a strds is to
create a corresponding file for t.register.

Note that band names in a strds do not need to match band names assigned
with i.bands. The whole concept of band references in GRASS is IMHO still
experimental and unfortunately far away from the STAC eo bands extension.

Markus M


On Tue, Aug 24, 2021 at 11:09 AM Maris Nartiss  wrote:

> Band reference rules were totally relaxed 7 days a go:
>
> https://github.com/OSGeo/grass/commit/abe194dce78adf5f63885a6a09c452fc7ae4f735
>
> New relaxed rule changes haven't propagated to the documentation yet
> (PR's welcome).
>
> Band reference editing via r.support was added on 4th of July:
>
> https://github.com/OSGeo/grass/commit/ca1551206eaa0fc462f4849a06ebb035808470da
>
> Still – keep in mind – there are no changes in band metadata as
> managed by g.bands. Changes only deal with ability to have a band
> reference without extended metadata in json files. Thus limitation of
> not being able to define your own band reference is still in place,
> now only you can assign a band reference without having a definition
> (and thus any extended metadata apart from its name).
>
> Māris.
>
> 2021-08-24 11:18 GMT+03:00, Stefan Blumentrath  >:
> > Thanks Maris for the reply.
> >
> > I could not find that option in r.support.
> >
> > i.band allows to add e.g. S2_12 as band reference, but nothing custom.
> And
> > the g.bands manual says that user-defined band references are not yet
> > supported.
> >
> > Has that been added recently? Or would I have to edit the bands json
> file of
> > the system first?
> >
> > My system is:
> > g.version -ger
> > version=8.0.dev
> > date=2021
> > revision=dd9d36830
> > build_date=2021-07-08
> > build_platform=x86_64-pc-linux-gnu
> > build_off_t_size=8
> > libgis_revision=d2a5e8e8f
> > libgis_date=2021-06-16T04:05:21+00:00
> > proj=7.0.0
> > gdal=3.0.4
> > geos=3.8.0
> > sqlite=3.22.0
> >
> > Cheers
> > Stefan
> >
> > -Original Message-
> > From: Maris Nartiss 
> > Sent: tirsdag 24. august 2021 09:03
> > To: Stefan Blumentrath 
> > Cc: Martin Landa ; Markus Metz
> > ; GRASS developers list
> > 
> > Subject: Re: [GRASS-dev] lib/gis/band_reference.c ?
> >
> > GRASS supports arbitrary band reference names. Just make them unique
> enough
> > to not mix together apples with oranges by accident (e.g. "min"
> > is a bad idea, "min_t_c" is better; "NDVI" would work; "elevation" – bad,
> > "elevation_m" – better).
> > You can set band references after import with r.support module.
> >
> > Have fun,
> > Māris.
> >
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-08-24 Thread Maris Nartiss
Band reference rules were totally relaxed 7 days a go:
https://github.com/OSGeo/grass/commit/abe194dce78adf5f63885a6a09c452fc7ae4f735

New relaxed rule changes haven't propagated to the documentation yet
(PR's welcome).

Band reference editing via r.support was added on 4th of July:
https://github.com/OSGeo/grass/commit/ca1551206eaa0fc462f4849a06ebb035808470da

Still – keep in mind – there are no changes in band metadata as
managed by g.bands. Changes only deal with ability to have a band
reference without extended metadata in json files. Thus limitation of
not being able to define your own band reference is still in place,
now only you can assign a band reference without having a definition
(and thus any extended metadata apart from its name).

Māris.

2021-08-24 11:18 GMT+03:00, Stefan Blumentrath :
> Thanks Maris for the reply.
>
> I could not find that option in r.support.
>
> i.band allows to add e.g. S2_12 as band reference, but nothing custom. And
> the g.bands manual says that user-defined band references are not yet
> supported.
>
> Has that been added recently? Or would I have to edit the bands json file of
> the system first?
>
> My system is:
> g.version -ger
> version=8.0.dev
> date=2021
> revision=dd9d36830
> build_date=2021-07-08
> build_platform=x86_64-pc-linux-gnu
> build_off_t_size=8
> libgis_revision=d2a5e8e8f
> libgis_date=2021-06-16T04:05:21+00:00
> proj=7.0.0
> gdal=3.0.4
> geos=3.8.0
> sqlite=3.22.0
>
> Cheers
> Stefan
>
> -Original Message-
> From: Maris Nartiss 
> Sent: tirsdag 24. august 2021 09:03
> To: Stefan Blumentrath 
> Cc: Martin Landa ; Markus Metz
> ; GRASS developers list
> 
> Subject: Re: [GRASS-dev] lib/gis/band_reference.c ?
>
> GRASS supports arbitrary band reference names. Just make them unique enough
> to not mix together apples with oranges by accident (e.g. "min"
> is a bad idea, "min_t_c" is better; "NDVI" would work; "elevation" – bad,
> "elevation_m" – better).
> You can set band references after import with r.support module.
>
> Have fun,
> Māris.
>
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-08-24 Thread Stefan Blumentrath
Thanks Maris for the reply.

I could not find that option in r.support.

i.band allows to add e.g. S2_12 as band reference, but nothing custom. And the 
g.bands manual says that user-defined band references are not yet supported. 

Has that been added recently? Or would I have to edit the bands json file of 
the system first?

My system is:
g.version -ger
version=8.0.dev
date=2021
revision=dd9d36830
build_date=2021-07-08
build_platform=x86_64-pc-linux-gnu
build_off_t_size=8
libgis_revision=d2a5e8e8f
libgis_date=2021-06-16T04:05:21+00:00
proj=7.0.0
gdal=3.0.4
geos=3.8.0
sqlite=3.22.0

Cheers
Stefan

-Original Message-
From: Maris Nartiss  
Sent: tirsdag 24. august 2021 09:03
To: Stefan Blumentrath 
Cc: Martin Landa ; Markus Metz 
; GRASS developers list 

Subject: Re: [GRASS-dev] lib/gis/band_reference.c ?

GRASS supports arbitrary band reference names. Just make them unique enough to 
not mix together apples with oranges by accident (e.g. "min"
is a bad idea, "min_t_c" is better; "NDVI" would work; "elevation" – bad, 
"elevation_m" – better).
You can set band references after import with r.support module.

Have fun,
Māris.
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-08-24 Thread Maris Nartiss
GRASS supports arbitrary band reference names. Just make them unique
enough to not mix together apples with oranges by accident (e.g. "min"
is a bad idea, "min_t_c" is better; "NDVI" would work; "elevation" –
bad, "elevation_m" – better).
You can set band references after import with r.support module.

Have fun,
Māris.
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-08-23 Thread Stefan Blumentrath
Hi,

I do have some climate data that comes as netCDF with a time series for several 
variables (max, min, avg temperature).

Currently (before band references), I would create a separate STRDS for each 
variable. If it would be possible to use custom band references (I did not find 
how to do that in the documentation, any hints where to look?), they could come 
in handy to have e.g. just one climate STRDS with different aggregations as 
"bands".

The same concept could apply to results from t.rast.aggregate if multiple 
aggregations are returned...
That is not exactly an "imagery band", but NDVI is also just an artificial 
band, isn`t it...

Cheers
Stefan


-Original Message-
From: grass-dev  On Behalf Of Martin Landa
Sent: torsdag 18. mars 2021 22:22
To: Markus Metz 
Cc: GRASS developers list 
Subject: Re: [GRASS-dev] lib/gis/band_reference.c ?

Hi Markus,

st 10. 3. 2021 v 21:56 odesílatel Markus Metz  
napsal:

> The functions defined in lib/gis/band_reference.c [0] are used for raster 
> imagery and should thus be removed from lib/gis. There is also 
> lib/raster/band_reference.c [1] which should be moved to lib/imagery and the 
> functions need to be renamed.
>
> Martin, can you explain the reason for the existence of 
> lib/gis/band_reference.c and lib/raster/band_reference.c and the 
> non-existence of lib/imagery/band_reference.c ?

You are right that both files should be probably merged and moved to raster 
imagery since the band reference concept is used currently only for imagery 
data.

The reason why the functionality has been split into libgis and libraster was 
the assumption that the (band) reference concept could be used also for 
non-imagery data (raster or vector). But it will probably not happen.

I will take a look on this issue in the next few days. Martin

--
Martin Landa
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgeo.fsv.cvut.cz%2Fgwiki%2FLandadata=04%7C01%7C%7C64d1ea325dfd48a42b2408d8ea53dfaf%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637516993249227453%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=L7Sk9fZ0owlfyVMhgBdL4KHgKfrUCFBOkf0o7ZTXMHk%3Dreserved=0
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgismentors.cz%2Fmentors%2Flandadata=04%7C01%7C%7C64d1ea325dfd48a42b2408d8ea53dfaf%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637516993249227453%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=1oyGEnTkJKoCsGD8v%2BJpS42FCRkpdhONDHAhUTuzTO0%3Dreserved=0
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.osgeo.org%2Fmailman%2Flistinfo%2Fgrass-devdata=04%7C01%7C%7C64d1ea325dfd48a42b2408d8ea53dfaf%7C6cef373021314901831055b3abf02c73%7C0%7C0%7C637516993249227453%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=dr%2FD2Zegi55a2DW8qHND8P3waNx0C8mwUYTUrCO5iEk%3Dreserved=0
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] lib/gis/band_reference.c ?

2021-03-18 Thread Martin Landa
Hi Markus,

st 10. 3. 2021 v 21:56 odesílatel Markus Metz
 napsal:

> The functions defined in lib/gis/band_reference.c [0] are used for raster 
> imagery and should thus be removed from lib/gis. There is also 
> lib/raster/band_reference.c [1] which should be moved to lib/imagery and the 
> functions need to be renamed.
>
> Martin, can you explain the reason for the existence of 
> lib/gis/band_reference.c and lib/raster/band_reference.c and the 
> non-existence of lib/imagery/band_reference.c ?

You are right that both files should be probably merged and moved to
raster imagery since the band reference concept is used currently only
for imagery data.

The reason why the functionality has been split into libgis and
libraster was the assumption that the (band) reference concept could
be used also for non-imagery data (raster or vector). But it will
probably not happen.

I will take a look on this issue in the next few days. Martin

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev