Re: [GRASS-user] errors in r.drain (develbranch)

2009-04-07 Thread Markus Neteler
2009/4/7 Colin Nielsen colin.niel...@gmail.com:
 This might be an error with my updates
 (http://trac.osgeo.org/grass/changeset/36351). I'm not sure why there

ah, so it was on develbranch_6/ - I didn't catch that.

 wasn't any error reported for me or others, but I see that there is an
 inconsistency in the code (my addition at 387 compared to lines 373
 and 374).

 387             dir_fd = open(tempfile3, O_RDWR | O_CREAT);
 Should be:
 387             dir_fd = open(tempfile3, O_RDWR | O_CREAT, 0666);


Fix in SVN now.

BTW: I see that your changes didn't make it into GRASS 7 - intentionally?
I don't think that it is a good idea to leave GRASS 7 behind - the longer
we wait with forward-porting the more difficult it becomes.

Just my 0.02 cent
Markus
___
grass-user mailing list
grass-user@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-user


[GRASS-user] errors in r.drain (develbranch)

2009-04-06 Thread Guâno
Hello all,

after a full SVN of develbranch, I'm getting errors in r.drain:

-
Errors in:
/home/guano/pessoal/tmp_install/gis/grass6_devel/raster/r.drain
--
In case of errors please change into the directory with error and run 'make'.
If you get multiple errors, you need to deal with them in the order they
appear in the error log. If you get an error building a library, you will
also get errors from anything which uses the library.
--
Finished compilation: Mon Apr  6 14:10:58 BRT 2009
make: *** [default] Error 1
guano[grass6_devel]$ cd raster/r.drain/
guano[r.drain]$ make
gcc 
-I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686-pc-linux-gnu/include
 -mt
une=nocona -minline-all-stringops -O2 -Wall -D_FILE_OFFSET_BITS=64
-I/usr/include/gdal
   -DPACKAGE=\grassmods\
-I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686
-pc-linux-gnu/include -o OBJ.i686-pc-linux-gnu/main.o -c main.c
main.c: In function ‘main’:
main.c:174: warning: format not a string literal and no format arguments
main.c:178: warning: format not a string literal and no format arguments
main.c:183: warning: format not a string literal and no format arguments
main.c:204: warning: format not a string literal and no format arguments
main.c:228: warning: format not a string literal and no format arguments
main.c:242: warning: the address of ‘vect’ will always evaluate as ‘true’
main.c:251: warning: format not a string literal and no format arguments
main.c:270: warning: format not a string literal and no format arguments
main.c:291: warning: format not a string literal and no format arguments
main.c:311: warning: format not a string literal and no format arguments
main.c:323: warning: format not a string literal and no format arguments
main.c:398: warning: format not a string literal and no format arguments
main.c:103: warning: unused variable ‘vect_mapset’
main.c:379: warning: ignoring return value of ‘write’, declared with
attribute warn_unused
_result
main.c:391: warning: ignoring return value of ‘write’, declared with
attribute warn_unused
_result
main.c:497: warning: ignoring return value of ‘read’, declared with
attribute warn_unused_
result
main.c: In function ‘drain’:
main.c:611: warning: ignoring return value of ‘read’, declared with
attribute warn_unused_
result
main.c: In function ‘drain_cost’:
main.c:664: warning: unused variable ‘col’
main.c:664: warning: unused variable ‘row’
main.c:681: warning: ignoring return value of ‘read’, declared with
attribute warn_unused_
result
main.c: In function ‘main’:
main.c:73: warning: ‘dir_mapset’ may be used uninitialized in this function
main.c:84: warning: ‘dir_buf’ may be used uninitialized in this function
main.c:74: warning: ‘tempfile3’ may be used uninitialized in this function
main.c:66: warning: ‘dir_fd’ may be used uninitialized in this function
In function ‘open’,
inlined from ‘main’ at main.c:387:
/usr/include/bits/fcntl2.h:51: error: call to ‘__open_missing_mode’
declared with attribut
e error: open with O_CREAT in second argument needs 3 arguments
make: *** [OBJ.i686-pc-linux-gnu/main.o] Error 1
guano[r.drain]$


any hints appreciated :)

Carlos



-- 
Carlos Henrique Grohmann - Geologist D.Sc.
a.k.a. Guano - Linux User #89721
ResearcherID: A-9030-2008
carlos dot grohmann at gmail dot com
http://www.igc.usp.br/pessoais/guano/
_
Good morning, doctors. I have taken the liberty of removing Windows
95 from my hard drive.
--The winning entry in a What were HAL's first words contest judged
by 2001: A SPACE ODYSSEY creator Arthur C. Clarke

Can’t stop the signal.
___
grass-user mailing list
grass-user@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-user


Re: [GRASS-user] errors in r.drain (develbranch)

2009-04-06 Thread Markus Neteler
2009/4/6 Carlos Guâno Grohmann carlos.grohm...@gmail.com:
 Hello all,

 after a full SVN of develbranch, I'm getting errors in r.drain:

 -
 Errors in:
 /home/guano/pessoal/tmp_install/gis/grass6_devel/raster/r.drain

(that's indeed grass7_devel/raster/r.drain/, right?)

...
 guano[grass6_devel]$ cd raster/r.drain/
 guano[r.drain]$ make
 gcc 
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686-pc-linux-gnu/include
  -mt
 une=nocona -minline-all-stringops -O2 -Wall -D_FILE_OFFSET_BITS=64
 -I/usr/include/gdal
   -DPACKAGE=\grassmods\
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686
 -pc-linux-gnu/include -o OBJ.i686-pc-linux-gnu/main.o -c main.c
 main.c: In function ‘main’:
 main.c:174: warning: format not a string literal and no format arguments

that line reads
G_warning(_(Starting point %d is outside the current region),
in GRASS 7.
I assume that you lost somehow --with-nls as configure parameter so that
the gettext macro isn't recognised completely.

I suggest a make distclean and new configure.

Markus
___
grass-user mailing list
grass-user@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-user


Re: [GRASS-user] errors in r.drain (develbranch)

2009-04-06 Thread Guâno
 -
 Errors in:
 /home/guano/pessoal/tmp_install/gis/grass6_devel/raster/r.drain

 (that's indeed grass7_devel/raster/r.drain/, right?)


It's develbranch 6 (GRASS 6.5)

svn checkout https://svn.osgeo.org/grass/grass/branches/develbranch_6
grass6_devel


 ...
 guano[grass6_devel]$ cd raster/r.drain/
 guano[r.drain]$ make
 gcc 
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686-pc-linux-gnu/include
  -mt
 une=nocona -minline-all-stringops -O2 -Wall -D_FILE_OFFSET_BITS=64
 -I/usr/include/gdal
   -DPACKAGE=\grassmods\
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686
 -pc-linux-gnu/include -o OBJ.i686-pc-linux-gnu/main.o -c main.c
 main.c: In function ‘main’:
 main.c:174: warning: format not a string literal and no format arguments

 that line reads
                G_warning(_(Starting point %d is outside the current region),
 in GRASS 7.
 I assume that you lost somehow --with-nls as configure parameter so that
 the gettext macro isn't recognised completely.

--with-nls is there (from ./configure):

checking whether to use NLS... yes
checking for gettext... yes



 I suggest a make distclean and new configure.

This is a fresh download..

Carlos



-- 
Carlos Henrique Grohmann - Geologist D.Sc.
a.k.a. Guano - Linux User #89721
ResearcherID: A-9030-2008
carlos dot grohmann at gmail dot com
http://www.igc.usp.br/pessoais/guano/
_
Good morning, doctors. I have taken the liberty of removing Windows
95 from my hard drive.
--The winning entry in a What were HAL's first words contest judged
by 2001: A SPACE ODYSSEY creator Arthur C. Clarke

Can’t stop the signal.
___
grass-user mailing list
grass-user@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-user


Re: [GRASS-user] errors in r.drain (develbranch)

2009-04-06 Thread Colin Nielsen
This might be an error with my updates
(http://trac.osgeo.org/grass/changeset/36351). I'm not sure why there
wasn't any error reported for me or others, but I see that there is an
inconsistency in the code (my addition at 387 compared to lines 373
and 374).

387 dir_fd = open(tempfile3, O_RDWR | O_CREAT);
Should be:
387 dir_fd = open(tempfile3, O_RDWR | O_CREAT, 0666);

Trying making that change and recompile. Markus, I can submit a diff
for this line if needed.

-Colin

2009/4/6 Carlos Guâno Grohmann carlos.grohm...@gmail.com:
 -
 Errors in:
 /home/guano/pessoal/tmp_install/gis/grass6_devel/raster/r.drain

 (that's indeed grass7_devel/raster/r.drain/, right?)


 It's develbranch 6 (GRASS 6.5)

 svn checkout https://svn.osgeo.org/grass/grass/branches/develbranch_6
 grass6_devel


  ...
 guano[grass6_devel]$ cd raster/r.drain/
 guano[r.drain]$ make
 gcc 
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686-pc-linux-gnu/include
  -mt
 une=nocona -minline-all-stringops -O2 -Wall -D_FILE_OFFSET_BITS=64
 -I/usr/include/gdal
   -DPACKAGE=\grassmods\
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686
 -pc-linux-gnu/include -o OBJ.i686-pc-linux-gnu/main.o -c main.c
 main.c: In function ‘main’:
 main.c:174: warning: format not a string literal and no format arguments

 that line reads
                G_warning(_(Starting point %d is outside the current 
 region),
 in GRASS 7.
 I assume that you lost somehow --with-nls as configure parameter so that
 the gettext macro isn't recognised completely.

 --with-nls is there (from ./configure):

 checking whether to use NLS... yes
 checking for gettext... yes



 I suggest a make distclean and new configure.

 This is a fresh download..

 Carlos



 --
 Carlos Henrique Grohmann - Geologist D.Sc.
 a.k.a. Guano - Linux User #89721
 ResearcherID: A-9030-2008
 carlos dot grohmann at gmail dot com
 http://www.igc.usp.br/pessoais/guano/
 _
 Good morning, doctors. I have taken the liberty of removing Windows
 95 from my hard drive.
 --The winning entry in a What were HAL's first words contest judged
 by 2001: A SPACE ODYSSEY creator Arthur C. Clarke

 Can’t stop the signal.
 ___
 grass-user mailing list
 grass-user@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/grass-user

___
grass-user mailing list
grass-user@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-user


Re: [GRASS-user] errors in r.drain (develbranch)

2009-04-06 Thread Guâno
Yes, that fixed it.

many thanks

Carlos



2009/4/6 Colin Nielsen colin.niel...@gmail.com:
 This might be an error with my updates
 (http://trac.osgeo.org/grass/changeset/36351). I'm not sure why there
 wasn't any error reported for me or others, but I see that there is an
 inconsistency in the code (my addition at 387 compared to lines 373
 and 374).

 387             dir_fd = open(tempfile3, O_RDWR | O_CREAT);
 Should be:
 387             dir_fd = open(tempfile3, O_RDWR | O_CREAT, 0666);

 Trying making that change and recompile. Markus, I can submit a diff
 for this line if needed.

 -Colin

 2009/4/6 Carlos Guâno Grohmann carlos.grohm...@gmail.com:
 -
 Errors in:
 /home/guano/pessoal/tmp_install/gis/grass6_devel/raster/r.drain

 (that's indeed grass7_devel/raster/r.drain/, right?)


 It's develbranch 6 (GRASS 6.5)

 svn checkout https://svn.osgeo.org/grass/grass/branches/develbranch_6
 grass6_devel


  ...
 guano[grass6_devel]$ cd raster/r.drain/
 guano[r.drain]$ make
 gcc 
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686-pc-linux-gnu/include
  -mt
 une=nocona -minline-all-stringops -O2 -Wall -D_FILE_OFFSET_BITS=64
 -I/usr/include/gdal
   -DPACKAGE=\grassmods\
 -I/home/guano/pessoal/tmp_install/gis/grass6_devel/dist.i686
 -pc-linux-gnu/include -o OBJ.i686-pc-linux-gnu/main.o -c main.c
 main.c: In function ‘main’:
 main.c:174: warning: format not a string literal and no format arguments

 that line reads
                G_warning(_(Starting point %d is outside the current 
 region),
 in GRASS 7.
 I assume that you lost somehow --with-nls as configure parameter so that
 the gettext macro isn't recognised completely.

 --with-nls is there (from ./configure):

 checking whether to use NLS... yes
 checking for gettext... yes



 I suggest a make distclean and new configure.

 This is a fresh download..

 Carlos



 --
 Carlos Henrique Grohmann - Geologist D.Sc.
 a.k.a. Guano - Linux User #89721
 ResearcherID: A-9030-2008
 carlos dot grohmann at gmail dot com
 http://www.igc.usp.br/pessoais/guano/
 _
 Good morning, doctors. I have taken the liberty of removing Windows
 95 from my hard drive.
 --The winning entry in a What were HAL's first words contest judged
 by 2001: A SPACE ODYSSEY creator Arthur C. Clarke

 Can’t stop the signal.
 ___
 grass-user mailing list
 grass-user@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/grass-user





-- 
Carlos Henrique Grohmann - Geologist D.Sc.
a.k.a. Guano - Linux User #89721
ResearcherID: A-9030-2008
carlos dot grohmann at gmail dot com
http://www.igc.usp.br/pessoais/guano/
_
Good morning, doctors. I have taken the liberty of removing Windows
95 from my hard drive.
--The winning entry in a What were HAL's first words contest judged
by 2001: A SPACE ODYSSEY creator Arthur C. Clarke

Can’t stop the signal.
___
grass-user mailing list
grass-user@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-user