Re: [groff] 02/14: [man]: Warn on bad MT/ME/UR/UE nesting.
Hi Deri, At 2024-01-30T14:51:36+, Deri wrote: > On Tuesday, 30 January 2024 02:13:47 GMT G. Branden Robinson wrote: > > [man]: Warn on bad MT/ME/UR/UE nesting. > > > > * tmac/an.tmac (MT, ME, UR, UE): Throw warnings on bad nesting. > > This causes a warning when viewing groff_out(5), because it has a > nested .UR within a .TP. I'm aware of it. :) > Seems to work, in this instance, but perhaps there is a better way. The better way would be a resolution of Savannah #64134.[1] You have have noticed that I've been giving fresh attention to how groff man(7) handles the diversions it creates. I've kept the "bad" page structure intact to make it really easy to tell when I've solved the nested diversion problem. My working copy has had some "solutions", but they throw off line adjustment and look ugly. I think at this point it's simply a matter of whacking away at the problem with careful attention to environmental issues. I feel close. If I get unbearably stuck, I'll change the page to avoid the warnings. Thank you for landing the changes that bring hyperlinks to life in man(7) for PDF! That was the immediate cause of me digging into the aforementioned ticket. Regards, Branden [1] https://savannah.gnu.org/bugs/index.php?61434 signature.asc Description: PGP signature ___ Groff-commit mailing list Groff-commit@gnu.org https://lists.gnu.org/mailman/listinfo/groff-commit
Re: [groff] 02/14: [man]: Warn on bad MT/ME/UR/UE nesting.
On Tuesday, 30 January 2024 02:13:47 GMT G. Branden Robinson wrote: > [man]: Warn on bad MT/ME/UR/UE nesting. > > * tmac/an.tmac (MT, ME, UR, UE): Throw warnings on bad nesting. This causes a warning when viewing groff_out(5), because it has a nested .UR within a .TP. Replacing:- .TP .UR https://\:github.com/\:Alhadis/\:Roff\:.js/ .I Roff.js .UE is a viewer for intermediate output written in JavaScript. With this:- .P .UR https://\:github.com/\:Alhadis/\:Roff\:.js/ .I Roff.js .UE .TP \& \v'-1.4v'is a viewer for intermediate output written in JavaScript. Seems to work, in this instance, but perhaps there is a better way. Cheers Deri ___ Groff-commit mailing list Groff-commit@gnu.org https://lists.gnu.org/mailman/listinfo/groff-commit
[groff] 02/14: [man]: Warn on bad MT/ME/UR/UE nesting.
gbranden pushed a commit to branch master
in repository groff.
commit 22441f426907ce6b354ec25b984c8e31a7b26bd8
Author: G. Branden Robinson
AuthorDate: Sun Jan 28 23:45:22 2024 -0600
[man]: Warn on bad MT/ME/UR/UE nesting.
* tmac/an.tmac (MT, ME, UR, UE): Throw warnings on bad nesting.
---
ChangeLog| 4
tmac/an.tmac | 20 ++--
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index cfaac71cc..5a1f64de6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2024-01-28 G. Branden Robinson
+
+ * tmac/an.tmac (MT, ME, UR, UE): Throw warnings on bad nesting.
+
2024-01-28 G. Branden Robinson
* tmac/an.tmac (an*begin-hyperlink): Repair damage I introduced
diff --git a/tmac/an.tmac b/tmac/an.tmac
index 3fb4ff0ba..6b86fd632 100644
--- a/tmac/an.tmac
+++ b/tmac/an.tmac
@@ -1193,8 +1193,12 @@ contains unsupported escape sequence
.\" a diversion; it becomes the link text for the hyperlinked address.
.\" .MT nob...@example.com
.de1 MT
+. if d an*prefix \{\
+.an-warn cannot nest .\\$0 inside .MT or .UR
+.return
+. \}
. if !(\\n[.$] = 1) \
-.an-style-warn .\\$0 expects 1 argument, got \\n[.$]
+.an-warn .\\$0 expects 1 argument, got \\n[.$]
. ds an*prefix mailto:
. an*begin-hyperlink \\$1
..
@@ -1203,6 +1207,10 @@ contains unsupported escape sequence
.\" punctuation (or, rarely, other text) after link text.
.\" .ME [trailing-text]
.de1 ME
+. if !d an*prefix \{\
+.an-warn .\\$0 requires a preceding .MT
+.return
+. \}
. an*end-hyperlink \\$1
. rm an*prefix
..
@@ -1211,8 +1219,12 @@ contains unsupported escape sequence
.\" a diversion; it becomes the link text for the hyperlinked address.
.\" .UR nob...@example.com
.de1 UR
+. if d an*prefix \{\
+.an-warn cannot nest .\\$0 inside .MT or .UR
+.return
+. \}
. if !(\\n[.$] = 1) \
-.an-style-warn .\\$0 expects 1 argument, got \\n[.$]
+.an-warn .\\$0 expects 1 argument, got \\n[.$]
. ds an*prefix \" empty
. an*begin-hyperlink \\$1
..
@@ -1221,6 +1233,10 @@ contains unsupported escape sequence
.\" punctuation (or, rarely, other text) after link text.
.\" .UE [trailing-text]
.de1 UE
+. if !d an*prefix \{\
+.an-warn .\\$0 requires a preceding .UR
+.return
+. \}
. an*end-hyperlink \\$1
. rm an*prefix
..
___
Groff-commit mailing list
Groff-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/groff-commit
