[grpc-io] What is the best practice to share protobuf between Git repositories

2020-04-10 Thread Xiao Xin
Hi everyone, I'm currently importing proto definitions for gRPC services 
using git submodules but I found it quite not elegant. I always have to 
sync the submodules manually, and it's quite easy to lose track. I wonder 
how people have been dealing with the situation. Mono-repo pattern appears 
as another solution to the issue, but I don't think that's in favor for Git 
either.

-- 
You received this message because you are subscribed to the Google Groups 
"grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to grpc-io+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/grpc-io/51c7d7bb-afc8-41d0-925f-d7ece9dd1fd2%40googlegroups.com.


[grpc-io] gRFC discussion: PR vs mailing list

2020-04-10 Thread 'Christopher Warrington (CHRISTOPHER)' via grpc.io
I've noticed that much of the valuable discussion in gRFCs [1] these days is
happening via GitHub's PR interface.

The proposal process currently says:

> For at least a period of 10 business days (the minimum comment period), it
> is expected that the OWNER will respond to the comments and make updates
> to the RFC as new commits to the PR. Through the process, the discussion
> needs to be kept to the designated thread in the mailing list in order to
> avoid splintering conversations. The OWNER is encouraged to solicit as
> much feedback on the proposal as possible during this period. PR comments
> should belimited (sic, PR to fix [2]) to formatting and vocabulary.

Note in particular:

> the discussion needs to be kept to the designated thread in the mailing
> list

Practice and documentation have diverged. :-)

Should we

1. update the documented process to reflect the what people are doing today,
2. as a community work to change our collective behavior and redirect
   comments on GitHub back to the mailing list thread (perhaps with help
   from automation),
3. figure out some sort of in between (e.g., reflect comments/message back and 
forth),
4. start a proposal to come up with a different process that doesn't invite
   such bifurcation, or
5. something else?

I'm intentionally not linking to any examples, as I don't want to imply that
anyone is doing anything wrong. I'm trying to bring this up as an
observation that what we say we do and what we end up doing are different as
a way to figure out how to bring them back in sync with each other so that
new contributors know what to expect.

[1]: https://github.com/grpc/proposal
[2]: https://github.com/grpc/proposal/pull/176

--
Christopher Warrington
Microsoft Corp.

-- 
You received this message because you are subscribed to the Google Groups 
"grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to grpc-io+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/grpc-io/DM5PR00MB03897E574A5DDE02370546899BDE0%40DM5PR00MB0389.namprd00.prod.outlook.com.


[grpc-io] gRFC L64: Python Runtime Proto Parsing

2020-04-10 Thread 'Richard Belleville' via grpc.io
Hey everyone,

I've just written up a proposal for a feature I've been working on for a 
while now. It will allow users to import Protobuf message types and 
services from ".proto" files on the filesystem at runtime.

gRFC: 
https://github.com/gnossen/proposal/blob/runtime_proto_parsing/L64-python-runtime-proto-parsing.md
PR: https://github.com/grpc/proposal/pull/175

Thanks!
Richard

-- 
You received this message because you are subscribed to the Google Groups 
"grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to grpc-io+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/grpc-io/31a420ab-c2c4-47a5-b7a1-2bb485707e9f%40googlegroups.com.


Re: [grpc-io] Re: Getting TLS to work on gRPC server using Netty

2020-04-10 Thread gus
We've got TLS to work. More info here: 
https://github.com/netty/netty/issues/10181

On Thursday, 9 April 2020 22:44:10 UTC+1, Gus Narea wrote:
>
> Hi Chengyuan and thanks for your reply!
>
> Indeed, I'm talking about the server side. I understand the gRPC team 
> doesn't support it on Android but the Netty team does officially support 
> Android, which is why I'm looking into it.
>
> Everything seems to work as far as we can tell, at least the hello-world 
> example. But TLS doesn't work because of the issue I mentioned, so I was 
> wondering if anyone here had any luck.
>
> Cheers,
>
> Gus.
>
> On Thu, 9 Apr 2020 at 22:38, 'Chengyuan Zhang' via grpc.io <
> grpc-io@googlegroups.com> wrote:
>
>> Running a gRPC server on Android? That doesn't sound what we support. 
>> gRPC client on Android uses Okhttp (netty has problems on Android).
>>
>> There were a lot of Github discussions regarding TLS on Android/Okhttp.
>>
>> This document  
>> has 
>> some high-level discussion about gRPC with TLS in general. 
>>
>> This Github issue  contains 
>> fair amount of useful information for using TLS on Android/Okhttp. There 
>> are solid code snippets for TLS configurations in the comments and that 
>> user eventually got things to work.
>>
>> We may add an example for using TLS on Android/Okhttp (existing one uses 
>> netty, which doesn't work for Android) soon. Please stay tuned. 
>>
>> On Thursday, April 9, 2020 at 2:19:35 PM UTC-7 g...@relaycorp.tech wrote:
>>
>>> Hello!
>>>
>>> I've got a question for those of you who've got a gRPC server running on 
>>> Android: Did you manage to get TLS to work, and if so, how?
>>>
>>> We've got the server to work on Android using Netty but the only thing 
>>> that doesn't work is TLS and we've narrowed it down to Netty requiring 
>>> Java >= 8 when using conscrypt 
>>> ,
>>>  
>>> but Android reports Java 6.
>>>
>>> Cheers,
>>>
>>> Gus.
>>>
>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "grpc.io" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/grpc-io/z3INkyJLuMQ/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> grpc-io+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/grpc-io/ad810ac8-c042-48fd-9bfe-4849d618fe5f%40googlegroups.com
>>  
>> 
>> .
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to grpc-io+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/grpc-io/ab22036a-c622-4928-81c4-13fa1a3f6d14%40googlegroups.com.