RE: (no subject)
Ok. Thank you.
Sorry, I not pay attention to the comment. I just rushed into the code.
Thank for your help.
-Original Message-
From: Yoshinori K. Okuji [mailto:[EMAIL PROTECTED]
Sent: 2005年11月1日 20:18
To: The development of GRUB 2
Subject: Re: (no subject)
On Tuesday 01 November 2005 08:21 am, Zhao Yu,SCNB R&D NNA(BJ) wrote:
> I just begin to read some code in GRUB2, I met a question. Could you
> help me out?
Sure.
> In function
> void
> grub_rescue_cmd_multiboot (int argc, char *argv[])
> {
> ...
> if (grub_multiboot_load_elf (file, buffer) != GRUB_ERR_NONE)
> goto fail;
> ...
> }
> Do that mean the OS image must be elf format?
> Or there are some miunderstand.
Please look at the comment in the beginning of that file. Since a.out kludge
is not implemented yet, only ELF can be loaded correctly. This is in my TODO
list.
Okuji
___
Grub-devel mailing list
Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [GRUB1] Accessibility: Add beep support
Yoshinori K. Okuji wrote: > It is funny that something written only for fun can be very useful. Sadly I think nobody will find my framebuffer Mandelbrot of any use ;) . I think I'll add (f)scanf functions in a "library" module as you suggested, so tunes can be passed as arguments in a human (or voice-synthesis) readable form. Might be something like : play tempo tone duration [tone duration [...]] and play file I don't know much about the music conventions/standards, I'll dig a bit so I can make something once for all and quickly discoverable. About grub 1 policy, yes I meant my patch would be for grub 2. Vincent Pelletier signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: Scripting support (PATCH)
On Tuesday 01 November 2005 08:06 pm, Marco Gerards wrote: > To which value should grub_err_t be set on function return in the case > of the test command? I could add a new error `GRUB_ERR_TEST_RESULT' > and make it 1. I would prefer some better suggestion though :). Vladimir used GRUB_ERR_TEST_FAILURE. Not bad. Okuji ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [GRUB1] Accessibility: Add beep support
On Tuesday 01 November 2005 07:01 pm, Samuel Thibault wrote: > Vincent Pelletier, le Tue 01 Nov 2005 18:51:09 +0100, a écrit : > > > (it can be just implemented as "echo ^G") > > > > Actually I have wrote some months ago a "play" command that play tunes > > on the x86 internal speaker, that might be useful too. I was thinking > > about submitting it again those days. > > That could be useful on the long term indeed (for playing tunes > according to booting stages for instance). It is funny that something written only for fun can be very useful. Okuji ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [GRUB1] Accessibility: Add beep support
On Tuesday 01 November 2005 03:12 pm, Samuel Thibault wrote: > I know that no new feature are added to grub1, but this really small > feature (it can be just implemented as "echo ^G") would be _much_ useful > for blind people. If you know the answer, you don't have to ask it. ;) Whether it is big or small, whether it is useful or useless, the policy remains unchanged. Okuji ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: Scripting support (PATCH)
Marco Gerards <[EMAIL PROTECTED]> writes: > "Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > >> On Sunday 30 October 2005 10:04 pm, Marco Gerards wrote: >>> > I really don't like that each command has to explicitly set RESULT. As >>> > you note, it would be better if the return code from the command were >>> > automatically placed into the status environment variable. >>> >>> Most command return grub_err_t. The only commands that matter for us >>> are commands like `['. Would you propose every commands returns an >>> int and that on function return grub_errno is checked? >> >> I agree with Hollis. It should be automatic. What is wrong with setting $? >> to >> grub_errno? Isn't it enough to see if it is GRUB_ERR_NONE or not? > > Perhaps there is no problem with that. I just assumed it should be an > int. I will make this change. To which value should grub_err_t be set on function return in the case of the test command? I could add a new error `GRUB_ERR_TEST_RESULT' and make it 1. I would prefer some better suggestion though :). -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [GRUB1] Accessibility: Add beep support
Vincent Pelletier, le Tue 01 Nov 2005 18:51:09 +0100, a écrit : > > (it can be just implemented as "echo ^G") > > Actually I have wrote some months ago a "play" command that play tunes > on the x86 internal speaker, that might be useful too. I was thinking > about submitting it again those days. That could be useful on the long term indeed (for playing tunes according to booting stages for instance). Regards, Samuel ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [GRUB1] Accessibility: Add beep support
> (it can be just implemented as "echo ^G") Actually I have wrote some months ago a "play" command that play tunes on the x86 internal speaker, that might be useful too. I was thinking about submitting it again those days. Vincent Pelletier signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
[GRUB1] Accessibility: Add beep support
Hi, I know that no new feature are added to grub1, but this really small feature (it can be just implemented as "echo ^G") would be _much_ useful for blind people. Please see details on https://savannah.gnu.org/bugs/?func=detailitem&item_id=14661 I proposed a patch adding an "echo" command: https://savannah.gnu.org/bugs/download.php?item_id=14661&item_file_id=3077 Could this be commited? Regards, Samuel ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: (no subject)
On Tuesday 01 November 2005 08:21 am, Zhao Yu,SCNB R&D NNA(BJ) wrote:
> I just begin to read some code in GRUB2, I met a question.
> Could you help me out?
Sure.
> In function
> void
> grub_rescue_cmd_multiboot (int argc, char *argv[])
> {
> ...
> if (grub_multiboot_load_elf (file, buffer) != GRUB_ERR_NONE)
> goto fail;
> ...
> }
> Do that mean the OS image must be elf format?
> Or there are some miunderstand.
Please look at the comment in the beginning of that file. Since a.out kludge
is not implemented yet, only ELF can be loaded correctly. This is in my TODO
list.
Okuji
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
