Re: gettext: commands/*
=== modified file 'commands/blocklist.c'
--- commands/blocklist.c2009-06-10 21:04:23 +
+++ commands/blocklist.c2009-12-21 00:09:02 +
@@ -87,7 +87,7 @@ grub_cmd_blocklist (grub_command_t cmd _
if (! file->device->disk)
return grub_error (GRUB_ERR_BAD_DEVICE,
- "this command is available only for disk devices.");
+ "this command is available only for disk devices");
Capitalisation and full stop
=== modified file 'commands/halt.c'
--- commands/halt.c 2009-12-03 23:07:29 +
+++ commands/halt.c 2009-12-21 00:10:33 +
@@ -35,7 +35,7 @@ static grub_command_t cmd;
GRUB_MOD_INIT(halt)
{
cmd = grub_register_command ("halt", grub_cmd_halt,
- 0, "halts the computer. This command does not"
+ 0, "Halts the computer. This command does not"
" work on all firmware.");
I would rather say "On *every* firmware."
cmd_terminal_input =
grub_register_command ("terminal_input", grub_cmd_handler,
"terminal_input [handler]",
- "List or select a handler");
+ "List or select an input handler.");
I would rather say input terminal.
cmd_terminal_output =
grub_register_command ("terminal_output", grub_cmd_handler,
"terminal_output [handler]",
- "List or select a handler");
+ "List or select an output handler.");
Likewise
=== modified file 'commands/hexdump.c'
--- commands/hexdump.c 2009-12-10 13:37:42 +
+++ commands/hexdump.c 2009-12-21 00:12:18 +
- {"length", 'n', 0, "read only length bytes", 0, ARG_TYPE_INT},
+ {"length", 'n', 0, "Read only length bytes", 0, ARG_TYPE_INT},
I would rather write LENGTH. And full stop.
=== modified file 'commands/loadenv.c'
--- commands/loadenv.c 2009-09-01 19:07:42 +
+++ commands/loadenv.c 2009-12-21 00:12:52 +
@@ -29,7 +29,7 @@
static const struct grub_arg_option options[] =
{
-{"file", 'f', 0, "specify filename", 0, ARG_TYPE_PATHNAME},
+{"file", 'f', 0, "Specify filename.", 0, ARG_TYPE_PATHNAME},
Filename for what?
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Re: gettext: commands/*
On Mon, Dec 21, 2009 at 01:16:04PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> === modified file 'commands/halt.c'
> --- commands/halt.c 2009-12-03 23:07:29 +
> +++ commands/halt.c 2009-12-21 00:10:33 +
> @@ -35,7 +35,7 @@ static grub_command_t cmd;
> GRUB_MOD_INIT(halt)
> {
>cmd = grub_register_command ("halt", grub_cmd_halt,
> -0, "halts the computer. This command does not"
> +0, "Halts the computer. This command does not"
> " work on all firmware.");
> I would rather say "On *every* firmware."
That doesn't sound grammatical to this native speaker, because you use
"every" with singular count nouns and "firmware" isn't pluralisable -
I'm not sure of its exact grammatical category but it feels like a mass
noun to me. Besides, "does not work on all" feels more idiomatically
correct than "does not work on every".
"All firmware" is definitely better, but you could use "all firmware
implementations" if you wanted to be crystal-clear.
--
Colin Watson [cjwat...@ubuntu.com]
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] create variables when exporting them
Andreas Born wrote:
> I just noticed that I forgot the header line of the diff. Sorry for that.
> New double checked version attached.
>
Applied with stylistic fixes
> The Changelog is still:
> 2009-12-15 Andreas Born
>
> * kern/env.c (grub_env_export): Create nonexistent variables
> before exporting.
>
> Andreas Born schrieb:
>> Same here. Nothing changed as of r1917 and I didn't get any further
>> feedback either.
>> I've attached a rediffed version, too.
>>
>> Andreas Born schrieb:
>>> Here you go:
>>> ChangeLog:
>>> 2009-10-15 Andreas Born
>>>
>>> * kern/env.c (grub_env_export): Create nonexistent variables
>>> before exporting.
>>>
>>>
>>> The mixed indentation (tabs and spaces) in kern/env.c was a bit
>>> confusing.
>>>
>>> Andreas
>>>
>>> Colin Watson schrieb:
On Thu, Oct 15, 2009 at 08:40:37PM +0200, Andreas Born wrote:
> This patch changes grub_env_export to create variables with empty
> value, if necessary.
> This makes it possible to export variables before actually
> assigning them any value and is the way bash behaves.
>
This makes sense to me (although bash is "too big and too slow" and
we'll never implement anything close to all of it, this is a pretty
cheap way to reduce confusion due to differences), although
probably for
post-1.97. A couple of nits:
>* kern/env.c (grub_env_export): Create inexistent
> variables before exporting.
>
"nonexistent"
> + if (! var)
> + {
> +if (grub_env_set (name, "") != GRUB_ERR_NONE)
> +return grub_errno;
> +var = grub_env_find (name);
> + }
GNU brace style involves indenting the braces as well, thus:
if (! var)
{
if (grub_env_set (name, "") != GRUB_ERR_NONE)
return grub_errno;
var = grub_env_find (name);
}
>>>
>>
>
>
>
> ___
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Re: gettext: commands/*
Colin Watson wrote:
On Mon, Dec 21, 2009 at 01:16:04PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
=== modified file 'commands/halt.c'
--- commands/halt.c 2009-12-03 23:07:29 +
+++ commands/halt.c 2009-12-21 00:10:33 +
@@ -35,7 +35,7 @@ static grub_command_t cmd;
GRUB_MOD_INIT(halt)
{
cmd = grub_register_command ("halt", grub_cmd_halt,
- 0, "halts the computer. This command does not"
+ 0, "Halts the computer. This command does not"
" work on all firmware.");
I would rather say "On *every* firmware."
That doesn't sound grammatical to this native speaker, because you use
"every" with singular count nouns and "firmware" isn't pluralisable -
I'm not sure of its exact grammatical category but it feels like a mass
noun to me. Besides, "does not work on all" feels more idiomatically
correct than "does not work on every".
"All firmware" is definitely better, but you could use "all firmware
implementations" if you wanted to be crystal-clear.
I believe it would be also correct to say
This command does not work on some firmware implementations.
-- Bruce
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
New Italian PO file for 'grub' (version 1.97+20091122)
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'grub' has been submitted by the Italian team of translators. The file is available at: http://translationproject.org/latest/grub/it.po (We can arrange things so that in the future such files are automatically e-mailed to you when they arrive. Ask at the address below if you want this.) All other PO files for your package are available in: http://translationproject.org/latest/grub/ Please consider including all of these in your next release, whether official or a pretest. Whenever you have a new distribution with a new version number ready, containing a newer POT file, please send the URL of that distribution tarball to the address below. The tarball may be just a pretest or a snapshot, it does not even have to compile. It is just used by the translators when they need some extra translation context. The following HTML page has been updated: http://translationproject.org/domain/grub.html If any question arises, please contact the translation coordinator. Thank you for all your work, The Translation Project robot, in the name of your translation coordinator. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: gettext: commands/*
I've committed the patch. Notes:
On Dec/21/2009, Vladimir '??-coder/phcoder' Serbinenko wrote:
> === modified file 'commands/blocklist.c'
> --- commands/blocklist.c 2009-06-10 21:04:23 +
> +++ commands/blocklist.c 2009-12-21 00:09:02 +
> @@ -87,7 +87,7 @@ grub_cmd_blocklist (grub_command_t cmd _
>
>if (! file->device->disk)
> return grub_error (GRUB_ERR_BAD_DEVICE,
> -"this command is available only for disk devices.");
> +"this command is available only for disk devices");
> Capitalisation and full stop
I'll talk about this in a new thread.
>cmd = grub_register_command ("halt", grub_cmd_halt,
> -0, "halts the computer. This command does not"
> +0, "Halts the computer. This command does not"
> " work on all firmware.");
> I would rather say "On *every* firmware."
I followed Watson suggestion
> static const struct grub_arg_option options[] =
>{
> -{"file", 'f', 0, "specify filename", 0, ARG_TYPE_PATHNAME},
> +{"file", 'f', 0, "Specify filename.", 0, ARG_TYPE_PATHNAME},
> Filename for what?
I'll add a comment when I will gettextizze it.
--
Carles Pina i Estany
http://pinux.info
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
grub_error messages
Hi,
This comes from "gettext: commands/*" thread, but I feel that it's
already far from gettext :-)
Doing, in Grub:
grep grub_error commands/*
I would say that there are more strings without capitalization and
without full stop than with.
Then, two questions:
a) How we want these strings? I'll do a patch, but I prefer to agree
before
b) At beginning I thought that we would not gettext error messages, but
I see that lot of these messages appears to the end user. Do we gettext
using N_(" ") and then where it's printed I use _(" ") ? I would say
yes.
Thanks,
--
Carles Pina i Estany
http://pinux.info
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
