Re: Bug in multiboot_mbi2.c

2010-06-22 Thread Seth Goldberg



Quoting richardvo...@gmail.com, who wrote the following on Tue, 22 Jun 2010:


What, you want to control color channels independently?  Aren't
monochromatic amber displays good enough any more?


  As much as I enjoyed that amber goodness, I would like to be able to see red 
:).


 --S

___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: Bug#586358: grub-pc: Please handle DOS line endings in "cat"

2010-06-22 Thread Josh Triplett
On Sun, Jun 20, 2010 at 11:19:37PM +0100, Colin Watson wrote:
> On Fri, Jun 18, 2010 at 11:34:08AM -0700, Josh Triplett wrote:
> > The "cat" command, if given a file with DOS line endings, will show the
> > \r at the end of every line as a control character.  For convenience,
> > please consider adding support for this in "cat", ideally automatically.
> 
> Makes sense to me.  grub-devel, how about this patch?
> 
> 2010-06-20  Colin Watson  
> 
>   * commands/cat.c (grub_cmd_cat): Print DOS "\r\n" line endings as
>   simple newlines.
> 
[...]

Thanks!

- Josh Triplett

___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: Bug in multiboot_mbi2.c

2010-06-22 Thread richardvo...@gmail.com
What, you want to control color channels independently?  Aren't
monochromatic amber displays good enough any more?

:)

On Mon, Jun 21, 2010 at 9:22 PM, Seth Goldberg  wrote:
>
>  The code that constructs the framebuffer info has a nasty bug where the
> field position and mask size for red are set to the GREEN values:
>
>      tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
>      tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB;
> -->   tag->framebuffer_red_field_position = mode_info.green_field_pos;
> -->   tag->framebuffer_red_mask_size = mode_info.green_mask_size;
>      tag->framebuffer_green_field_position = mode_info.green_field_pos;
>      tag->framebuffer_green_mask_size = mode_info.green_mask_size;
>      tag->framebuffer_blue_field_position = mode_info.blue_field_pos;
>      tag->framebuffer_blue_mask_size = mode_info.blue_mask_size;
>
>
>  --S
>
> ___
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel