Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-07-10 Thread Lucas Gadani
On Sun, Jul 6, 2008 at 5:47 PM, Lucas Gadani [EMAIL PROTECTED] wrote:
 On Sun, Jul 6, 2008 at 18:41, Robert Millan [EMAIL PROTECTED] wrote:

 Looks like it increases pc.mod code to store information that is only useful
 to the chainloader.  Is there a reason for not having the chainloader
 retrieve it?  (note that for disk access we have a cache)

 We would need to duplicate the code that iterates through the logical
 partitions in the chainloader or we can change
 pc_partition_map_iterate hook function to also receive
 grub_pc_partition (we can't use the pc_partition_map_iterate cause the
 hook function only receives a grub_disk_t and grub_partition_t, but
 not the grub_pc_partition that's necessary to reconstruct the
 partition info).

What would be the best patch to get accepted into grub? I'm willing to
code the patch, but first I'd like to know the best way to get
comitted to grub.

-- 
Lucas


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] Fix chainloding + Chainloading into logical partitions

2008-07-06 Thread Lucas Gadani
On Sun, Jul 6, 2008 at 18:41, Robert Millan [EMAIL PROTECTED] wrote:

 Looks like it increases pc.mod code to store information that is only useful
 to the chainloader.  Is there a reason for not having the chainloader
 retrieve it?  (note that for disk access we have a cache)

We would need to duplicate the code that iterates through the logical
partitions in the chainloader or we can change
pc_partition_map_iterate hook function to also receive
grub_pc_partition (we can't use the pc_partition_map_iterate cause the
hook function only receives a grub_disk_t and grub_partition_t, but
not the grub_pc_partition that's necessary to reconstruct the
partition info).

-- 
Lucas


___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel