Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Robin Candau

Le 16/06/2023 à 12:35, Daniel Kiper a écrit :

On Fri, Jun 16, 2023 at 09:15:19AM +0200, Robin Candau wrote:

Le 15/06/2023 à 23:36, Christian Hesse a écrit :

Daniel Kiper  on Thu, 2023/06/15 17:05:

It looks I was able to reproduce this problem. I will be checking what
is going on in following days...

Here [1] is the fix. Please test...

Works for me, thanks!

Works for me as well, thanks!

Cool! Thanks for doing tests!

Christian, Robin, may I add Tested-by tag on your behalf to the patch?

Daniel


Fine by me ;)

Thanks again

--
Regards,
Robin Candau / Antiz



OpenPGP_0xFDC3040B92ACA748.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Robin Candau

Le 15/06/2023 à 23:36, Christian Hesse a écrit :

Daniel Kiper  on Thu, 2023/06/15 17:05:

It looks I was able to reproduce this problem. I will be checking what
is going on in following days...

Here [1] is the fix. Please test...

Works for me, thanks!

Works for me as well, thanks!

--
Regards,
Robin Candau / Antiz



OpenPGP_0xFDC3040B92ACA748.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Robin Candau

Le 12/06/2023 à 21:05, Daniel Kiper a écrit :

On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote:

Ard Biesheuvel  on Tue, 2023/05/23 17:31:

Now that GCC can generate function calls using the correct calling
convention for us, we can stop using the efi_call_XX () wrappers, and
just dereference the function pointers directly.

This avoids the untyped variadic wrapper routines, which means better
type checking for the method calls.

Building an Arch package from current git master makes the system unbootable
with just a black screen. We did biscect this and found this commit
(bb4aa6e06ee3877110a1dc0eb0d766ffac978993 in master) to be the first bad one.

As gcc is mentioned in the commit message... We are building with gcc
13.1.1-1. Any idea what is going on here?

Could you provide us more details? On which architecture/target do
you run tests? Does GRUB start? If yes which kernel version do you
try to boot? Could you send us a link to the GRUB and kernel packages
and sources? Etc...

Daniel


Hi,

Tests have been ran on a x86_64 laptop (but the issue has been 
reproduced on several other x86_64 machines). GRUB does not start, we 
don't even reach the GRUB menu, nothing more than a black screen at boot.
The kernel we're trying to boot is `linux 6.3.7-arch1-1` [1] (package 
[2]), but I doubt the kernel itself is in cause as we're able to boot it 
with a GRUB package built without the 
bb4aa6e06ee3877110a1dc0eb0d766ffac978993 commit. Here's a working GRUB 
package [3] and a faulty one [4].

Sources are taken from https://git.savannah.gnu.org/git/grub.git [5].

I remain available if you need specific tests or additional information.

[1] https://archlinux.org/packages/core/x86_64/linux/
[2] 
http://www.gtlib.gatech.edu/pub/archlinux/core/os/x86_64/linux-6.3.7.arch1-1-x86_64.pkg.tar.zst
[3] 
https://pkgbuild.com/~eworm/grub/grub-2:2.06.r535.g6a080b9cd-2-x86_64.pkg.tar.zst
[4] 
https://pkgbuild.com/~eworm/grub/grub-2:2.06.r554.gc016a969d-2-x86_64.pkg.tar.zst
[5] 
https://gitlab.archlinux.org/archlinux/packaging/packages/grub/-/blob/main/PKGBUILD#L60


--
Regards,
Robin Candau / Antiz



OpenPGP_0xFDC3040B92ACA748.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel