Re: [PATCH 0/8] xen: add pvh guest support
On Tue, Oct 09, 2018 at 11:35:28AM +0200, Juergen Gross wrote: > On 15/02/2018 13:02, Daniel Kiper wrote: > > Hi Juergen, > > > > Sorry for huge delay. It looks that I am recovering slowly and > > probably I will have more time for reviews. > > > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > >> This patch series adds support for booting Linux as PVH guest. > >> > >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > >> platform grub is booted as a standalone image directly by Xen. > >> > >> For booting Linux kernel it is using the standard linux kernel > >> loader. The only modification of the linux loader is to pass the > >> ACPI RSDP address via boot parameters to the kernel, as that table > >> might not be located at the usual physical address just below 1MB. > > > > AIUI PVH is quite generic idea and can be implemented by different > > virtualization platforms. IIRC Maran Wilson works on PVH for KVM. > > So, would not it make more sense to have platform independent GRUB2 > > PVH code and then on top of that build Xen and KVM support? Could > > you do that? > > Finally I have some time to work on this series again. Great! I was a bit afraid that it will never happen... > I don't think this makes sense now for the following reasons: > > - Maran's series is stalled > - The main work is hypervisor specific and I have no idea right now > what would be needed for KVM > - Maran's series was targeted for a quick boot of the kernel right > from qemu without any other boot loader OK, so, let's leave it aside. I have seen new patchset. Thanks a lot! I will take a look at it this or next week. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On 15/02/2018 13:02, Daniel Kiper wrote: > Hi Juergen, > > Sorry for huge delay. It looks that I am recovering slowly and > probably I will have more time for reviews. > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: >> This patch series adds support for booting Linux as PVH guest. >> >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh >> platform grub is booted as a standalone image directly by Xen. >> >> For booting Linux kernel it is using the standard linux kernel >> loader. The only modification of the linux loader is to pass the >> ACPI RSDP address via boot parameters to the kernel, as that table >> might not be located at the usual physical address just below 1MB. > > AIUI PVH is quite generic idea and can be implemented by different > virtualization platforms. IIRC Maran Wilson works on PVH for KVM. > So, would not it make more sense to have platform independent GRUB2 > PVH code and then on top of that build Xen and KVM support? Could > you do that? Finally I have some time to work on this series again. I don't think this makes sense now for the following reasons: - Maran's series is stalled - The main work is hypervisor specific and I have no idea right now what would be needed for KVM - Maran's series was targeted for a quick boot of the kernel right from qemu without any other boot loader Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
Hi Juergen, Sorry for huge delay. It looks that I am recovering slowly and probably I will have more time for reviews. On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is using the standard linux kernel > loader. The only modification of the linux loader is to pass the > ACPI RSDP address via boot parameters to the kernel, as that table > might not be located at the usual physical address just below 1MB. AIUI PVH is quite generic idea and can be implemented by different virtualization platforms. IIRC Maran Wilson works on PVH for KVM. So, would not it make more sense to have platform independent GRUB2 PVH code and then on top of that build Xen and KVM support? Could you do that? Thank you for your work. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On 29/01/18 13:15, Daniel Kiper wrote: > On Thu, Dec 14, 2017 at 12:44:36PM +0100, Juergen Gross wrote: >> On 14/12/17 12:32, Daniel Kiper wrote: >>> On Thu, Dec 14, 2017 at 12:26:02PM +0100, Juergen Gross wrote: On 14/12/17 12:19, Daniel Kiper wrote: > On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: >> On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: >>> On 30/11/17 22:03, Daniel Kiper wrote: On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is using the standard linux kernel > loader. The only modification of the linux loader is to pass the > ACPI RSDP address via boot parameters to the kernel, as that table > might not be located at the usual physical address just below 1MB. > > As the related Linux kernel patches are not yet accepted please > wait for this to happen before applying the series. So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above? >>> >>> Please review! >> >> Will do in a week or so. > > Swamped by some urgent internal work. I will try to review this before > Xmas but if it do not happen then I will do it in the first halt of > January. Sorry for delays. Thanks. BTW: the Linux kernel patches have been accepted by the x86 maintainers. >>> >>> Perfect! Could you send me their commit ids? >> >> Right now they are in the tip tree in the x86/boot branch: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/boot >> >> Commit-Ids are: >> 2f74cbf947f45fa082dda8eac1a1f1299a372f49 >> 0c89cf36424f7c1177de8a5712514d7cc2eb369f >> 88750a6c33f813b815516990f01fb5ee488c477e >> 930ba49b2ce7b09a5eddc21385fd944ba6b4e829 > > My schedule was completely destroyed by many unexpected work and family > issues. It looks that I am recovering slowly. I am going to take a look > at the patches in a week or two. Should I review these ones or are you > going to post something new? There is only one issue which has to be fixed: passing on the RSDP address to the kernel will require some more work, as extending struct linux_kernel_header won't be so easy (multiple distros seem to have shipped a grub2 with some patches clobbering the data directly after that struct in the kernel). So patch 2 will be a little bit more complicated due to the need to pass the interface version known by grub2 back to the kernel. I'm not sure when I'll be able to do that work, as Meltdown has led to quite some work on my side. :-( For all other patches I'm not aware of any modifications needed. Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On Thu, Dec 14, 2017 at 12:44:36PM +0100, Juergen Gross wrote: > On 14/12/17 12:32, Daniel Kiper wrote: > > On Thu, Dec 14, 2017 at 12:26:02PM +0100, Juergen Gross wrote: > >> On 14/12/17 12:19, Daniel Kiper wrote: > >>> On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: > On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: > > On 30/11/17 22:03, Daniel Kiper wrote: > >> On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > >>> This patch series adds support for booting Linux as PVH guest. > >>> > >>> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > >>> platform grub is booted as a standalone image directly by Xen. > >>> > >>> For booting Linux kernel it is using the standard linux kernel > >>> loader. The only modification of the linux loader is to pass the > >>> ACPI RSDP address via boot parameters to the kernel, as that table > >>> might not be located at the usual physical address just below 1MB. > >>> > >>> As the related Linux kernel patches are not yet accepted please > >>> wait for this to happen before applying the series. > >> > >> So, may I review the patches or should I hold on? And could you > >> provide a link to the "Linux kernel patches" mentioned above? > > > > Please review! > > Will do in a week or so. > >>> > >>> Swamped by some urgent internal work. I will try to review this before > >>> Xmas but if it do not happen then I will do it in the first halt of > >>> January. Sorry for delays. > >> > >> Thanks. > >> > >> BTW: the Linux kernel patches have been accepted by the x86 maintainers. > > > > Perfect! Could you send me their commit ids? > > Right now they are in the tip tree in the x86/boot branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/boot > > Commit-Ids are: > 2f74cbf947f45fa082dda8eac1a1f1299a372f49 > 0c89cf36424f7c1177de8a5712514d7cc2eb369f > 88750a6c33f813b815516990f01fb5ee488c477e > 930ba49b2ce7b09a5eddc21385fd944ba6b4e829 My schedule was completely destroyed by many unexpected work and family issues. It looks that I am recovering slowly. I am going to take a look at the patches in a week or two. Should I review these ones or are you going to post something new? Sorry for delays. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On 14/12/17 12:32, Daniel Kiper wrote: > On Thu, Dec 14, 2017 at 12:26:02PM +0100, Juergen Gross wrote: >> On 14/12/17 12:19, Daniel Kiper wrote: >>> On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: > On 30/11/17 22:03, Daniel Kiper wrote: >> On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: >>> This patch series adds support for booting Linux as PVH guest. >>> >>> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh >>> platform grub is booted as a standalone image directly by Xen. >>> >>> For booting Linux kernel it is using the standard linux kernel >>> loader. The only modification of the linux loader is to pass the >>> ACPI RSDP address via boot parameters to the kernel, as that table >>> might not be located at the usual physical address just below 1MB. >>> >>> As the related Linux kernel patches are not yet accepted please >>> wait for this to happen before applying the series. >> >> So, may I review the patches or should I hold on? And could you >> provide a link to the "Linux kernel patches" mentioned above? > > Please review! Will do in a week or so. >>> >>> Swamped by some urgent internal work. I will try to review this before >>> Xmas but if it do not happen then I will do it in the first halt of >>> January. Sorry for delays. >> >> Thanks. >> >> BTW: the Linux kernel patches have been accepted by the x86 maintainers. > > Perfect! Could you send me their commit ids? Right now they are in the tip tree in the x86/boot branch: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/boot Commit-Ids are: 2f74cbf947f45fa082dda8eac1a1f1299a372f49 0c89cf36424f7c1177de8a5712514d7cc2eb369f 88750a6c33f813b815516990f01fb5ee488c477e 930ba49b2ce7b09a5eddc21385fd944ba6b4e829 Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On Thu, Dec 14, 2017 at 12:26:02PM +0100, Juergen Gross wrote: > On 14/12/17 12:19, Daniel Kiper wrote: > > On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: > >> On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: > >>> On 30/11/17 22:03, Daniel Kiper wrote: > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > > This patch series adds support for booting Linux as PVH guest. > > > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > > platform grub is booted as a standalone image directly by Xen. > > > > For booting Linux kernel it is using the standard linux kernel > > loader. The only modification of the linux loader is to pass the > > ACPI RSDP address via boot parameters to the kernel, as that table > > might not be located at the usual physical address just below 1MB. > > > > As the related Linux kernel patches are not yet accepted please > > wait for this to happen before applying the series. > > So, may I review the patches or should I hold on? And could you > provide a link to the "Linux kernel patches" mentioned above? > >>> > >>> Please review! > >> > >> Will do in a week or so. > > > > Swamped by some urgent internal work. I will try to review this before > > Xmas but if it do not happen then I will do it in the first halt of > > January. Sorry for delays. > > Thanks. > > BTW: the Linux kernel patches have been accepted by the x86 maintainers. Perfect! Could you send me their commit ids? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On 14/12/17 12:19, Daniel Kiper wrote: > On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: >> On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: >>> On 30/11/17 22:03, Daniel Kiper wrote: On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is using the standard linux kernel > loader. The only modification of the linux loader is to pass the > ACPI RSDP address via boot parameters to the kernel, as that table > might not be located at the usual physical address just below 1MB. > > As the related Linux kernel patches are not yet accepted please > wait for this to happen before applying the series. So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above? >>> >>> Please review! >> >> Will do in a week or so. > > Swamped by some urgent internal work. I will try to review this before > Xmas but if it do not happen then I will do it in the first halt of > January. Sorry for delays. Thanks. BTW: the Linux kernel patches have been accepted by the x86 maintainers. Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: > On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: > > On 30/11/17 22:03, Daniel Kiper wrote: > > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > > >> This patch series adds support for booting Linux as PVH guest. > > >> > > >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > > >> platform grub is booted as a standalone image directly by Xen. > > >> > > >> For booting Linux kernel it is using the standard linux kernel > > >> loader. The only modification of the linux loader is to pass the > > >> ACPI RSDP address via boot parameters to the kernel, as that table > > >> might not be located at the usual physical address just below 1MB. > > >> > > >> As the related Linux kernel patches are not yet accepted please > > >> wait for this to happen before applying the series. > > > > > > So, may I review the patches or should I hold on? And could you > > > provide a link to the "Linux kernel patches" mentioned above? > > > > Please review! > > Will do in a week or so. Swamped by some urgent internal work. I will try to review this before Xmas but if it do not happen then I will do it in the first halt of January. Sorry for delays. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On Fri, Dec 01, 2017 at 06:37:37AM +0100, Juergen Gross wrote: > On 30/11/17 22:03, Daniel Kiper wrote: > > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > >> This patch series adds support for booting Linux as PVH guest. > >> > >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > >> platform grub is booted as a standalone image directly by Xen. > >> > >> For booting Linux kernel it is using the standard linux kernel > >> loader. The only modification of the linux loader is to pass the > >> ACPI RSDP address via boot parameters to the kernel, as that table > >> might not be located at the usual physical address just below 1MB. > >> > >> As the related Linux kernel patches are not yet accepted please > >> wait for this to happen before applying the series. > > > > So, may I review the patches or should I hold on? And could you > > provide a link to the "Linux kernel patches" mentioned above? > > Please review! Will do in a week or so. > The Linux patches are available at: > > https://lists.xen.org/archives/html/xen-devel/2017-11/msg01681.html > > With the additional Xen patch > > https://lists.xen.org/archives/html/xen-devel/2017-11/msg01807.html > > the complete setup can be tested. Thanks, Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On 30/11/17 22:03, Daniel Kiper wrote: > On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: >> This patch series adds support for booting Linux as PVH guest. >> >> Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh >> platform grub is booted as a standalone image directly by Xen. >> >> For booting Linux kernel it is using the standard linux kernel >> loader. The only modification of the linux loader is to pass the >> ACPI RSDP address via boot parameters to the kernel, as that table >> might not be located at the usual physical address just below 1MB. >> >> As the related Linux kernel patches are not yet accepted please >> wait for this to happen before applying the series. > > So, may I review the patches or should I hold on? And could you > provide a link to the "Linux kernel patches" mentioned above? Please review! The Linux patches are available at: https://lists.xen.org/archives/html/xen-devel/2017-11/msg01681.html With the additional Xen patch https://lists.xen.org/archives/html/xen-devel/2017-11/msg01807.html the complete setup can be tested. Juergen ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 0/8] xen: add pvh guest support
On Wed, Nov 29, 2017 at 02:46:42PM +0100, Juergen Gross wrote: > This patch series adds support for booting Linux as PVH guest. > > Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh > platform grub is booted as a standalone image directly by Xen. > > For booting Linux kernel it is using the standard linux kernel > loader. The only modification of the linux loader is to pass the > ACPI RSDP address via boot parameters to the kernel, as that table > might not be located at the usual physical address just below 1MB. > > As the related Linux kernel patches are not yet accepted please > wait for this to happen before applying the series. So, may I review the patches or should I hold on? And could you provide a link to the "Linux kernel patches" mentioned above? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
[PATCH 0/8] xen: add pvh guest support
This patch series adds support for booting Linux as PVH guest. Similar to i386/xen and x86_64/xen platforms the new i386/xenpvh platform grub is booted as a standalone image directly by Xen. For booting Linux kernel it is using the standard linux kernel loader. The only modification of the linux loader is to pass the ACPI RSDP address via boot parameters to the kernel, as that table might not be located at the usual physical address just below 1MB. As the related Linux kernel patches are not yet accepted please wait for this to happen before applying the series. Juergen Gross (8): xen: add some xen headers loader/linux: support passing rsdp address via boot params xen: carve out grant tab initialization into dedicated function xen: add xen pvh guest support to grub-core xenpvh: add build runes for grub-core xenpvh: support building a standalone image xenpvh: support grub-install for xenpvh xenpvh: add support to configure configure.ac | 3 + gentpl.py | 4 +- grub-core/Makefile.am | 12 + grub-core/Makefile.core.def | 35 ++ grub-core/kern/i386/tsc.c | 2 +- grub-core/kern/i386/xen/pvh.c | 344 ++ grub-core/kern/i386/xen/startup_pvh.S | 80 grub-core/kern/xen/init.c | 101 -- grub-core/loader/i386/linux.c | 6 + include/grub/i386/linux.h | 4 +- include/grub/i386/pc/int.h| 3 + include/grub/i386/tsc.h | 2 +- include/grub/i386/xen/hypercall.h | 5 +- include/grub/i386/xenpvh/boot.h | 1 + include/grub/i386/xenpvh/console.h| 1 + include/grub/i386/xenpvh/int.h| 1 + include/grub/i386/xenpvh/kernel.h | 30 ++ include/grub/i386/xenpvh/memory.h | 54 +++ include/grub/i386/xenpvh/time.h | 1 + include/grub/kernel.h | 4 +- include/grub/offsets.h| 3 + include/grub/util/install.h | 1 + include/grub/util/mkimage.h | 3 +- include/grub/xen.h| 6 + include/xen/hvm/hvm_op.h | 296 +++ include/xen/hvm/params.h | 284 +++ include/xen/hvm/start_info.h | 98 + include/xen/memory.h | 665 ++ include/xen/physdev.h | 387 include/xen/trace.h | 339 + include/xen/xen.h | 104 -- util/grub-install-common.c| 1 + util/grub-install.c | 7 + util/grub-mkimage32.c | 1 + util/grub-mkimage64.c | 1 + util/grub-mkimagexx.c | 44 ++- util/mkimage.c| 23 +- 37 files changed, 2872 insertions(+), 84 deletions(-) create mode 100644 grub-core/kern/i386/xen/pvh.c create mode 100644 grub-core/kern/i386/xen/startup_pvh.S create mode 100644 include/grub/i386/xenpvh/boot.h create mode 100644 include/grub/i386/xenpvh/console.h create mode 100644 include/grub/i386/xenpvh/int.h create mode 100644 include/grub/i386/xenpvh/kernel.h create mode 100644 include/grub/i386/xenpvh/memory.h create mode 100644 include/grub/i386/xenpvh/time.h create mode 100644 include/xen/hvm/hvm_op.h create mode 100644 include/xen/hvm/params.h create mode 100644 include/xen/hvm/start_info.h create mode 100644 include/xen/memory.h create mode 100644 include/xen/physdev.h create mode 100644 include/xen/trace.h -- 2.12.3 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
