Re: IS: Glenn's patches status WAS: Re: [PATCH 00/12] Grub-shell improvements
On Wed, Sep 15, 2021 at 06:15:51PM +0200, Daniel Kiper wrote: > On Tue, Sep 14, 2021 at 05:27:55PM +, Glenn Washburn wrote: > > On Tue, 14 Sep 2021 13:04:31 +0200 > > Daniel Kiper wrote: > > [...] > > > > > > This is a high priority because I think it should be merged > > > > > before the keyfile and detached header support patch series. If > > > > > this is merged, I'll submit and updated keyfile and detached > > > > > header patch series that works with this patch series. > > > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to > > > > > crypto modules > > > > > > > > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > > > > > Denis, Patrick, are you both OK with this? > > > > > > I can see a discussion about this patch set. Should I wait for a new > > > version for review? > > > > Yes, there will be a new version of the patch series coming. I'm > > waiting to tie up the last concern of Patrick's. > > May I ask you to add James Bottomley to the list of recipients of this > patch series? ... and Denis 'GNUtoo' Carikli... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: IS: Glenn's patches status WAS: Re: [PATCH 00/12] Grub-shell improvements
On Tue, Sep 14, 2021 at 05:27:55PM +, Glenn Washburn wrote: > On Tue, 14 Sep 2021 13:04:31 +0200 > Daniel Kiper wrote: [...] > > > > This is a high priority because I think it should be merged > > > > before the keyfile and detached header support patch series. If > > > > this is merged, I'll submit and updated keyfile and detached > > > > header patch series that works with this patch series. > > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to > > > > crypto modules > > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > > > Denis, Patrick, are you both OK with this? > > > > I can see a discussion about this patch set. Should I wait for a new > > version for review? > > Yes, there will be a new version of the patch series coming. I'm > waiting to tie up the last concern of Patrick's. May I ask you to add James Bottomley to the list of recipients of this patch series? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: IS: Glenn's patches status WAS: Re: [PATCH 00/12] Grub-shell improvements
On Tue, 14 Sep 2021 13:04:31 +0200 Daniel Kiper wrote: > On Mon, Aug 30, 2021 at 05:23:44PM +0200, Daniel Kiper wrote: > > CC-ing Denis and Patrick... > > > > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > > > Hi Daniel, > > > > > > On Thu, 26 Aug 2021 20:00:32 +0200 > > > Daniel Kiper wrote: > > > > > > > Hi Glenn, > > > > > > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > > > > Hi Daniel, > > [...] > > > > As far as I can tell, this is the full list. > > > > Great! > > It looks I missed at least this one: > - [PATCH 00/17] Fixes and improvements for cryptodisks+luks2 and a > few other things. > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00050.html > > Do you still care about it? No, these can be skipped. The changes in that patch series that aren't integrated, are in other patch series or I'll send to the list in the future. > > > My order preference is as follows: > > > > > > These two patches are only first because it should be a quick > > > review. > > > - [PATCH] command: Add silent mode to read command to suppress > > > input echo > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > > - [PATCH] fs: Allow number of blocks in block list to be > > > optional, defaulting length to device length > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > > > OK. > > I merged them yesterday. Thanks! > > > This is a high priority because I think it should be merged > > > before the keyfile and detached header support patch series. If > > > this is merged, I'll submit and updated keyfile and detached > > > header patch series that works with this patch series. > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to > > > crypto modules > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > Denis, Patrick, are you both OK with this? > > I can see a discussion about this patch set. Should I wait for a new > version for review? Yes, there will be a new version of the patch series coming. I'm waiting to tie up the last concern of Patrick's. > > > Based on discussion with Thomas Schmitt, I think the first patch > > > of this series should be dropped. Should I make a v3, or would > > > you review it and if acceptable drop the first patch? > > > - [PATCH v2 0/8] Various fixes/improvements for tests > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html > > Next on my list for review... > > Daniel Great! I also have some more testing fixes / changes coming in this vein. Glenn ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
IS: Glenn's patches status WAS: Re: [PATCH 00/12] Grub-shell improvements
On Mon, Aug 30, 2021 at 05:23:44PM +0200, Daniel Kiper wrote: > CC-ing Denis and Patrick... > > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > On Thu, 26 Aug 2021 20:00:32 +0200 > > Daniel Kiper wrote: > > > > > Hi Glenn, > > > > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > > > Hi Daniel, [...] > > As far as I can tell, this is the full list. > > Great! It looks I missed at least this one: - [PATCH 00/17] Fixes and improvements for cryptodisks+luks2 and a few other things. https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00050.html Do you still care about it? > > My order preference is as follows: > > > > These two patches are only first because it should be a quick review. > > - [PATCH] command: Add silent mode to read command to suppress > > input echo > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > - [PATCH] fs: Allow number of blocks in block list to be optional, > > defaulting length to device length > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > OK. I merged them yesterday. > > This is a high priority because I think it should be merged before the > > keyfile and detached header support patch series. If this is merged, > > I'll submit and updated keyfile and detached header patch series that > > works with this patch series. > > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > > modules > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > Denis, Patrick, are you both OK with this? I can see a discussion about this patch set. Should I wait for a new version for review? > > Based on discussion with Thomas Schmitt, I think the first patch of > > this series should be dropped. Should I make a v3, or would you review > > it and if acceptable drop the first patch? > > - [PATCH v2 0/8] Various fixes/improvements for tests > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html Next on my list for review... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 00/12] Grub-shell improvements
On Mon, Aug 30, 2021 at 06:33:15PM +0200, Denis 'GNUtoo' Carikli wrote: > On Mon, 30 Aug 2021 17:23:44 +0200 > Daniel Kiper wrote: > > > CC-ing Denis and Patrick... > > > > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > > > Hi Daniel, > > > > > > On Thu, 26 Aug 2021 20:00:32 +0200 > > > Daniel Kiper wrote: > > > > > > > Hi Glenn, > > > > > > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > > > > Hi Daniel, > > > > > > > > > > What are the chances this patch series can be reviewed in the > > > > > near future? Some feedback would be greatly appreciated. > > > > > > > > I can see the following patches from you waiting in my review > > > > queue: > > > > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for > > > > cryptodisks+luks2 and a few other things. > > > > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html > > > > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount > > > > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html > > > > - [PATCH 0/5] Testing improvements > > > > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html > > > > - [CI 00/17] Gitlab CI and test framework improvements > > > > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html > > > > - [PROCFS 0/5] Add and improve (proc) entries > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html > > > > - [PATCH 0/4] Various LUKS2 improvements > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html > > > > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html > > > > - [PATCH] fs: Allow number of blocks in block list to be > > > > optional, defaulting length to device length > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > > > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > > > > dash-insensitive manner > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html > > > > - [PATCH] command: Add silent mode to read command to suppress > > > > input echo > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > > > - [PATCH 0/2] Allow overriding commands > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html > > > > - [PATCH 00/12] Grub-shell improvements > > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html > > > > - [PATCH v2 0/8] Various fixes/improvements for tests > > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html > > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to > > > > crypto modules > > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > > > > > Please sort them in the order of importance/preference/... Then I > > > > will be looking at them (more or less) in that order, one patch > > > > set at a time. > > > > > > > > I hope I did not miss any of your patches. > > > > > > As far as I can tell, this is the full list. > > > > Great! > > > > > My order preference is as follows: > > > > > > These two patches are only first because it should be a quick > > > review. > > > - [PATCH] command: Add silent mode to read command to suppress > > > input echo > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > > - [PATCH] fs: Allow number of blocks in block list to be optional, > > > defaulting length to device length > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > > > OK. > > > > > This is a high priority because I think it should be merged before > > > the keyfile and detached header support patch series. If this is > > > merged, I'll submit and updated keyfile and detached header patch > > > series that works with this patch series. > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > > > modules > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > Denis, Patrick, are you both OK with this? > I'm OK with it. > > The "Refactor/improve cryptomount data passing to crypto modules" looks > way cleaner than what we had before: it can scale better than the > previous design because it's more generic, it can be extended more > easily, and we can have more fine grained communication between the > cryptodisk and the backends. Agreed, this has been a pain point in the current architecture. Patrick signature.asc Description: PGP signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 00/12] Grub-shell improvements
On Mon, 30 Aug 2021 17:23:44 +0200 Daniel Kiper wrote: > CC-ing Denis and Patrick... > > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > On Thu, 26 Aug 2021 20:00:32 +0200 > > Daniel Kiper wrote: > > > > > Hi Glenn, > > > > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > > > Hi Daniel, > > > > > > > > What are the chances this patch series can be reviewed in the > > > > near future? Some feedback would be greatly appreciated. > > > > > > I can see the following patches from you waiting in my review > > > queue: > > > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for > > > cryptodisks+luks2 and a few other things. > > > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html > > > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount > > > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html > > > - [PATCH 0/5] Testing improvements > > > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html > > > - [CI 00/17] Gitlab CI and test framework improvements > > > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html > > > - [PROCFS 0/5] Add and improve (proc) entries > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html > > > - [PATCH 0/4] Various LUKS2 improvements > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html > > > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html > > > - [PATCH] fs: Allow number of blocks in block list to be > > > optional, defaulting length to device length > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > > > dash-insensitive manner > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html > > > - [PATCH] command: Add silent mode to read command to suppress > > > input echo > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > > - [PATCH 0/2] Allow overriding commands > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html > > > - [PATCH 00/12] Grub-shell improvements > > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html > > > - [PATCH v2 0/8] Various fixes/improvements for tests > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html > > > - [PATCH 0/3] Refactor/improve cryptomount data passing to > > > crypto modules > > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > > > Please sort them in the order of importance/preference/... Then I > > > will be looking at them (more or less) in that order, one patch > > > set at a time. > > > > > > I hope I did not miss any of your patches. > > > > As far as I can tell, this is the full list. > > Great! > > > My order preference is as follows: > > > > These two patches are only first because it should be a quick > > review. > > - [PATCH] command: Add silent mode to read command to suppress > > input echo > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > - [PATCH] fs: Allow number of blocks in block list to be optional, > > defaulting length to device length > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > OK. > > > This is a high priority because I think it should be merged before > > the keyfile and detached header support patch series. If this is > > merged, I'll submit and updated keyfile and detached header patch > > series that works with this patch series. > > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > > modules > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > Denis, Patrick, are you both OK with this? I'm OK with it. The "Refactor/improve cryptomount data passing to crypto modules" looks way cleaner than what we had before: it can scale better than the previous design because it's more generic, it can be extended more easily, and we can have more fine grained communication between the cryptodisk and the backends. Glenn Washburn wrote: > My intention is for this patch series to lay the foundation for an > improved patch series providing detached header and keyfile support > (I already have the series updated and ready to send once this is > accepted). Thanks a lot for that work and for taking care of the patch serie I sent. Denis. pgpbZv1PXowJY.pgp Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 00/12] Grub-shell improvements
CC-ing Denis and Patrick... On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote: > Hi Daniel, > > On Thu, 26 Aug 2021 20:00:32 +0200 > Daniel Kiper wrote: > > > Hi Glenn, > > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > > Hi Daniel, > > > > > > What are the chances this patch series can be reviewed in the near > > > future? Some feedback would be greatly appreciated. > > > > I can see the following patches from you waiting in my review queue: > > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for > > cryptodisks+luks2 and a few other things. > > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html > > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount > > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html > > - [PATCH 0/5] Testing improvements > > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html > > - [CI 00/17] Gitlab CI and test framework improvements > > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html > > - [PROCFS 0/5] Add and improve (proc) entries > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html > > - [PATCH 0/4] Various LUKS2 improvements > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html > > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html > > - [PATCH] fs: Allow number of blocks in block list to be optional, > > defaulting length to device length > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > > dash-insensitive manner > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html > > - [PATCH] command: Add silent mode to read command to suppress > > input echo > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > > - [PATCH 0/2] Allow overriding commands > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html > > - [PATCH 00/12] Grub-shell improvements > > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html > > - [PATCH v2 0/8] Various fixes/improvements for tests > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html > > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > > modules > > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > > > Please sort them in the order of importance/preference/... Then I > > will be looking at them (more or less) in that order, one patch set > > at a time. > > > > I hope I did not miss any of your patches. > > As far as I can tell, this is the full list. Great! > My order preference is as follows: > > These two patches are only first because it should be a quick review. > - [PATCH] command: Add silent mode to read command to suppress > input echo > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > - [PATCH] fs: Allow number of blocks in block list to be optional, > defaulting length to device length > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html OK. > This is a high priority because I think it should be merged before the > keyfile and detached header support patch series. If this is merged, > I'll submit and updated keyfile and detached header patch series that > works with this patch series. > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > modules > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html Denis, Patrick, are you both OK with this? > Based on discussion with Thomas Schmitt, I think the first patch of > this series should be dropped. Should I make a v3, or would you review > it and if acceptable drop the first patch? > - [PATCH v2 0/8] Various fixes/improvements for tests > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html No, you do not need to repost. I will take a look at v2 and ignore first patch in it. > Then these in this order. > - [PATCH 00/12] Grub-shell improvements > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html > - [PATCH 0/4] Various LUKS2 improvements > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html > - [PROCFS 0/5] Add and improve (proc) entries > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > dash-insensitive manner >
Re: [PATCH 00/12] Grub-shell improvements
Hi Daniel, On Thu, 26 Aug 2021 20:00:32 +0200 Daniel Kiper wrote: > Hi Glenn, > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > > Hi Daniel, > > > > What are the chances this patch series can be reviewed in the near > > future? Some feedback would be greatly appreciated. > > I can see the following patches from you waiting in my review queue: > - [CRYPTO-LUKS v1 00/19] Fixes and improvements for > cryptodisks+luks2 and a few other things. > https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html > - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount > https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html > - [PATCH 0/5] Testing improvements > https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html > - [CI 00/17] Gitlab CI and test framework improvements > https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html > - [PROCFS 0/5] Add and improve (proc) entries > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html > - [PATCH 0/4] Various LUKS2 improvements > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html > - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html > - [PATCH] fs: Allow number of blocks in block list to be optional, > defaulting length to device length > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html > - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a > dash-insensitive manner > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html > - [PATCH] command: Add silent mode to read command to suppress > input echo > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html > - [PATCH 0/2] Allow overriding commands > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html > - [PATCH 00/12] Grub-shell improvements > https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html > - [PATCH v2 0/8] Various fixes/improvements for tests > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html > - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto > modules > https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html > > Please sort them in the order of importance/preference/... Then I > will be looking at them (more or less) in that order, one patch set > at a time. > > I hope I did not miss any of your patches. As far as I can tell, this is the full list. My order preference is as follows: These two patches are only first because it should be a quick review. - [PATCH] command: Add silent mode to read command to suppress input echo https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html - [PATCH] fs: Allow number of blocks in block list to be optional, defaulting length to device length https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html This is a high priority because I think it should be merged before the keyfile and detached header support patch series. If this is merged, I'll submit and updated keyfile and detached header patch series that works with this patch series. - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto modules https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html Based on discussion with Thomas Schmitt, I think the first patch of this series should be dropped. Should I make a v3, or would you review it and if acceptable drop the first patch? - [PATCH v2 0/8] Various fixes/improvements for tests https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html Then these in this order. - [PATCH 00/12] Grub-shell improvements https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html - [PATCH 0/4] Various LUKS2 improvements https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html - [PROCFS 0/5] Add and improve (proc) entries https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html - [PATCH 0/2] Allow overriding commands https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html Patch series with dependencies This patch series requires keyfile support via the -k argument for cryptomount. So it must be reviewed after a patch series implementing this. Also, iirc, this series relies on "Grub-shell improvements". Ideally this would get reviewe
Re: [PATCH 00/12] Grub-shell improvements
Hi Glenn, On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote: > Hi Daniel, > > What are the chances this patch series can be reviewed in the near > future? Some feedback would be greatly appreciated. I can see the following patches from you waiting in my review queue: - [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2 and a few other things. https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00088.html - [CRYPTOMOUNT-TEST 0/7] Add LUKS1/2 tests for cryptomount https://lists.gnu.org/archive/html/grub-devel/2020-08/msg00010.html - [PATCH 0/5] Testing improvements https://lists.gnu.org/archive/html/grub-devel/2020-12/msg00246.html - [CI 00/17] Gitlab CI and test framework improvements https://lists.gnu.org/archive/html/grub-devel/2021-02/msg00071.html - [PROCFS 0/5] Add and improve (proc) entries https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00264.html - [PATCH 0/4] Various LUKS2 improvements https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00272.html - [PATCH 0/4] Miscellaneous changes to aid in troubleshooting https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00279.html - [PATCH] fs: Allow number of blocks in block list to be optional, defaulting length to device length https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html - [PATCH v2 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00344.html - [PATCH] command: Add silent mode to read command to suppress input echo https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html - [PATCH 0/2] Allow overriding commands https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00292.html - [PATCH 00/12] Grub-shell improvements https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00390.html - [PATCH v2 0/8] Various fixes/improvements for tests https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html - [PATCH 0/3] Refactor/improve cryptomount data passing to crypto modules https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html Please sort them in the order of importance/preference/... Then I will be looking at them (more or less) in that order, one patch set at a time. I hope I did not miss any of your patches. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 00/12] Grub-shell improvements
Hi Daniel, What are the chances this patch series can be reviewed in the near future? Some feedback would be greatly appreciated. Glenn On Wed, 31 Mar 2021 20:57:39 -0500 Glenn Washburn wrote: > I've extracted this patch series from the GitLab CI patch series, > which some minor modifications. Mostly these are improvements to > grub-shell to facilitate debugging. > > The only patch that might be considered a fix, as opposed to an > improvement, would be patch #11, which fixes the issue where > qemu-mips is given a non-existant machine type. And while this was > discussed here on the list as a possible solution, I couldn't get the > mips tests working, so I'm not sure it's the right fix. > > Glenn > > Glenn Washburn (12): > grub-shell: Allow specifying non-default trim line contents > grub-shell: Trim line should always be matched from the beginning of > the line > grub-shell: Only show grub-mkrescue output if it returns an error > grub-shell: Allow setting default timeout via > GRUB_SHELL_DEFAULT_TIMEOUT envvar > grub-shell: Put all generated files into working dir and use better > file names > grub-shell: Add grub output logfile with grub-shell --debug > grub-shell: Set exit status to qemu exit status > tests: Allow turning on shell tracing from environment variables > grub-shell: Add --verbose to mkrescue when $debug is greater than 2 > grub-shell: Only turn on qemu head when large debug value is > specified grub-shell: Use malta qemu-mips machine type instead off > non-existant indy > grub-shell: Update qemu UEFI firmware names to be more generic > > tests/util/grub-fs-tester.in | 2 + > tests/util/grub-shell.in | 89 > 2 files changed, 63 > insertions(+), 28 deletions(-) > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
[PATCH 00/12] Grub-shell improvements
I've extracted this patch series from the GitLab CI patch series, which some minor modifications. Mostly these are improvements to grub-shell to facilitate debugging. The only patch that might be considered a fix, as opposed to an improvement, would be patch #11, which fixes the issue where qemu-mips is given a non-existant machine type. And while this was discussed here on the list as a possible solution, I couldn't get the mips tests working, so I'm not sure it's the right fix. Glenn Glenn Washburn (12): grub-shell: Allow specifying non-default trim line contents grub-shell: Trim line should always be matched from the beginning of the line grub-shell: Only show grub-mkrescue output if it returns an error grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar grub-shell: Put all generated files into working dir and use better file names grub-shell: Add grub output logfile with grub-shell --debug grub-shell: Set exit status to qemu exit status tests: Allow turning on shell tracing from environment variables grub-shell: Add --verbose to mkrescue when $debug is greater than 2 grub-shell: Only turn on qemu head when large debug value is specified grub-shell: Use malta qemu-mips machine type instead off non-existant indy grub-shell: Update qemu UEFI firmware names to be more generic tests/util/grub-fs-tester.in | 2 + tests/util/grub-shell.in | 89 2 files changed, 63 insertions(+), 28 deletions(-) -- 2.27.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
