Re: [PATCH 1/3] Import libgcrypt 1.10.3
On Tue, May 21, 2024 at 01:36:18PM +0300, Vladimir 'phcoder' Serbinenko wrote: > I think at least AUTHORS and COPYING should be included. I see the point to keep AUTHORS and COPYING but other library such minilzo only copies the essential .c/.h files. > Rest is for the ease of update in the future. Those unused files seem not very helpful for the future update. IMHO, what we need is how libgcrypt is imported, so that developers can reproduce the code and follow the steps to update in the future. Thanks, Gary Lin > > Le mar. 21 mai 2024, 10:32, Gary Lin a écrit : > > > Hi Vladimir, > > > > Originally, there are only cipher, mpi, and src in the libgcrypt > > directory, but the unnecessary stuff, e.g. AUTHORS, COPYING, build-aux, > > tests, etc., was added and bloated the size of the patch. Could you > > remove them and only keep the necessary files? > > > > Thanks, > > > > Gary Lin > > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 1/3] Import libgcrypt 1.10.3
I think at least AUTHORS and COPYING should be included. Rest is for the ease of update in the future. Le mar. 21 mai 2024, 10:32, Gary Lin a écrit : > Hi Vladimir, > > Originally, there are only cipher, mpi, and src in the libgcrypt > directory, but the unnecessary stuff, e.g. AUTHORS, COPYING, build-aux, > tests, etc., was added and bloated the size of the patch. Could you > remove them and only keep the necessary files? > > Thanks, > > Gary Lin > ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 1/3] Import libgcrypt 1.10.3
Hi Vladimir, Originally, there are only cipher, mpi, and src in the libgcrypt directory, but the unnecessary stuff, e.g. AUTHORS, COPYING, build-aux, tests, etc., was added and bloated the size of the patch. Could you remove them and only keep the necessary files? Thanks, Gary Lin ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 1/3] Import libgcrypt 1.10.3
Adding a few folks who are probably interested in this series... May I ask you to add a few words to the commit message saying why this change is needed? And please do not forget to add your SOB to this and other patches. Ah, and missing cover letter... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
