[PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-01-31 Thread Peter Jones 
This way debuginfo built from the .module will still include this
information, but the final result won't have the data we don't actually
need in the modules, either on-disk, loaded at runtime, or in prebuilt
images.

Signed-off-by: Peter Jones 
---
 grub-core/genmod.sh.in | 4 
 1 file changed, 4 insertions(+)

diff --git a/grub-core/genmod.sh.in b/grub-core/genmod.sh.in
index 3de06ee018f..1250589b3f5 100644
--- a/grub-core/genmod.sh.in
+++ b/grub-core/genmod.sh.in
@@ -58,6 +58,10 @@ if test x@TARGET_APPLE_LINKER@ != x1; then
-K grub_mod_init -K grub_mod_fini \
-K _grub_mod_init -K _grub_mod_fini \
-R .note.gnu.gold-version -R .note.GNU-stack \
+   -R .gnu.build.attributes \
+   -R .rel.gnu.build.attributes \
+   -R .rela.gnu.build.attributes \
+   -R .eh_frame -R .rela.eh_frame -R .rel.eh_frame \
-R .note -R .comment -R .ARM.exidx $tmpfile || exit 1
fi
if ! test -z "${TARGET_OBJ2ELF}"; then
-- 
2.15.0


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-15 Thread Vladimir 'phcoder' Serbinenko 
LGTM

Le mer. 31 janv. 2018 à 17:28, Peter Jones  a écrit :

> This way debuginfo built from the .module will still include this
> information, but the final result won't have the data we don't actually
> need in the modules, either on-disk, loaded at runtime, or in prebuilt
> images.
>
> Signed-off-by: Peter Jones 
> ---
>  grub-core/genmod.sh.in | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/grub-core/genmod.sh.in b/grub-core/genmod.sh.in
> index 3de06ee018f..1250589b3f5 100644
> --- a/grub-core/genmod.sh.in
> +++ b/grub-core/genmod.sh.in
> @@ -58,6 +58,10 @@ if test x@TARGET_APPLE_LINKER@ != x1; then
> -K grub_mod_init -K grub_mod_fini \
> -K _grub_mod_init -K _grub_mod_fini \
> -R .note.gnu.gold-version -R .note.GNU-stack \
> +   -R .gnu.build.attributes \
> +   -R .rel.gnu.build.attributes \
> +   -R .rela.gnu.build.attributes \
> +   -R .eh_frame -R .rela.eh_frame -R .rel.eh_frame \
> -R .note -R .comment -R .ARM.exidx $tmpfile || exit 1
> fi
> if ! test -z "${TARGET_OBJ2ELF}"; then
> --
> 2.15.0
>
>
> ___
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-20 Thread Daniel Kiper 
On Wed, Jan 31, 2018 at 11:27:00AM -0500, Peter Jones wrote:
> This way debuginfo built from the .module will still include this
> information, but the final result won't have the data we don't actually
> need in the modules, either on-disk, loaded at runtime, or in prebuilt
> images.
>
> Signed-off-by: Peter Jones 

Reviewed-by: Daniel Kiper 

I suppose that I can apply this patch without patch 1
but I would like to be sure... So?

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-20 Thread Peter Jones 
On Tue, Feb 20, 2018 at 03:51:59PM +0100, Daniel Kiper wrote:
> On Wed, Jan 31, 2018 at 11:27:00AM -0500, Peter Jones wrote:
> > This way debuginfo built from the .module will still include this
> > information, but the final result won't have the data we don't actually
> > need in the modules, either on-disk, loaded at runtime, or in prebuilt
> > images.
> >
> > Signed-off-by: Peter Jones 
> 
> Reviewed-by: Daniel Kiper 
> 
> I suppose that I can apply this patch without patch 1
> but I would like to be sure... So?

Yes, it should be completely safe.

-- 
  Peter

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel